Changeset 88002 in webkit

Timestamp:

Jun 3, 2011 3:35:54 AM (13 years ago)

Author:

dominicc@chromium.org

Message:

2011-06-03 Dominic Cooney <​dominicc@chromium.org>

Reviewed by Kent Tamura.

Adds a test that keygen clones have the right shadow pseudoclass.
​https://bugs.webkit.org/show_bug.cgi?id=61984

• fast/html/clone-keygen-expected.txt: Added.
• fast/html/clone-keygen.html: Added.
• platform/win/Skipped: Test needs DRT functionality not in this port.

2011-06-03 Dominic Cooney <​dominicc@chromium.org>

Reviewed by Kent Tamura.

Cloned keygen shadows should have -webkit-keygen-select pseudoclass.
​https://bugs.webkit.org/show_bug.cgi?id=61984

When cloneNode's tag name-based cloning algorithm clones the
KeygenSelectElements of a keygen shadow as select elements. These
lack the -webkit-keygen-select pseudoclass.

Test: fast/html/clone-keygen.html

• html/HTMLKeygenElement.cpp: (WebCore::KeygenSelectElement::cloneElementWithoutAttributesAndChildren): Create a KeygenSelectElement when being cloned.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/html/clone-keygen-expected.txt (added)
• LayoutTests/fast/html/clone-keygen.html (added)
• LayoutTests/platform/win/Skipped (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLKeygenElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-06-03  Dominic Cooney  <dominicc@chromium.org>
+
+        Reviewed by Kent Tamura.
+
+        Adds a test that keygen clones have the right shadow pseudoclass.
+        https://bugs.webkit.org/show_bug.cgi?id=61984
+
+        * fast/html/clone-keygen-expected.txt: Added.
+        * fast/html/clone-keygen.html: Added.
+        * platform/win/Skipped: Test needs DRT functionality not in this port.
+
 2011-06-03  Mario Sanchez Prada  <msanchez@igalia.com>
 

trunk/LayoutTests/platform/win/Skipped

@@ -1286 +1286 @@
 # https://bugs.webkit.org/show_bug.cgi?id=59081
 fast/dom/shadow
+fast/html/clone-keygen.html
 fast/html/clone-range.html
 inspector/elements/shadow-dom.html

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-03  Dominic Cooney  <dominicc@chromium.org>
+
+        Reviewed by Kent Tamura.
+
+        Cloned keygen shadows should have -webkit-keygen-select pseudoclass.
+        https://bugs.webkit.org/show_bug.cgi?id=61984
+
+        When cloneNode's tag name-based cloning algorithm clones the
+        KeygenSelectElements of a keygen shadow as select elements. These
+        lack the -webkit-keygen-select pseudoclass.
+
+        Test: fast/html/clone-keygen.html
+
+        * html/HTMLKeygenElement.cpp:
+        (WebCore::KeygenSelectElement::cloneElementWithoutAttributesAndChildren): Create a KeygenSelectElement when being cloned.
+
 2011-06-02  MORITA Hajime  <morrita@google.com>
         

trunk/Source/WebCore/html/HTMLKeygenElement.cpp

@@ -60 +60 @@
         : HTMLSelectElement(selectTag, document, 0)
     {
+    }
+
+private:
+    virtual PassRefPtr<Element> cloneElementWithoutAttributesAndChildren() const
+    {
+        return create(document());
     }
 };