Changeset 88029 in webkit


Ignore:
Timestamp:
Jun 3, 2011 10:03:21 AM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-06-03 Doreen Jiang <​doreen.jiang@nokia.com>

Reviewed by Benjamin Poulain.

[Qt]The minimum size of the select menu list is incorrect for qtwebkit
​https://bugs.webkit.org/show_bug.cgi?id=56752

The test is to get the render tree of select menu lists with varying widths based on content.
Some select list based tests are rebaselined because minimum width of RenderMenuList changes
based on the content with this fix.

  • fast/forms/selectlist-minsize.html: Added.
  • platform/mac/fast/forms/selectlist-minsize-expected.txt: Added.
  • platform/qt/editing/pasteboard/4641033-expected.txt:
  • platform/qt/editing/pasteboard/4944770-1-expected.txt:
  • platform/qt/editing/pasteboard/4944770-2-expected.txt:
  • platform/qt/editing/selection/caret-before-select-expected.txt:
  • platform/qt/fast/forms/003-expected.txt:
  • platform/qt/fast/forms/004-expected.txt:
  • platform/qt/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/qt/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/qt/fast/forms/basic-selects-expected.txt:
  • platform/qt/fast/forms/menulist-deselect-update-expected.txt:
  • platform/qt/fast/forms/menulist-separator-painting-expected.txt:
  • platform/qt/fast/forms/menulist-style-color-expected.txt:
  • platform/qt/fast/forms/option-script-expected.txt:
  • platform/qt/fast/forms/select-background-none-expected.txt:
  • platform/qt/fast/forms/select-baseline-expected.txt:
  • platform/qt/fast/forms/select-dirty-parent-pref-widths-expected.txt:
  • platform/qt/fast/forms/select-empty-option-height-expected.txt:
  • platform/qt/fast/forms/select-size-expected.txt:
  • platform/qt/fast/forms/select-style-expected.txt:
  • platform/qt/fast/forms/selectlist-minsize-expected.txt: Added.
  • platform/qt/fast/invalid/014-expected.txt:
  • platform/qt/fast/replaced/replaced-breaking-expected.txt:
  • platform/qt/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/qt/fast/replaced/three-selects-break-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug29326-expected.txt:
  • platform/qt/tables/mozilla/core/margins-expected.txt:

2011-06-03 Doreen Jiang <​doreen.jiang@nokia.com>

Reviewed by Benjamin Poulain.

[Qt]The minimum size of the select menu list is incorrect for qtwebkit
​https://bugs.webkit.org/show_bug.cgi?id=56752

The minimum width of the select-box is calculated to be as small as possible
instead of hardcoded value (width of 7 characters) in minimumMenuListSize() function
This will avoid overapping the select lists in popular websites.

Test: fast/forms/selectlist-minsize.html

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::minimumMenuListSize):
Location:
trunk
Files:
3 added
28 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r88028 r88029  
     12011-06-03  Doreen Jiang  <doreen.jiang@nokia.com>
     2
     3        Reviewed by Benjamin Poulain.
     4
     5        [Qt]The minimum size of the select menu list is incorrect for qtwebkit
     6        https://bugs.webkit.org/show_bug.cgi?id=56752
     7
     8        The test is to get the render tree of select menu lists with varying widths based on content.
     9        Some select list based tests are rebaselined because minimum width of RenderMenuList changes
     10        based on the content with this fix.
     11
     12        * fast/forms/selectlist-minsize.html: Added.
     13        * platform/mac/fast/forms/selectlist-minsize-expected.txt: Added.
     14        * platform/qt/editing/pasteboard/4641033-expected.txt:
     15        * platform/qt/editing/pasteboard/4944770-1-expected.txt:
     16        * platform/qt/editing/pasteboard/4944770-2-expected.txt:
     17        * platform/qt/editing/selection/caret-before-select-expected.txt:
     18        * platform/qt/fast/forms/003-expected.txt:
     19        * platform/qt/fast/forms/004-expected.txt:
     20        * platform/qt/fast/forms/HTMLOptionElement_label06-expected.txt:
     21        * platform/qt/fast/forms/HTMLOptionElement_label07-expected.txt:
     22        * platform/qt/fast/forms/basic-selects-expected.txt:
     23        * platform/qt/fast/forms/menulist-deselect-update-expected.txt:
     24        * platform/qt/fast/forms/menulist-separator-painting-expected.txt:
     25        * platform/qt/fast/forms/menulist-style-color-expected.txt:
     26        * platform/qt/fast/forms/option-script-expected.txt:
     27        * platform/qt/fast/forms/select-background-none-expected.txt:
     28        * platform/qt/fast/forms/select-baseline-expected.txt:
     29        * platform/qt/fast/forms/select-dirty-parent-pref-widths-expected.txt:
     30        * platform/qt/fast/forms/select-empty-option-height-expected.txt:
     31        * platform/qt/fast/forms/select-size-expected.txt:
     32        * platform/qt/fast/forms/select-style-expected.txt:
     33        * platform/qt/fast/forms/selectlist-minsize-expected.txt: Added.
     34        * platform/qt/fast/invalid/014-expected.txt:
     35        * platform/qt/fast/replaced/replaced-breaking-expected.txt:
     36        * platform/qt/fast/replaced/replaced-breaking-mixture-expected.txt:
     37        * platform/qt/fast/replaced/three-selects-break-expected.txt:
     38        * platform/qt/tables/mozilla/bugs/bug29326-expected.txt:
     39        * platform/qt/tables/mozilla/core/margins-expected.txt:
     40
    1412011-06-03  Marcus Bulach  <bulach@chromium.org>
    242

  • trunk/LayoutTests/platform/qt/editing/pasteboard/4641033-expected.txt

    r83871 r88029  
    2121        RenderText {#text} at (76,87) size 4x22
    2222          text run at (76,87) width 4: " "
    23         RenderMenuList {SELECT} at (82,85) size 70x27 [bgcolor=#FFFFFF]
    24           RenderBlock (anonymous) at (4,2) size 42x22
     23        RenderMenuList {SELECT} at (82,85) size 52x27 [bgcolor=#FFFFFF]
     24          RenderBlock (anonymous) at (4,2) size 24x22
    2525            RenderText at (0,0) size 8x22
    2626              text run at (0,0) width 8: "1"
    … …  
    2929        RenderText {#text} at (76,87) size 4x22
    3030          text run at (76,87) width 4: " "
    31         RenderMenuList {SELECT} at (82,85) size 70x27 [bgcolor=#FFFFFF]
    32           RenderBlock (anonymous) at (4,2) size 42x22
     31        RenderMenuList {SELECT} at (82,85) size 52x27 [bgcolor=#FFFFFF]
     32          RenderBlock (anonymous) at (4,2) size 24x22
    3333            RenderText at (0,0) size 8x22
    3434              text run at (0,0) width 8: "1"

  • trunk/LayoutTests/platform/qt/editing/pasteboard/4944770-1-expected.txt

    r83871 r88029  
    1212        RenderText {#text} at (0,4) size 21x22
    1313          text run at (0,4) width 21: "foo"
    14         RenderMenuList {SELECT} at (23,2) size 70x27 [bgcolor=#FFFFFF]
    15           RenderBlock (anonymous) at (4,2) size 42x22
     14        RenderMenuList {SELECT} at (23,2) size 36x27 [bgcolor=#FFFFFF]
     15          RenderBlock (anonymous) at (4,2) size 8x22
    1616            RenderText at (0,0) size 8x22
    1717              text run at (0,0) width 8: "1"
    … …  
    1919        RenderText {#text} at (0,4) size 21x22
    2020          text run at (0,4) width 21: "foo"
    21         RenderMenuList {SELECT} at (23,2) size 70x27 [bgcolor=#FFFFFF]
    22           RenderBlock (anonymous) at (4,2) size 42x22
     21        RenderMenuList {SELECT} at (23,2) size 36x27 [bgcolor=#FFFFFF]
     22          RenderBlock (anonymous) at (4,2) size 8x22
    2323            RenderText at (0,0) size 8x22
    2424              text run at (0,0) width 8: "1"

  • trunk/LayoutTests/platform/qt/editing/pasteboard/4944770-2-expected.txt

    r83871 r88029  
    1010          text run at (0,22) width 112: "inserted content."
    1111      RenderBlock {DIV} at (0,60) size 784x31
    12         RenderMenuList {SELECT} at (2,2) size 70x27 [bgcolor=#FFFFFF]
    13           RenderBlock (anonymous) at (4,2) size 42x22
     12        RenderMenuList {SELECT} at (2,2) size 36x27 [bgcolor=#FFFFFF]
     13          RenderBlock (anonymous) at (4,2) size 8x22
    1414            RenderText at (0,0) size 8x22
    1515              text run at (0,0) width 8: "1"
    … …  
    1919        RenderText {#text} at (8,4) size 4x22
    2020          text run at (8,4) width 4: " "
    21         RenderMenuList {SELECT} at (14,2) size 70x27 [bgcolor=#FFFFFF]
    22           RenderBlock (anonymous) at (4,2) size 42x22
     21        RenderMenuList {SELECT} at (14,2) size 36x27 [bgcolor=#FFFFFF]
     22          RenderBlock (anonymous) at (4,2) size 8x22
    2323            RenderText at (0,0) size 8x22
    2424              text run at (0,0) width 8: "1"
    25         RenderText {#text} at (86,4) size 4x22
    26           text run at (86,4) width 4: " "
    27         RenderText {#text} at (90,4) size 8x22
    28           text run at (90,4) width 8: "x"
     25        RenderText {#text} at (52,4) size 4x22
     26          text run at (52,4) width 4: " "
     27        RenderText {#text} at (56,4) size 8x22
     28          text run at (56,4) width 8: "x"
    2929caret: position 1 of child 3 {#text} of child 4 {DIV} of body

  • trunk/LayoutTests/platform/qt/editing/selection/caret-before-select-expected.txt

    r83871 r88029  
    55    RenderBody {BODY} at (8,8) size 784x584
    66      RenderBlock {DIV} at (0,0) size 784x105 [border: (5px solid #FF0000)]
    7         RenderMenuList {SELECT} at (39,39) size 70x27 [bgcolor=#FFFFFF]
    8           RenderBlock (anonymous) at (4,2) size 42x22
     7        RenderMenuList {SELECT} at (39,39) size 56x27 [bgcolor=#FFFFFF]
     8          RenderBlock (anonymous) at (4,2) size 28x22
    99            RenderText at (0,0) size 28x22
    1010              text run at (0,0) width 28: "One"
    11         RenderText {#text} at (111,41) size 29x22
    12           text run at (111,41) width 29: "blaa"
     11        RenderText {#text} at (97,41) size 29x22
     12          text run at (97,41) width 29: "blaa"
    1313caret: position 0 of child 0 {SELECT} of child 0 {DIV} of body

  • trunk/LayoutTests/platform/qt/fast/forms/003-expected.txt

    r84735 r88029  
    44  RenderBlock {HTML} at (0,0) size 800x600
    55    RenderBody {BODY} at (8,8) size 784x584
    6       RenderMenuList {SELECT} at (2,0) size 70x27 [bgcolor=#FFFFFF]
    7         RenderBlock (anonymous) at (4,2) size 42x22
     6      RenderMenuList {SELECT} at (2,0) size 63x27 [bgcolor=#FFFFFF]
     7        RenderBlock (anonymous) at (4,2) size 35x22
    88          RenderText at (0,0) size 35x22
    99            text run at (0,0) width 35: "Hello"

  • trunk/LayoutTests/platform/qt/fast/forms/004-expected.txt

    r84735 r88029  
    44  RenderBlock {HTML} at (0,0) size 800x600
    55    RenderBody {BODY} at (8,8) size 784x584
    6       RenderMenuList {SELECT} at (2,2) size 70x27 [bgcolor=#FFFFFF]
    7         RenderBlock (anonymous) at (4,2) size 42x22
     6      RenderMenuList {SELECT} at (2,2) size 63x27 [bgcolor=#FFFFFF]
     7        RenderBlock (anonymous) at (4,2) size 35x22
    88          RenderText at (0,0) size 35x22
    99            text run at (0,0) width 35: "Hello"
    10       RenderText {#text} at (74,4) size 4x22
    11         text run at (74,4) width 4: " "
    12       RenderMenuList {SELECT} at (80,2) size 89x27 [bgcolor=#FFFFFF]
     10      RenderText {#text} at (67,4) size 4x22
     11        text run at (67,4) width 4: " "
     12      RenderMenuList {SELECT} at (73,2) size 89x27 [bgcolor=#FFFFFF]
    1313        RenderBlock (anonymous) at (4,2) size 61x22
    1414          RenderText at (0,0) size 61x22

  • trunk/LayoutTests/platform/qt/fast/forms/HTMLOptionElement_label06-expected.txt

    r84735 r88029  
    77        text run at (0,0) width 757: "The select item below has a label specified, and no enclosed text. There should be no text shown in the select box."
    88      RenderBR {BR} at (757,16) size 0x0
    9       RenderMenuList {SELECT} at (2,24) size 70x27 [bgcolor=#FFFFFF]
    10         RenderBlock (anonymous) at (4,2) size 42x22
     9      RenderMenuList {SELECT} at (2,24) size 34x27 [bgcolor=#FFFFFF]
     10        RenderBlock (anonymous) at (4,2) size 6x22
    1111          RenderBR at (0,0) size 0x22 [bgcolor=#FFFFFF]
    1212      RenderText {#text} at (0,0) size 0x0

  • trunk/LayoutTests/platform/qt/fast/forms/HTMLOptionElement_label07-expected.txt

    r84735 r88029  
    88        text run at (0,22) width 94: "the select box."
    99      RenderBR {BR} at (94,38) size 0x0
    10       RenderMenuList {SELECT} at (2,46) size 70x27 [bgcolor=#FFFFFF]
    11         RenderBlock (anonymous) at (4,2) size 42x22
     10      RenderMenuList {SELECT} at (2,46) size 34x27 [bgcolor=#FFFFFF]
     11        RenderBlock (anonymous) at (4,2) size 6x22
    1212          RenderBR at (0,0) size 0x22 [bgcolor=#FFFFFF]
    1313      RenderText {#text} at (0,0) size 0x0

  • trunk/LayoutTests/platform/qt/fast/forms/basic-selects-expected.txt

    r85025 r88029  
    77        RenderText {#text} at (1,5) size 176x22
    88          text run at (1,5) width 176: "Whitespace in option text:"
    9         RenderMenuList {SELECT} at (179,3) size 70x27 [bgcolor=#FFFFFF]
    10           RenderBlock (anonymous) at (4,2) size 42x22
     9        RenderMenuList {SELECT} at (179,3) size 57x27 [bgcolor=#FFFFFF]
     10          RenderBlock (anonymous) at (4,2) size 29x22
    1111            RenderText at (0,0) size 29x22
    1212              text run at (0,0) width 29: "f o o"
    13         RenderText {#text} at (251,5) size 8x22
    14           text run at (251,5) width 8: "a"
    15         RenderMenuList {SELECT} at (261,3) size 70x27 [bgcolor=#FFFFFF]
    16           RenderBlock (anonymous) at (4,2) size 42x22
     13        RenderText {#text} at (238,5) size 8x22
     14          text run at (238,5) width 8: "a"
     15        RenderMenuList {SELECT} at (248,3) size 57x27 [bgcolor=#FFFFFF]
     16          RenderBlock (anonymous) at (4,2) size 29x22
    1717            RenderText at (0,0) size 29x22
    1818              text run at (0,0) width 29: "f o o"
    19         RenderText {#text} at (333,5) size 9x22
    20           text run at (333,5) width 9: "b"
    21         RenderBR {BR} at (342,5) size 0x22
     19        RenderText {#text} at (307,5) size 9x22
     20          text run at (307,5) width 9: "b"
     21        RenderBR {BR} at (316,5) size 0x22
    2222        RenderBR {BR} at (1,29) size 0x22
    2323        RenderText {#text} at (1,52) size 143x22
    2424          text run at (1,52) width 143: "Simple select control:"
    25         RenderMenuList {SELECT} at (146,50) size 70x27 [bgcolor=#FFFFFF]
    26           RenderBlock (anonymous) at (4,2) size 42x22
     25        RenderMenuList {SELECT} at (146,50) size 52x27 [bgcolor=#FFFFFF]
     26          RenderBlock (anonymous) at (4,2) size 24x22
    2727            RenderText at (0,0) size 21x22
    2828              text run at (0,0) width 21: "foo"
    29         RenderText {#text} at (218,52) size 8x22
    30           text run at (218,52) width 8: "a"
    31         RenderMenuList {SELECT} at (228,50) size 70x27 [color=#808080] [bgcolor=#FFFFFF]
    32           RenderBlock (anonymous) at (4,2) size 42x22
     29        RenderText {#text} at (200,52) size 8x22
     30          text run at (200,52) width 8: "a"
     31        RenderMenuList {SELECT} at (210,50) size 52x27 [color=#808080] [bgcolor=#FFFFFF]
     32          RenderBlock (anonymous) at (4,2) size 24x22
    3333            RenderText at (0,0) size 21x22
    3434              text run at (0,0) width 21: "foo"
    35         RenderText {#text} at (300,52) size 9x22
    36           text run at (300,52) width 9: "b"
    37         RenderBR {BR} at (309,52) size 0x22
     35        RenderText {#text} at (264,52) size 9x22
     36          text run at (264,52) width 9: "b"
     37        RenderBR {BR} at (273,52) size 0x22
    3838        RenderBR {BR} at (1,76) size 0x22
    3939        RenderText {#text} at (1,104) size 208x22
    4040          text run at (1,104) width 208: "Line-height should be ignored:"
    41         RenderMenuList {SELECT} at (211,97) size 70x36 [bgcolor=#FFFFFF]
    42           RenderBlock (anonymous) at (4,2) size 42x32
     41        RenderMenuList {SELECT} at (211,97) size 49x36 [bgcolor=#FFFFFF]
     42          RenderBlock (anonymous) at (4,2) size 21x32
    4343            RenderText at (0,5) size 21x22
    4444              text run at (0,5) width 21: "foo"
    45         RenderText {#text} at (283,104) size 8x22
    46           text run at (283,104) width 8: "a"
    47         RenderMenuList {SELECT} at (293,97) size 70x36 [color=#808080] [bgcolor=#FFFFFF]
    48           RenderBlock (anonymous) at (4,2) size 42x32
     45        RenderText {#text} at (262,104) size 8x22
     46          text run at (262,104) width 8: "a"
     47        RenderMenuList {SELECT} at (272,97) size 52x36 [color=#808080] [bgcolor=#FFFFFF]
     48          RenderBlock (anonymous) at (4,2) size 24x32
    4949            RenderText at (0,5) size 21x22
    5050              text run at (0,5) width 21: "foo"
    51         RenderText {#text} at (365,104) size 9x22
    52           text run at (365,104) width 9: "b"
    53         RenderBR {BR} at (374,104) size 0x22
     51        RenderText {#text} at (326,104) size 9x22
     52          text run at (326,104) width 9: "b"
     53        RenderBR {BR} at (335,104) size 0x22
    5454        RenderBR {BR} at (1,132) size 0x22
    5555        RenderText {#text} at (1,155) size 470x22
    5656          text run at (1,155) width 470: "Padding should be respected, the arrow button shouldn't change size:"
    57         RenderMenuList {SELECT} at (473,153) size 70x27 [bgcolor=#FFFFFF]
    58           RenderBlock (anonymous) at (4,2) size 42x22
     57        RenderMenuList {SELECT} at (473,153) size 49x27 [bgcolor=#FFFFFF]
     58          RenderBlock (anonymous) at (4,2) size 21x22
    5959            RenderText at (0,0) size 21x22
    6060              text run at (0,0) width 21: "foo"
    61         RenderText {#text} at (545,155) size 8x22
    62           text run at (545,155) width 8: "a"
    63         RenderMenuList {SELECT} at (555,153) size 70x27 [color=#808080] [bgcolor=#FFFFFF]
    64           RenderBlock (anonymous) at (4,2) size 42x22
     61        RenderText {#text} at (524,155) size 8x22
     62          text run at (524,155) width 8: "a"
     63        RenderMenuList {SELECT} at (534,153) size 49x27 [color=#808080] [bgcolor=#FFFFFF]
     64          RenderBlock (anonymous) at (4,2) size 21x22
    6565            RenderText at (0,0) size 21x22
    6666              text run at (0,0) width 21: "foo"
    67         RenderText {#text} at (627,155) size 9x22
    68           text run at (627,155) width 9: "b"
    69         RenderBR {BR} at (636,155) size 0x22
     67        RenderText {#text} at (585,155) size 9x22
     68          text run at (585,155) width 9: "b"
     69        RenderBR {BR} at (594,155) size 0x22
    7070        RenderBR {BR} at (1,179) size 0x22
    7171        RenderText {#text} at (1,210) size 191x22
    7272          text run at (1,210) width 191: "Border should be respected:"
    73         RenderMenuList {SELECT} at (194,200) size 86x42 [bgcolor=#FFFFFF] [border: (8px solid #33CCFF)]
    74           RenderBlock (anonymous) at (12,10) size 42x22
     73        RenderMenuList {SELECT} at (194,200) size 65x42 [bgcolor=#FFFFFF] [border: (8px solid #33CCFF)]
     74          RenderBlock (anonymous) at (12,10) size 21x22
    7575            RenderText at (0,0) size 21x22
    7676              text run at (0,0) width 21: "foo"
    77         RenderText {#text} at (282,210) size 8x22
    78           text run at (282,210) width 8: "a"
    79         RenderMenuList {SELECT} at (292,200) size 86x42 [color=#808080] [bgcolor=#FFFFFF] [border: (8px solid #33CCFF)]
    80           RenderBlock (anonymous) at (12,10) size 42x22
     77        RenderText {#text} at (261,210) size 8x22
     78          text run at (261,210) width 8: "a"
     79        RenderMenuList {SELECT} at (271,200) size 65x42 [color=#808080] [bgcolor=#FFFFFF] [border: (8px solid #33CCFF)]
     80          RenderBlock (anonymous) at (12,10) size 21x22
    8181            RenderText at (0,0) size 21x22
    8282              text run at (0,0) width 21: "foo"
    83         RenderText {#text} at (380,210) size 9x22
    84           text run at (380,210) width 9: "b"
    85         RenderBR {BR} at (389,210) size 0x22
     83        RenderText {#text} at (338,210) size 9x22
     84          text run at (338,210) width 9: "b"
     85        RenderBR {BR} at (347,210) size 0x22
    8686        RenderBR {BR} at (1,241) size 0x22
    8787        RenderText {#text} at (1,268) size 127x22
    8888          text run at (1,268) width 127: "Border + padding:"
    89         RenderMenuList {SELECT} at (130,262) size 78x34 [bgcolor=#FFFFFF] [border: (4px solid #33CCFF)]
    90           RenderBlock (anonymous) at (8,6) size 42x22
     89        RenderMenuList {SELECT} at (130,262) size 57x34 [bgcolor=#FFFFFF] [border: (4px solid #33CCFF)]
     90          RenderBlock (anonymous) at (8,6) size 21x22
    9191            RenderText at (0,0) size 21x22
    9292              text run at (0,0) width 21: "foo"
    93         RenderText {#text} at (210,268) size 8x22
    94           text run at (210,268) width 8: "a"
    95         RenderMenuList {SELECT} at (220,262) size 78x34 [color=#808080] [bgcolor=#FFFFFF] [border: (4px solid #33CCFF)]
    96           RenderBlock (anonymous) at (8,6) size 42x22
     93        RenderText {#text} at (189,268) size 8x22
     94          text run at (189,268) width 8: "a"
     95        RenderMenuList {SELECT} at (199,262) size 57x34 [color=#808080] [bgcolor=#FFFFFF] [border: (4px solid #33CCFF)]
     96          RenderBlock (anonymous) at (8,6) size 21x22
    9797            RenderText at (0,0) size 21x22
    9898              text run at (0,0) width 21: "foo"
    99         RenderText {#text} at (300,268) size 9x22
    100           text run at (300,268) width 9: "b"
    101         RenderBR {BR} at (309,268) size 0x22
     99        RenderText {#text} at (258,268) size 9x22
     100          text run at (258,268) width 9: "b"
     101        RenderBR {BR} at (267,268) size 0x22
    102102        RenderBR {BR} at (1,295) size 0x22
    103103        RenderText {#text} at (1,316) size 517x22
    104104          text run at (1,316) width 517: "Height larger than font-size, button should grow, text baseline should center:"
    105         RenderMenuList {SELECT} at (520,314) size 70x27 [bgcolor=#FFFFFF]
    106           RenderBlock (anonymous) at (4,2) size 42x22
     105        RenderMenuList {SELECT} at (520,314) size 49x27 [bgcolor=#FFFFFF]
     106          RenderBlock (anonymous) at (4,2) size 21x22
    107107            RenderText at (0,0) size 21x22
    108108              text run at (0,0) width 21: "foo"
    109         RenderText {#text} at (592,316) size 8x22
    110           text run at (592,316) width 8: "a"
    111         RenderMenuList {SELECT} at (602,314) size 70x27 [color=#808080] [bgcolor=#FFFFFF]
    112           RenderBlock (anonymous) at (4,2) size 42x22
     109        RenderText {#text} at (571,316) size 8x22
     110          text run at (571,316) width 8: "a"
     111        RenderMenuList {SELECT} at (581,314) size 49x27 [color=#808080] [bgcolor=#FFFFFF]
     112          RenderBlock (anonymous) at (4,2) size 21x22
    113113            RenderText at (0,0) size 21x22
    114114              text run at (0,0) width 21: "foo"
    115         RenderText {#text} at (674,316) size 9x22
    116           text run at (674,316) width 9: "b"
    117         RenderBR {BR} at (683,316) size 0x22
     115        RenderText {#text} at (632,316) size 9x22
     116          text run at (632,316) width 9: "b"
     117        RenderBR {BR} at (641,316) size 0x22
    118118        RenderBR {BR} at (1,338) size 0x22
    119119        RenderText {#text} at (1,359) size 534x22
    120120          text run at (1,359) width 534: "Heigh smaller than font-size, whole select shrinks and is baselined with the text:"
    121         RenderMenuList {SELECT} at (537,357) size 70x27 [bgcolor=#FFFFFF]
    122           RenderBlock (anonymous) at (4,2) size 42x22
     121        RenderMenuList {SELECT} at (537,357) size 52x27 [bgcolor=#FFFFFF]
     122          RenderBlock (anonymous) at (4,2) size 24x22
    123123            RenderText at (0,0) size 21x22
    124124              text run at (0,0) width 21: "foo"
    125         RenderText {#text} at (609,359) size 8x22
    126           text run at (609,359) width 8: "a"
    127         RenderMenuList {SELECT} at (619,357) size 70x27 [bgcolor=#FFFFFF]
    128           RenderBlock (anonymous) at (4,2) size 42x22
     125        RenderText {#text} at (591,359) size 8x22
     126          text run at (591,359) width 8: "a"
     127        RenderMenuList {SELECT} at (601,357) size 52x27 [bgcolor=#FFFFFF]
     128          RenderBlock (anonymous) at (4,2) size 24x22
    129129            RenderText at (0,0) size 21x22
    130130              text run at (0,0) width 21: "foo"
    131         RenderText {#text} at (691,359) size 9x22
    132           text run at (691,359) width 9: "b"
    133         RenderBR {BR} at (700,359) size 0x22
     131        RenderText {#text} at (655,359) size 9x22
     132          text run at (655,359) width 9: "b"
     133        RenderBR {BR} at (664,359) size 0x22
    134134        RenderBR {BR} at (1,381) size 0x22
    135135        RenderText {#text} at (1,397) size 176x22

  • trunk/LayoutTests/platform/qt/fast/forms/menulist-deselect-update-expected.txt

    r84735 r88029  
    66      RenderText {#text} at (0,4) size 80x22
    77        text run at (0,4) width 80: "Test result: "
    8       RenderMenuList {SELECT} at (82,2) size 70x27 [bgcolor=#FFFFFF]
    9         RenderBlock (anonymous) at (4,2) size 42x22
     8      RenderMenuList {SELECT} at (82,2) size 68x27 [bgcolor=#FFFFFF]
     9        RenderBlock (anonymous) at (4,2) size 40x22
    1010          RenderText at (0,0) size 40x22
    1111            text run at (0,0) width 40: "PASS"

  • trunk/LayoutTests/platform/qt/fast/forms/menulist-separator-painting-expected.txt

    r84735 r88029  
    66      RenderBlock {DIV} at (0,0) size 784x6 [border: (3px solid #FFFFFF)]
    77      RenderBlock (anonymous) at (0,6) size 784x32
    8         RenderMenuList {SELECT} at (2,2) size 72x28 [bgcolor=#FFFFFF] [border: (1px solid #008000)]
    9           RenderBlock (anonymous) at (5,3) size 42x22
     8        RenderMenuList {SELECT} at (2,2) size 36x28 [bgcolor=#FFFFFF] [border: (1px solid #008000)]
     9          RenderBlock (anonymous) at (5,3) size 6x22
    1010            RenderBR at (0,0) size 0x22 [bgcolor=#FFFFFF]
    1111        RenderText {#text} at (0,0) size 0x0

  • trunk/LayoutTests/platform/qt/fast/forms/menulist-style-color-expected.txt

    r83871 r88029  
    1010      RenderText {#text} at (82,5) size 4x22
    1111        text run at (82,5) width 4: " "
    12       RenderMenuList {SELECT} at (88,3) size 70x27 [color=#FF0000] [bgcolor=#FFFFFF]
    13         RenderBlock (anonymous) at (4,2) size 42x22
     12      RenderMenuList {SELECT} at (88,3) size 56x27 [color=#FF0000] [bgcolor=#FFFFFF]
     13        RenderBlock (anonymous) at (4,2) size 28x22
    1414          RenderText at (0,0) size 28x22
    1515            text run at (0,0) width 28: "Red"
    16       RenderText {#text} at (160,5) size 4x22
    17         text run at (160,5) width 4: " "
    18       RenderMenuList {SELECT} at (166,2) size 143x28 [bgcolor=#008000] [border: (1px solid #000000)]
     16      RenderText {#text} at (146,5) size 4x22
     17        text run at (146,5) width 4: " "
     18      RenderMenuList {SELECT} at (152,2) size 143x28 [bgcolor=#008000] [border: (1px solid #000000)]
    1919        RenderBlock (anonymous) at (5,3) size 113x22
    2020          RenderText at (0,0) size 113x22
    2121            text run at (0,0) width 113: "Default on green"
    22       RenderText {#text} at (311,5) size 4x22
    23         text run at (311,5) width 4: " "
    24       RenderMenuList {SELECT} at (317,2) size 121x28 [color=#FF0000] [bgcolor=#008000] [border: (1px solid #FF0000)]
     22      RenderText {#text} at (297,5) size 4x22
     23        text run at (297,5) width 4: " "
     24      RenderMenuList {SELECT} at (303,2) size 121x28 [color=#FF0000] [bgcolor=#008000] [border: (1px solid #FF0000)]
    2525        RenderBlock (anonymous) at (5,3) size 91x22
    2626          RenderText at (0,0) size 91x22

  • trunk/LayoutTests/platform/qt/fast/forms/option-script-expected.txt

    r84735 r88029  
    1212        text run at (117,22) width 343: "If the popup menu says \"document.write('Text')\". "
    1313      RenderBR {BR} at (460,38) size 0x0
    14       RenderMenuList {SELECT} at (2,46) size 70x27 [bgcolor=#FFFFFF]
    15         RenderBlock (anonymous) at (4,2) size 42x22
     14      RenderMenuList {SELECT} at (2,46) size 59x27 [bgcolor=#FFFFFF]
     15        RenderBlock (anonymous) at (4,2) size 31x22
    1616          RenderText at (0,0) size 31x22
    1717            text run at (0,0) width 31: "Text"

  • trunk/LayoutTests/platform/qt/fast/forms/select-background-none-expected.txt

    r84963 r88029  
    44  RenderBlock {HTML} at (0,0) size 800x48
    55    RenderBody {BODY} at (8,8) size 784x32 [bgcolor=#666666]
    6       RenderMenuList {SELECT} at (2,2) size 72x28 [border: (1px solid #000000)]
    7         RenderBlock (anonymous) at (5,3) size 42x22
     6      RenderMenuList {SELECT} at (2,2) size 38x28 [border: (1px solid #000000)]
     7        RenderBlock (anonymous) at (5,3) size 8x22
    88          RenderText at (0,0) size 8x22
    99            text run at (0,0) width 8: "1"

  • trunk/LayoutTests/platform/qt/fast/forms/select-baseline-expected.txt

    r85025 r88029  
    77        text run at (0,0) width 498: "This tests that empty select controls and buttons have the correct baseline."
    88      RenderBR {BR} at (498,16) size 0x0
    9       RenderMenuList {SELECT} at (2,28) size 70x27 [bgcolor=#FFFFFF]
    10         RenderBlock (anonymous) at (4,2) size 42x22
     9      RenderMenuList {SELECT} at (2,28) size 34x27 [bgcolor=#FFFFFF]
     10        RenderBlock (anonymous) at (4,2) size 6x22
    1111          RenderBR at (0,0) size 0x22 [bgcolor=#FFFFFF]
    12       RenderText {#text} at (74,30) size 31x22
    13         text run at (74,30) width 31: " test "
    14       RenderMenuList {SELECT} at (107,28) size 70x27 [bgcolor=#FFFFFF]
    15         RenderBlock (anonymous) at (4,2) size 42x22
     12      RenderText {#text} at (38,30) size 31x22
     13        text run at (38,30) width 31: " test "
     14      RenderMenuList {SELECT} at (71,28) size 51x27 [bgcolor=#FFFFFF]
     15        RenderBlock (anonymous) at (4,2) size 23x22
    1616          RenderText at (0,0) size 23x22
    1717            text run at (0,0) width 23: "test"
    18       RenderText {#text} at (179,30) size 4x22
    19         text run at (179,30) width 4: " "
    20       RenderMenuList {SELECT} at (185,27) size 72x28 [color=#00008B] [bgcolor=#ADD8E6] [border: (1px solid #00008B)]
    21         RenderBlock (anonymous) at (5,3) size 42x22
     18      RenderText {#text} at (124,30) size 4x22
     19        text run at (124,30) width 4: " "
     20      RenderMenuList {SELECT} at (130,27) size 36x28 [color=#00008B] [bgcolor=#ADD8E6] [border: (1px solid #00008B)]
     21        RenderBlock (anonymous) at (5,3) size 6x22
    2222          RenderBR at (0,0) size 0x22 [bgcolor=#ADD8E6]
    23       RenderText {#text} at (259,30) size 31x22
    24         text run at (259,30) width 31: " test "
    25       RenderMenuList {SELECT} at (292,27) size 72x28 [color=#00008B] [bgcolor=#ADD8E6] [border: (1px solid #00008B)]
    26         RenderBlock (anonymous) at (5,3) size 42x22
     23      RenderText {#text} at (168,30) size 31x22
     24        text run at (168,30) width 31: " test "
     25      RenderMenuList {SELECT} at (201,27) size 53x28 [color=#00008B] [bgcolor=#ADD8E6] [border: (1px solid #00008B)]
     26        RenderBlock (anonymous) at (5,3) size 23x22
    2727          RenderText at (0,0) size 23x22
    2828            text run at (0,0) width 23: "test"
    29       RenderText {#text} at (366,30) size 4x22
    30         text run at (366,30) width 4: " "
    31       RenderButton {BUTTON} at (372,24) size 12x33 [bgcolor=#C0C0C0]
    32       RenderText {#text} at (386,30) size 4x22
    33         text run at (386,30) width 4: " "
    34       RenderButton {BUTTON} at (392,24) size 37x33 [bgcolor=#C0C0C0]
     29      RenderText {#text} at (256,30) size 4x22
     30        text run at (256,30) width 4: " "
     31      RenderButton {BUTTON} at (262,24) size 12x33 [bgcolor=#C0C0C0]
     32      RenderText {#text} at (276,30) size 4x22
     33        text run at (276,30) width 4: " "
     34      RenderButton {BUTTON} at (282,24) size 37x33 [bgcolor=#C0C0C0]
    3535        RenderBlock (anonymous) at (6,6) size 25x21
    3636          RenderText {#text} at (0,0) size 25x21
    3737            text run at (0,0) width 25: "test"
    38       RenderText {#text} at (431,30) size 4x22
    39         text run at (431,30) width 4: " "
    40       RenderButton {BUTTON} at (437,26) size 16x31 [color=#00008B] [bgcolor=#ADD8E6] [border: (2px outset #C0C0C0)]
    41       RenderText {#text} at (455,30) size 4x22
    42         text run at (455,30) width 4: " "
    43       RenderButton {BUTTON} at (461,26) size 39x31 [color=#00008B] [bgcolor=#ADD8E6] [border: (2px outset #C0C0C0)]
     38      RenderText {#text} at (321,30) size 4x22
     39        text run at (321,30) width 4: " "
     40      RenderButton {BUTTON} at (327,26) size 16x31 [color=#00008B] [bgcolor=#ADD8E6] [border: (2px outset #C0C0C0)]
     41      RenderText {#text} at (345,30) size 4x22
     42        text run at (345,30) width 4: " "
     43      RenderButton {BUTTON} at (351,26) size 39x31 [color=#00008B] [bgcolor=#ADD8E6] [border: (2px outset #C0C0C0)]
    4444        RenderBlock (anonymous) at (8,4) size 23x22
    4545          RenderText {#text} at (0,0) size 23x22

  • trunk/LayoutTests/platform/qt/fast/forms/select-dirty-parent-pref-widths-expected.txt

    r84735 r88029  
    44  RenderBlock {HTML} at (0,0) size 800x103
    55    RenderBody {BODY} at (8,8) size 784x79
    6       RenderTable {TABLE} at (0,0) size 84x41 [border: (1px outset #808080)]
    7         RenderTableSection {TBODY} at (1,1) size 82x39
    8           RenderTableRow {TR} at (0,2) size 82x35
    9             RenderTableCell {TD} at (2,2) size 78x35 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
    10               RenderMenuList {SELECT} at (4,4) size 70x27 [bgcolor=#FFFFFF]
    11                 RenderBlock (anonymous) at (4,2) size 42x22
     6      RenderTable {TABLE} at (0,0) size 65x41 [border: (1px outset #808080)]
     7        RenderTableSection {TBODY} at (1,1) size 63x39
     8          RenderTableRow {TR} at (0,2) size 63x35
     9            RenderTableCell {TD} at (2,2) size 59x35 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
     10              RenderMenuList {SELECT} at (4,4) size 51x27 [bgcolor=#FFFFFF]
     11                RenderBlock (anonymous) at (4,2) size 23x22
    1212                  RenderText at (0,0) size 23x22
    1313                    text run at (0,0) width 23: "test"

  • trunk/LayoutTests/platform/qt/fast/forms/select-empty-option-height-expected.txt

    r84735 r88029  
    44  RenderBlock {HTML} at (0,0) size 800x600
    55    RenderBody {BODY} at (8,8) size 784x584
    6       RenderMenuList {SELECT} at (2,2) size 44x24 [bgcolor=#FFFFFF] [border: (1px solid #000000)]
    7         RenderBlock (anonymous) at (1,1) size 42x22
     6      RenderMenuList {SELECT} at (2,2) size 32x24 [bgcolor=#FFFFFF] [border: (1px solid #000000)]
     7        RenderBlock (anonymous) at (1,1) size 30x22
    88          RenderBR at (0,0) size 0x22 [bgcolor=#FFFFFF]
    99      RenderText {#text} at (0,0) size 0x0

  • trunk/LayoutTests/platform/qt/fast/forms/select-size-expected.txt

    r84735 r88029  
    88        text run at (0,22) width 508: "match the style rule that determines whether to use a menu list or a list box."
    99      RenderBR {BR} at (508,38) size 0x0
    10       RenderMenuList {SELECT} at (2,46) size 70x27 [bgcolor=#FFFFFF]
    11         RenderBlock (anonymous) at (4,2) size 42x22
     10      RenderMenuList {SELECT} at (2,46) size 51x27 [bgcolor=#FFFFFF]
     11        RenderBlock (anonymous) at (4,2) size 23x22
    1212          RenderText at (0,0) size 23x22
    1313            text run at (0,0) width 23: "test"

  • trunk/LayoutTests/platform/qt/fast/forms/select-style-expected.txt

    r84735 r88029  
    88        text run at (269,0) width 322: "(Aqua for now- later, we will honor the styling)."
    99      RenderBR {BR} at (591,16) size 0x0
    10       RenderMenuList {SELECT} at (2,24) size 72x28 [bgcolor=#FF0000] [border: (1px solid #000000)]
    11         RenderBlock (anonymous) at (5,3) size 42x22
     10      RenderMenuList {SELECT} at (2,24) size 53x28 [bgcolor=#FF0000] [border: (1px solid #000000)]
     11        RenderBlock (anonymous) at (5,3) size 23x22
    1212          RenderText at (0,0) size 23x22
    1313            text run at (0,0) width 23: "test"
    14       RenderText {#text} at (76,27) size 4x22
    15         text run at (76,27) width 4: " "
    16       RenderBR {BR} at (80,43) size 0x0
     14      RenderText {#text} at (57,27) size 4x22
     15        text run at (57,27) width 4: " "
     16      RenderBR {BR} at (61,43) size 0x0
    1717      RenderText {#text} at (0,54) size 570x22
    1818        text run at (0,54) width 570: "This tests that background color is white by default regardless of the parent element."
    1919      RenderBR {BR} at (570,70) size 0x0
    20       RenderInline {SPAN} at (0,0) size 88x32 [bgcolor=#FF0000]
     20      RenderInline {SPAN} at (0,0) size 69x32 [bgcolor=#FF0000]
    2121        RenderText {#text} at (0,0) size 0x0
    22         RenderMenuList {SELECT} at (7,78) size 70x27 [bgcolor=#FFFFFF]
    23           RenderBlock (anonymous) at (4,2) size 42x22
     22        RenderMenuList {SELECT} at (7,78) size 51x27 [bgcolor=#FFFFFF]
     23          RenderBlock (anonymous) at (4,2) size 23x22
    2424            RenderText at (0,0) size 23x22
    2525              text run at (0,0) width 23: "test"
    26         RenderText {#text} at (79,80) size 4x22
    27           text run at (79,80) width 4: " "
     26        RenderText {#text} at (60,80) size 4x22
     27          text run at (60,80) width 4: " "
    2828      RenderText {#text} at (0,0) size 0x0
    2929      RenderBR {BR} at (0,0) size 0x0
    … …  
    3131        text run at (0,107) width 678: "This tests that background color is inherited from the parent if background-color:inherit is specified."
    3232      RenderBR {BR} at (678,123) size 0x0
    33       RenderInline {SPAN} at (0,0) size 90x32 [bgcolor=#FF0000]
     33      RenderInline {SPAN} at (0,0) size 71x32 [bgcolor=#FF0000]
    3434        RenderText {#text} at (0,0) size 0x0
    35         RenderMenuList {SELECT} at (7,131) size 72x28 [border: (1px solid #000000)]
    36           RenderBlock (anonymous) at (5,3) size 42x22
     35        RenderMenuList {SELECT} at (7,131) size 53x28 [border: (1px solid #000000)]
     36          RenderBlock (anonymous) at (5,3) size 23x22
    3737            RenderText at (0,0) size 23x22
    3838              text run at (0,0) width 23: "test"
    39         RenderText {#text} at (81,134) size 4x22
    40           text run at (81,134) width 4: " "
     39        RenderText {#text} at (62,134) size 4x22
     40          text run at (62,134) width 4: " "
    4141      RenderText {#text} at (0,0) size 0x0
    4242      RenderBR {BR} at (0,0) size 0x0
    … …  
    4444        text run at (0,161) width 692: "This tests that background color is the same as the parent if background-color:transparent is specified."
    4545      RenderBR {BR} at (692,177) size 0x0
    46       RenderInline {SPAN} at (0,0) size 90x32 [bgcolor=#FF0000]
     46      RenderInline {SPAN} at (0,0) size 71x32 [bgcolor=#FF0000]
    4747        RenderText {#text} at (0,0) size 0x0
    48         RenderMenuList {SELECT} at (7,185) size 72x28 [border: (1px solid #000000)]
    49           RenderBlock (anonymous) at (5,3) size 42x22
     48        RenderMenuList {SELECT} at (7,185) size 53x28 [border: (1px solid #000000)]
     49          RenderBlock (anonymous) at (5,3) size 23x22
    5050            RenderText at (0,0) size 23x22
    5151              text run at (0,0) width 23: "test"
    52         RenderText {#text} at (81,188) size 4x22
    53           text run at (81,188) width 4: " "
     52        RenderText {#text} at (62,188) size 4x22
     53          text run at (62,188) width 4: " "
    5454      RenderText {#text} at (0,0) size 0x0
    5555      RenderBR {BR} at (0,0) size 0x0
    … …  
    5757        text run at (0,215) width 532: "This tests that background is white if only background-image:none is specified."
    5858      RenderBR {BR} at (532,231) size 0x0
    59       RenderMenuList {SELECT} at (2,239) size 70x27 [bgcolor=#FFFFFF]
    60         RenderBlock (anonymous) at (4,2) size 42x22
     59      RenderMenuList {SELECT} at (2,239) size 51x27 [bgcolor=#FFFFFF]
     60        RenderBlock (anonymous) at (4,2) size 23x22
    6161          RenderText at (0,0) size 23x22
    6262            text run at (0,0) width 23: "test"
    63       RenderText {#text} at (74,241) size 4x22
    64         text run at (74,241) width 4: " "
    65       RenderBR {BR} at (78,257) size 0x0
     63      RenderText {#text} at (55,241) size 4x22
     64        text run at (55,241) width 4: " "
     65      RenderBR {BR} at (59,257) size 0x0
    6666      RenderText {#text} at (0,268) size 445x22
    6767        text run at (0,268) width 445: "This tests that the image specified for background-image is visible."
    6868      RenderBR {BR} at (445,284) size 0x0
    69       RenderMenuList {SELECT} at (2,292) size 72x28 [bgcolor=#FFFFFF] [border: (1px solid #000000)]
    70         RenderBlock (anonymous) at (5,3) size 42x22
     69      RenderMenuList {SELECT} at (2,292) size 53x28 [bgcolor=#FFFFFF] [border: (1px solid #000000)]
     70        RenderBlock (anonymous) at (5,3) size 23x22
    7171          RenderText at (0,0) size 23x22
    7272            text run at (0,0) width 23: "test"

  • trunk/LayoutTests/platform/qt/fast/invalid/014-expected.txt

    r84735 r88029  
    1010        RenderText {#text} at (0,0) size 0x0
    1111      RenderBlock {FORM} at (0,22) size 784x31
    12         RenderMenuList {SELECT} at (2,2) size 70x27 [bgcolor=#FFFFFF]
    13           RenderBlock (anonymous) at (4,2) size 42x22
     12        RenderMenuList {SELECT} at (2,2) size 40x27 [bgcolor=#FFFFFF]
     13          RenderBlock (anonymous) at (4,2) size 12x22
    1414            RenderText at (0,0) size 12x22
    1515              text run at (0,0) width 12: "A"
    1616        RenderText {#text} at (0,0) size 0x0
    1717      RenderBlock {P} at (0,69) size 784x0
    18 layer at (470,49) size 78x69
    19   RenderBlock (positioned) {H2} at (470,49) size 78x69 [border: (2px solid #008000)]
    20     RenderBlock {FORM} at (2,2) size 74x41
    21       RenderMenuList {SELECT} at (2,2) size 70x37 [bgcolor=#FFFFFF]
    22         RenderBlock (anonymous) at (4,2) size 42x33
     18layer at (470,49) size 53x69
     19  RenderBlock (positioned) {H2} at (470,49) size 53x69 [border: (2px solid #008000)]
     20    RenderBlock {FORM} at (2,2) size 49x41
     21      RenderMenuList {SELECT} at (2,2) size 45x37 [bgcolor=#FFFFFF]
     22        RenderBlock (anonymous) at (4,2) size 17x33
    2323          RenderText at (0,0) size 17x33
    2424            text run at (0,0) width 17: "A"

  • trunk/LayoutTests/platform/qt/fast/replaced/replaced-breaking-expected.txt

    r85025 r88029  
    2929              text run at (0,0) width 44: "button"
    3030        RenderText {#text} at (0,0) size 0x0
    31         RenderMenuList {SELECT} at (3,265) size 70x27 [bgcolor=#FFFFFF]
    32           RenderBlock (anonymous) at (4,2) size 42x22
     31        RenderMenuList {SELECT} at (3,265) size 64x27 [bgcolor=#FFFFFF]
     32          RenderBlock (anonymous) at (4,2) size 36x22
    3333            RenderText at (0,0) size 36x22
    3434              text run at (0,0) width 36: "select"
    35         RenderMenuList {SELECT} at (3,296) size 70x27 [bgcolor=#FFFFFF]
    36           RenderBlock (anonymous) at (4,2) size 42x22
     35        RenderMenuList {SELECT} at (3,296) size 64x27 [bgcolor=#FFFFFF]
     36          RenderBlock (anonymous) at (4,2) size 36x22
    3737            RenderText at (0,0) size 36x22
    3838              text run at (0,0) width 36: "select"

  • trunk/LayoutTests/platform/qt/fast/replaced/replaced-breaking-mixture-expected.txt

    r83871 r88029  
    1111        RenderText {#text} at (0,0) size 26x22
    1212          text run at (0,0) width 26: "Foo"
    13         RenderMenuList {SELECT} at (2,24) size 70x27 [bgcolor=#FFFFFF]
    14           RenderBlock (anonymous) at (4,2) size 42x22
     13        RenderMenuList {SELECT} at (2,24) size 56x27 [bgcolor=#FFFFFF]
     14          RenderBlock (anonymous) at (4,2) size 28x22
    1515            RenderText at (0,0) size 28x22
    1616              text run at (0,0) width 28: "One"
    … …  
    2424          text run at (0,25) width 26: "Foo"
    2525      RenderBlock {DIV} at (0,199) size 10x53
    26         RenderMenuList {SELECT} at (2,2) size 70x27 [bgcolor=#FFFFFF]
    27           RenderBlock (anonymous) at (4,2) size 42x22
     26        RenderMenuList {SELECT} at (2,2) size 56x27 [bgcolor=#FFFFFF]
     27          RenderBlock (anonymous) at (4,2) size 28x22
    2828            RenderText at (0,0) size 28x22
    2929              text run at (0,0) width 28: "One"

  • trunk/LayoutTests/platform/qt/fast/replaced/three-selects-break-expected.txt

    r83871 r88029  
    55    RenderBody {BODY} at (8,8) size 784x584
    66      RenderBlock {DIV} at (0,0) size 5x93
    7         RenderMenuList {SELECT} at (2,2) size 70x27 [bgcolor=#FFFFFF]
    8           RenderBlock (anonymous) at (4,2) size 42x22
     7        RenderMenuList {SELECT} at (2,2) size 34x27 [bgcolor=#FFFFFF]
     8          RenderBlock (anonymous) at (4,2) size 6x22
    99            RenderBR at (0,0) size 0x22 [bgcolor=#FFFFFF]
    10         RenderMenuList {SELECT} at (2,33) size 70x27 [bgcolor=#FFFFFF]
    11           RenderBlock (anonymous) at (4,2) size 42x22
     10        RenderMenuList {SELECT} at (2,33) size 34x27 [bgcolor=#FFFFFF]
     11          RenderBlock (anonymous) at (4,2) size 6x22
    1212            RenderBR at (0,0) size 0x22 [bgcolor=#FFFFFF]
    13         RenderMenuList {SELECT} at (2,64) size 70x27 [bgcolor=#FFFFFF]
    14           RenderBlock (anonymous) at (4,2) size 42x22
     13        RenderMenuList {SELECT} at (2,64) size 34x27 [bgcolor=#FFFFFF]
     14          RenderBlock (anonymous) at (4,2) size 6x22
    1515            RenderBR at (0,0) size 0x22 [bgcolor=#FFFFFF]

  • trunk/LayoutTests/platform/qt/tables/mozilla/bugs/bug29326-expected.txt

    r83871 r88029  
    99            RenderTableCell {TD} at (2,2) size 394x51 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
    1010              RenderBlock {FORM} at (2,2) size 390x31
    11                 RenderMenuList {SELECT} at (2,2) size 70x27 [bgcolor=#FFFFFF]
    12                   RenderBlock (anonymous) at (4,2) size 42x22
     11                RenderMenuList {SELECT} at (2,2) size 57x27 [bgcolor=#FFFFFF]
     12                  RenderBlock (anonymous) at (4,2) size 29x22
    1313                    RenderText at (0,0) size 29x22
    1414                      text run at (0,0) width 29: "Test"

  • trunk/LayoutTests/platform/qt/tables/mozilla/core/margins-expected.txt

    r83871 r88029  
    1212            RenderTableCell {TD} at (2,2) size 394x51 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
    1313              RenderBlock {FORM} at (2,2) size 390x31
    14                 RenderMenuList {SELECT} at (2,2) size 70x27 [bgcolor=#FFFFFF]
    15                   RenderBlock (anonymous) at (4,2) size 42x22
     14                RenderMenuList {SELECT} at (2,2) size 57x27 [bgcolor=#FFFFFF]
     15                  RenderBlock (anonymous) at (4,2) size 29x22
    1616                    RenderText at (0,0) size 29x22
    1717                      text run at (0,0) width 29: "Test"

  • trunk/Source/WebCore/ChangeLog

    r88026 r88029  
     12011-06-03  Doreen Jiang  <doreen.jiang@nokia.com>
     2
     3        Reviewed by Benjamin Poulain.
     4
     5        [Qt]The minimum size of the select menu list is incorrect for qtwebkit
     6        https://bugs.webkit.org/show_bug.cgi?id=56752
     7
     8        The minimum width of the select-box is calculated to be as small as possible
     9        instead of hardcoded value (width of 7 characters) in minimumMenuListSize() function
     10        This will avoid overapping the select lists in popular websites.
     11
     12        Test: fast/forms/selectlist-minsize.html
     13
     14        * platform/qt/RenderThemeQt.cpp:
     15        (WebCore::RenderThemeQt::minimumMenuListSize):
     16
    1172011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
    218

  • trunk/Source/WebCore/platform/qt/RenderThemeQt.cpp

    r86299 r88029  
    448448{
    449449    const QFontMetrics &fm = QApplication::fontMetrics();
    450     return 7 * fm.width(QLatin1Char('x'));
     450    return fm.width(QLatin1Char('x'));
    451451}
    452452
Note: See TracChangeset for help on using the changeset viewer.