Changeset 88066 in webkit
- Timestamp:
- Jun 3, 2011 2:55:11 PM (13 years ago)
- Location:
- trunk
- Files:
-
- 22 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r88064 r88066 1 2011-05-31 Martin Robinson <mrobinson@igalia.com> 2 3 Reviewed by Ryosuke Niwa. 4 5 [GTK] Support smart replace for the pasteboard 6 https://bugs.webkit.org/show_bug.cgi?id=61734 7 8 Unskip tests which are now passing and update results for other tests 9 which vary depending on smart replace support. 10 11 * platform/gtk/Skipped: Unskip tests which are now passing. 12 * platform/gtk/editing/deleting/smart-delete-003-expected.txt: 13 * platform/gtk/editing/deleting/smart-delete-004-expected.txt: 14 * platform/gtk/editing/pasteboard/4944770-2-expected.txt: 15 * platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt: 16 * platform/gtk/editing/pasteboard/smart-paste-007-expected.txt: 17 * platform/gtk/editing/pasteboard/smart-paste-008-expected.txt: 18 * platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt: 19 * platform/gtk/fast/lists/drag-into-marker-expected.txt: 20 1 21 2011-06-03 Martin Robinson <mrobinson@igalia.com> 2 22 -
trunk/LayoutTests/platform/gtk/Skipped
r88062 r88066 403 403 # https://bugs.webkit.org/show_bug.cgi?id=61661 404 404 editing/pasteboard/smart-drag-drop.html 405 editing/pasteboard/smart-paste-001.html406 editing/pasteboard/smart-paste-002.html407 editing/pasteboard/smart-paste-003.html408 editing/pasteboard/smart-paste-004.html409 editing/pasteboard/smart-paste-005.html410 405 editing/pasteboard/drag-drop-list.html 411 406 -
trunk/LayoutTests/platform/gtk/editing/deleting/smart-delete-003-expected.txt
r80127 r88066 7 7 EDITING DELEGATE: shouldDeleteDOMRange:range from 4 of #text > DIV > BODY > HTML > #document to 1 of #text > DIV > BODY > HTML > #document 8 8 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 9 EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 3 of #text > DIV > BODY > HTML > #document to 3 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 9 10 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 10 11 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification … … 21 22 text run at (0,19) width 127: "should see 'foo baz'." 22 23 RenderBlock {DIV} at (0,54) size 784x19 23 RenderText {#text} at (0,0) size 2 5x1924 text run at (0,0) width 2 5: "foo"25 RenderText {#text} at (2 5,0) size 26x1926 text run at (2 5,0) width 26: " baz"27 caret: position 4of child 0 {#text} of child 2 {DIV} of body24 RenderText {#text} at (0,0) size 21x19 25 text run at (0,0) width 21: "foo" 26 RenderText {#text} at (21,0) size 26x19 27 text run at (21,0) width 26: " baz" 28 caret: position 3 of child 0 {#text} of child 2 {DIV} of body -
trunk/LayoutTests/platform/gtk/editing/deleting/smart-delete-004-expected.txt
r80127 r88066 7 7 EDITING DELEGATE: shouldDeleteDOMRange:range from 4 of #text > DIV > BODY > HTML > #document to 1 of #text > DIV > BODY > HTML > #document 8 8 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 9 EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 3 of #text > DIV > BODY > HTML > #document to 3 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 9 10 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 10 11 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification … … 21 22 text run at (45,19) width 159: "You should see 'foo baz'." 22 23 RenderBlock {DIV} at (0,54) size 784x19 23 RenderText {#text} at (0,0) size 2 5x1924 text run at (0,0) width 2 5: "foo"25 RenderText {#text} at (2 5,0) size 26x1926 text run at (2 5,0) width 26: " baz"27 caret: position 4of child 0 {#text} of child 2 {DIV} of body24 RenderText {#text} at (0,0) size 21x19 25 text run at (0,0) width 21: "foo" 26 RenderText {#text} at (21,0) size 26x19 27 text run at (21,0) width 26: " baz" 28 caret: position 3 of child 0 {#text} of child 2 {DIV} of body -
trunk/LayoutTests/platform/gtk/editing/pasteboard/4944770-2-expected.txt
r82033 r88066 17 17 RenderText {#text} at (0,6) size 8x19 18 18 text run at (0,6) width 8: "x" 19 RenderMenuList {SELECT} at (10,2) size 37x27 [bgcolor=#FFFFFF] [border: (1px solid #000000)] 19 RenderText {#text} at (8,6) size 4x19 20 text run at (8,6) width 4: " " 21 RenderMenuList {SELECT} at (14,2) size 37x27 [bgcolor=#FFFFFF] [border: (1px solid #000000)] 20 22 RenderBlock (anonymous) at (1,1) size 35x25 21 23 RenderText at (3,3) size 9x19 22 24 text run at (3,3) width 9: "1" 23 RenderText {#text} at (49,6) size 8x19 24 text run at (49,6) width 8: "x" 25 caret: position 3 of child 1 {SELECT} of child 4 {DIV} of body 25 RenderText {#text} at (53,6) size 4x19 26 text run at (53,6) width 4: " " 27 RenderText {#text} at (57,6) size 8x19 28 text run at (57,6) width 8: "x" 29 caret: position 1 of child 3 {#text} of child 4 {DIV} of body -
trunk/LayoutTests/platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt
r72675 r88066 18 18 text run at (0,19) width 86: "\"worldhello\"." 19 19 RenderBlock {DIV} at (0,54) size 784x19 20 RenderText {#text} at (0,0) size 41x1921 text run at (0,0) width 41: "world"22 RenderText {#text} at ( 41,0) size 31x1923 text run at ( 41,0) width 31: "hello"20 RenderText {#text} at (0,0) size 37x19 21 text run at (0,0) width 37: "world" 22 RenderText {#text} at (37,0) size 31x19 23 text run at (37,0) width 31: "hello" 24 24 selection start: position 0 of child 1 {#text} of child 3 {DIV} of body 25 25 selection end: position 5 of child 1 {#text} of child 3 {DIV} of body -
trunk/LayoutTests/platform/gtk/editing/pasteboard/smart-paste-007-expected.txt
r81109 r88066 21 21 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 22 22 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 23 EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 4 of #text > DIV > DIV > BODY > HTML > #document to 4of #text > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE23 EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 5 of #text > DIV > DIV > BODY > HTML > #document to 5 of #text > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 24 24 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 25 25 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification … … 50 50 RenderText {#text} at (2,2) size 6x28 51 51 text run at (2,2) width 6: "." 52 RenderText {#text} at (8,2) size 34x2853 text run at (8,2) width 34: "test"54 RenderText {#text} at (4 2,2) size 6x2855 text run at (4 2,2) width 6: "."52 RenderText {#text} at (8,2) size 40x28 53 text run at (8,2) width 40: " test" 54 RenderText {#text} at (48,2) size 6x28 55 text run at (48,2) width 6: "." 56 56 RenderBlock (anonymous) at (0,32) size 784x0 57 caret: position 4of child 1 {#text} of child 1 {DIV} of child 3 {DIV} of body57 caret: position 5 of child 1 {#text} of child 1 {DIV} of child 3 {DIV} of body -
trunk/LayoutTests/platform/gtk/editing/pasteboard/smart-paste-008-expected.txt
r81109 r88066 10 10 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 11 11 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 12 EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 3 of #text > DIV > DIV > BODY > HTML > #document to 3of #text > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE12 EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 4 of #text > DIV > DIV > BODY > HTML > #document to 4 of #text > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 13 13 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 14 14 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification … … 32 32 RenderText {#text} at (0,0) size 5x19 33 33 text run at (0,0) width 5: "f" 34 RenderText {#text} at (5,0) size 2 1x1935 text run at (5,0) width 2 1: "foo"36 RenderText {#text} at ( 26,0) size 24x1937 text run at ( 26,0) width 24: " bar"34 RenderText {#text} at (5,0) size 25x19 35 text run at (5,0) width 25: " foo" 36 RenderText {#text} at (30,0) size 24x19 37 text run at (30,0) width 24: " bar" 38 38 RenderBlock (anonymous) at (0,19) size 784x0 39 caret: position 3of child 1 {#text} of child 0 {DIV} of child 4 {DIV} of body39 caret: position 4 of child 1 {#text} of child 0 {DIV} of child 4 {DIV} of body -
trunk/LayoutTests/platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt
r80127 r88066 11 11 EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 11 of #text > BODY > HTML > #document to 11 of #text > BODY > HTML > #document givenAction:WebViewInsertActionDropped 12 12 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 13 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 14 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 4 of #text > BODY > HTML > #document to 5 of #text > BODY > HTML > #document toDOMRange:range from 0 of #text > BODY > HTML > #document to 3 of #text > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 13 EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of #text > BODY > HTML > #document to 3 of #text > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE 15 14 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification 16 15 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification … … 27 26 RenderBlock {HTML} at (0,0) size 300x300 28 27 RenderBody {BODY} at (8,8) size 284x284 [bgcolor=#FFFFE0] 29 RenderText {#text} at (0,0) size 51x1930 text run at (0,0) width 51: "foobaz"31 RenderText {#text} at ( 51,0) size 20x1932 text run at ( 51,0) width 20: "bar"28 RenderText {#text} at (0,0) size 47x19 29 text run at (0,0) width 47: "foo baz" 30 RenderText {#text} at (47,0) size 20x19 31 text run at (47,0) width 20: "bar" 33 32 RenderText {#text} at (0,0) size 0x0 34 33 RenderBlock {P} at (0,320) size 800x38 -
trunk/LayoutTests/platform/gtk/fast/lists/drag-into-marker-expected.txt
r71405 r88066 9 9 RenderText {#text} at (0,0) size 112x54 10 10 text run at (0,0) width 112: "world" 11 RenderText {#text} at (112,0) size 107x5411 RenderText {#text} at (112,0) size 95x54 12 12 text run at (112,0) width 95: "hello" 13 text run at (207,0) width 12: " "14 13 RenderBlock {P} at (0,73) size 784x76 15 14 RenderText {#text} at (0,0) size 768x76 -
trunk/Source/WebCore/ChangeLog
r88063 r88066 1 2011-05-31 Martin Robinson <mrobinson@igalia.com> 2 3 Reviewed by Ryosuke Niwa. 4 5 [GTK] Support smart replace for the pasteboard 6 https://bugs.webkit.org/show_bug.cgi?id=61734 7 8 Add smart replace support to WebCore and add hooks for it in WebKit 9 via DumpRenderTreeSupportGtk. When a platform supports smart replace, 10 WebCore will remove extra spaces that appear when pasting text. Eventually 11 WebKitGTK+ may want to expose this in the public API. 12 13 * platform/gtk/PasteboardGtk.cpp: 14 (WebCore::Pasteboard::writeSelection): Now pass whether or not to use smart replace 15 when calling writeSelection. 16 (WebCore::Pasteboard::canSmartReplace): Added an implementation that checks the clipboard 17 for whether or not it supports smart paste. 18 * platform/gtk/PasteboardHelper.cpp: 19 (WebCore::initGdkAtoms): Added initialization for smart replace atom. 20 (WebCore::PasteboardHelper::fillSelectionData): Added no-op handler for smart replace atom. 21 (WebCore::PasteboardHelper::targetListForDataObject): Properly handle new smart replace parameter. 22 (WebCore::PasteboardHelper::writeClipboardContents): Properly handle new smart replace parameter. 23 (WebCore::PasteboardHelper::clipboardContentSupportsSmartReplace): Added helper for Pasteboard. 24 * platform/gtk/PasteboardHelper.h: Add new method definition. 25 1 26 2011-06-03 Levi Weintraub <leviw@chromium.org> 2 27 -
trunk/Source/WebCore/platform/gtk/PasteboardGtk.cpp
r87978 r88066 62 62 dataObject->setText(frame->editor()->selectedText()); 63 63 dataObject->setMarkup(createMarkup(selectedRange, 0, AnnotateForInterchange, false, AbsoluteURLs)); 64 helper->writeClipboardContents(clipboard );64 helper->writeClipboardContents(clipboard, canSmartCopyOrDelete ? PasteboardHelper::IncludeSmartPaste : PasteboardHelper::DoNotIncludeSmartPaste); 65 65 } 66 66 … … 143 143 bool Pasteboard::canSmartReplace() 144 144 { 145 notImplemented();146 return false;145 return PasteboardHelper::defaultPasteboardHelper()->clipboardContentSupportsSmartReplace( 146 gtk_clipboard_get_for_display(gdk_display_get_default(), GDK_SELECTION_CLIPBOARD)); 147 147 } 148 148 -
trunk/Source/WebCore/platform/gtk/PasteboardHelper.cpp
r87978 r88066 39 39 static GdkAtom netscapeURLAtom; 40 40 static GdkAtom uriListAtom; 41 static GdkAtom smartPasteAtom; 41 42 static String gMarkupPrefix; 42 43 … … 62 63 netscapeURLAtom = gdk_atom_intern("_NETSCAPE_URL", FALSE); 63 64 uriListAtom = gdk_atom_intern("text/uri-list", FALSE); 65 smartPasteAtom = gdk_atom_intern("application/vnd.webkitgtk.smartpaste", FALSE); 64 66 gMarkupPrefix = "<meta http-equiv=\"content-type\" content=\"text/html; charset=utf-8\">"; 65 67 } … … 191 193 } else if (info == TargetTypeImage) 192 194 gtk_selection_data_set_pixbuf(selectionData, dataObject->image()); 193 } 194 195 GtkTargetList* PasteboardHelper::targetListForDataObject(DataObjectGtk* dataObject) 195 196 else if (info == TargetTypeSmartPaste) 197 gtk_selection_data_set_text(selectionData, "", -1); 198 } 199 200 GtkTargetList* PasteboardHelper::targetListForDataObject(DataObjectGtk* dataObject, SmartPasteInclusion shouldInludeSmartPaste) 196 201 { 197 202 GtkTargetList* list = gtk_target_list_new(0, 0); … … 210 215 if (dataObject->hasImage()) 211 216 gtk_target_list_add_image_targets(list, TargetTypeImage, TRUE); 217 218 if (shouldInludeSmartPaste == IncludeSmartPaste) 219 gtk_target_list_add(list, smartPasteAtom, 0, TargetTypeSmartPaste); 212 220 213 221 return list; … … 290 298 } 291 299 292 void PasteboardHelper::writeClipboardContents(GtkClipboard* clipboard, GClosure* callback)300 void PasteboardHelper::writeClipboardContents(GtkClipboard* clipboard, SmartPasteInclusion includeSmartPaste, GClosure* callback) 293 301 { 294 302 DataObjectGtk* dataObject = DataObjectGtk::forClipboard(clipboard); 295 GtkTargetList* list = targetListForDataObject(dataObject );303 GtkTargetList* list = targetListForDataObject(dataObject, includeSmartPaste); 296 304 297 305 int numberOfTargets; … … 315 323 } 316 324 317 } 318 325 bool PasteboardHelper::clipboardContentSupportsSmartReplace(GtkClipboard* clipboard) 326 { 327 return gtk_clipboard_wait_is_target_available(clipboard, smartPasteAtom); 328 } 329 330 } 331 -
trunk/Source/WebCore/platform/gtk/PasteboardHelper.h
r87978 r88066 41 41 bool usePrimarySelectionClipboard() { return m_usePrimarySelectionClipboard; } 42 42 43 enum SmartPasteInclusion { IncludeSmartPaste, DoNotIncludeSmartPaste }; 44 43 45 GtkClipboard* getCurrentClipboard(Frame*); 44 46 GtkClipboard* getClipboard(Frame*) const; 45 47 GtkClipboard* getPrimarySelectionClipboard(Frame*) const; 46 48 GtkTargetList* targetList() const; 47 GtkTargetList* targetListForDataObject(DataObjectGtk* );49 GtkTargetList* targetListForDataObject(DataObjectGtk*, SmartPasteInclusion = DoNotIncludeSmartPaste); 48 50 void fillSelectionData(GtkSelectionData*, guint, DataObjectGtk*); 49 51 void fillDataObjectFromDropData(GtkSelectionData*, guint, DataObjectGtk*); 50 52 Vector<GdkAtom> dropAtomsForContext(GtkWidget*, GdkDragContext*); 51 void writeClipboardContents(GtkClipboard*, GClosure* closure= 0);53 void writeClipboardContents(GtkClipboard*, SmartPasteInclusion = DoNotIncludeSmartPaste, GClosure* = 0); 52 54 void getClipboardContents(GtkClipboard*); 53 55 54 enum PasteboardTargetType { TargetTypeMarkup, TargetTypeText, TargetTypeImage, TargetTypeURIList, TargetTypeNetscapeURL, TargetTypeUnknown }; 56 enum PasteboardTargetType { TargetTypeMarkup, TargetTypeText, TargetTypeImage, TargetTypeURIList, TargetTypeNetscapeURL, TargetTypeSmartPaste, TargetTypeUnknown }; 57 bool clipboardContentSupportsSmartReplace(GtkClipboard*); 55 58 56 59 private: -
trunk/Source/WebKit/gtk/ChangeLog
r87999 r88066 1 2011-05-31 Martin Robinson <mrobinson@igalia.com> 2 3 Reviewed by Ryosuke Niwa. 4 5 [GTK] Support smart replace for the pasteboard 6 https://bugs.webkit.org/show_bug.cgi?id=61734 7 8 Add the EditorClient and DumpRenderTreeSupportGtk hooks for enabling 9 smart replace in the tests. 10 11 * WebCoreSupport/DragClientGtk.cpp: 12 (WebKit::DragClient::startDrag): targeListForDataObject now takes another 13 parameter determining whether or not to add smart paste support. Add it here. 14 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 15 (DumpRenderTreeSupportGtk::setSmartInsertDeleteEnabled): Added. 16 * WebCoreSupport/DumpRenderTreeSupportGtk.h: Add new method definition. 17 * WebCoreSupport/EditorClientGtk.cpp: 18 (WebKit::EditorClient::toggleSmartInsertDelete): Added implementation. 19 (WebKit::EditorClient::smartInsertDeleteEnabled): Added. 20 (WebKit::EditorClient::EditorClient): 21 * WebCoreSupport/EditorClientGtk.h: Add new method definition. 22 1 23 2011-06-03 Sergio Villar Senin <svillar@igalia.com> 2 24 -
trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp
r87049 r88066 29 29 #include "DOMWrapperWorld.h" 30 30 #include "Document.h" 31 #include "EditorClientGtk.h" 31 32 #include "Element.h" 32 33 #include "FocusController.h" … … 608 609 } 609 610 611 void DumpRenderTreeSupportGtk::setSmartInsertDeleteEnabled(WebKitWebView* webView, bool enabled) 612 { 613 g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView)); 614 g_return_if_fail(webView); 615 616 WebKit::EditorClient* client = static_cast<WebKit::EditorClient*>(core(webView)->editorClient()); 617 client->setSmartInsertDeleteEnabled(enabled); 618 } 619 610 620 void DumpRenderTreeSupportGtk::whiteListAccessFromOrigin(const gchar* sourceOrigin, const gchar* destinationProtocol, const gchar* destinationHost, bool allowDestinationSubdomains) 611 621 { -
trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h
r85925 r88066 106 106 static void rectangleForSelection(WebKitWebFrame*, GdkRectangle*); 107 107 static void scalePageBy(WebKitWebView*, float, float, float); 108 static void setSmartInsertDeleteEnabled(WebKitWebView*, bool); 108 109 109 110 // Accessibility -
trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp
r87978 r88066 296 296 GClosure* callback = g_cclosure_new_object(G_CALLBACK(collapseSelection), G_OBJECT(webView)); 297 297 g_closure_set_marshal(callback, g_cclosure_marshal_VOID__VOID); 298 PasteboardHelper::defaultPasteboardHelper()->writeClipboardContents(clipboard, callback);298 PasteboardHelper::defaultPasteboardHelper()->writeClipboardContents(clipboard, PasteboardHelper::DoNotIncludeSmartPaste, callback); 299 299 viewSettingClipboard = 0; 300 300 } … … 424 424 } 425 425 426 void EditorClient::setSmartInsertDeleteEnabled(bool enabled) 427 { 428 m_smartInsertDeleteEnabled = enabled; 429 } 430 426 431 bool EditorClient::smartInsertDeleteEnabled() 427 432 { 428 notImplemented(); 429 return false; 433 return m_smartInsertDeleteEnabled; 430 434 } 431 435 … … 627 631 , m_preventNextCompositionCommit(false) 628 632 , m_treatContextCommitAsKeyEvent(false) 633 , m_smartInsertDeleteEnabled(false) 629 634 { 630 635 WebKitWebViewPrivate* priv = m_webView->priv; -
trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.h
r86436 r88066 81 81 virtual bool shouldShowDeleteInterface(WebCore::HTMLElement*); 82 82 virtual bool smartInsertDeleteEnabled(); 83 void setSmartInsertDeleteEnabled(bool); 83 84 virtual bool isSelectTrailingWhitespaceEnabled(); 84 85 virtual bool isContinuousSpellCheckingEnabled(); … … 150 151 WebCore::KeyBindingTranslator m_keyBindingTranslator; 151 152 Vector<WTF::String> m_pendingEditorCommands; 153 154 bool m_smartInsertDeleteEnabled; 152 155 }; 153 156 } -
trunk/Tools/ChangeLog
r88062 r88066 1 2011-05-31 Martin Robinson <mrobinson@igalia.com> 2 3 Reviewed by Ryosuke Niwa. 4 5 [GTK] Support smart replace for the pasteboard 6 https://bugs.webkit.org/show_bug.cgi?id=61734 7 8 Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace. 9 This is required to produce consistent test results. 10 11 * DumpRenderTree/gtk/DumpRenderTree.cpp: 12 (resetDefaultsToConsistentValues): Set the smart replace setting to on by default. 13 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 14 (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this 15 methods which calls into DumpRenderTreeSupportGtk. 16 1 17 2011-06-03 Martin Robinson <mrobinson@igalia.com> 2 18 -
trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp
r88062 r88066 468 468 webkit_icon_database_set_path(webkit_get_icon_database(), 0); 469 469 DumpRenderTreeSupportGtk::setSelectTrailingWhitespaceEnabled(false); 470 DumpRenderTreeSupportGtk::setSmartInsertDeleteEnabled(webView, true); 470 471 471 472 if (axController) -
trunk/Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp
r87770 r88066 366 366 void LayoutTestController::setSmartInsertDeleteEnabled(bool flag) 367 367 { 368 // FIXME: implement368 DumpRenderTreeSupportGtk::setSmartInsertDeleteEnabled(webkit_web_frame_get_web_view(mainFrame), flag); 369 369 } 370 370
Note: See TracChangeset
for help on using the changeset viewer.