Changeset 88083 in webkit

Timestamp:

Jun 3, 2011 5:43:42 PM (13 years ago)

Author:

oliver@apple.com

Message:

2011-06-03 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

GCC not inlining some functions that it really should be
​https://bugs.webkit.org/show_bug.cgi?id=62075

Add ALWAYS_INLINE to a number of parsing and lexing functions
that should always be inlined. This gets us ~1.4% on my ad hoc
parser test.

• KeywordLookupGenerator.py:
• parser/JSParser.cpp: (JSC::JSParser::next): (JSC::JSParser::nextTokenIsColon): (JSC::JSParser::consume): (JSC::JSParser::match): (JSC::JSParser::tokenStart): (JSC::JSParser::tokenLine): (JSC::JSParser::tokenEnd):
• parser/Lexer.cpp: (JSC::isIdentPart):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• KeywordLookupGenerator.py (modified) (1 diff)
• parser/JSParser.cpp (modified) (3 diffs)
• parser/Lexer.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-06-03  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by Gavin Barraclough.
+
+        GCC not inlining some functions that it really should be
+        https://bugs.webkit.org/show_bug.cgi?id=62075
+
+        Add ALWAYS_INLINE to a number of parsing and lexing functions
+        that should always be inlined.  This gets us ~1.4% on my ad hoc
+        parser test.
+
+        * KeywordLookupGenerator.py:
+        * parser/JSParser.cpp:
+        (JSC::JSParser::next):
+        (JSC::JSParser::nextTokenIsColon):
+        (JSC::JSParser::consume):
+        (JSC::JSParser::match):
+        (JSC::JSParser::tokenStart):
+        (JSC::JSParser::tokenLine):
+        (JSC::JSParser::tokenEnd):
+        * parser/Lexer.cpp:
+        (JSC::isIdentPart):
+
 2011-06-03  Oliver Hunt  <oliver@apple.com>
 

trunk/Source/JavaScriptCore/KeywordLookupGenerator.py

@@ -164 +164 @@
     def printAsC(self):
         print("namespace JSC {")
-        print("static inline bool isIdentPart(int c);")
+        print("static ALWAYS_INLINE bool isIdentPart(int c);")
         # max length + 1 so we don't need to do any bounds checking at all
         print("static const int maxTokenLength = %d;" % (self.maxLength() + 1))

trunk/Source/JavaScriptCore/parser/JSParser.cpp

@@ -100 +100 @@
     };
     
-    void next(unsigned lexType = 0)
+    ALWAYS_INLINE void next(unsigned lexType = 0)
     {
         m_lastLine = m_token.m_info.line;
@@ -108 +108 @@
     }
     
-    bool nextTokenIsColon()
+    ALWAYS_INLINE bool nextTokenIsColon()
     {
         return m_lexer->nextTokenIsColon();
     }
 
-    bool consume(JSTokenType expected, unsigned flags = 0)
+    ALWAYS_INLINE bool consume(JSTokenType expected, unsigned flags = 0)
     {
         bool result = m_token.m_type == expected;
@@ -121 +121 @@
     }
 
-    bool match(JSTokenType expected)
+    ALWAYS_INLINE bool match(JSTokenType expected)
     {
         return m_token.m_type == expected;
     }
 
-    int tokenStart()
+    ALWAYS_INLINE int tokenStart()
     {
         return m_token.m_info.startOffset;
     }
 
-    int tokenLine()
+    ALWAYS_INLINE int tokenLine()
     {
         return m_token.m_info.line;
     }
 
-    int tokenEnd()
+    ALWAYS_INLINE int tokenEnd()
     {
         return m_token.m_info.endOffset;

trunk/Source/JavaScriptCore/parser/Lexer.cpp

@@ -358 +358 @@
 }
 
-static inline bool isIdentPart(int c)
+static ALWAYS_INLINE bool isIdentPart(int c)
 {
     // Character types are divided into two groups depending on whether they can be part of an