Changeset 88099 in webkit

Timestamp:

Jun 4, 2011 2:05:38 AM (13 years ago)

Author:

thakis@chromium.org

Message:

2011-06-04 Nico Weber <​thakis@chromium.org>

Reviewed by James Robinson.

Make the destructors of DataTransferItem and DataTransferItems virtual
​https://bugs.webkit.org/show_bug.cgi?id=62052

Clang has grown a new warning that warns on |delete ptr| if ptr's
class is non-final, has virtual methods, but no virtual destructor.
This warning finds real bugs, so we want to keep it enabled. However,
it also warns about DataTransferItem[s]. Since these are subclassed,
they can't be made final, so make their destructors virtual. (Maybe
clang's warning even points out an actual bug here.)

• dom/DataTransferItem.h: (WebCore::DataTransferItem::~DataTransferItem):
• dom/DataTransferItems.h: (WebCore::DataTransferItems::~DataTransferItems):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/DataTransferItem.h (modified) (1 diff)
• dom/DataTransferItems.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-04  Nico Weber  <thakis@chromium.org>
+
+        Reviewed by James Robinson.
+
+        Make the destructors of DataTransferItem and DataTransferItems virtual
+        https://bugs.webkit.org/show_bug.cgi?id=62052
+
+        Clang has grown a new warning that warns on |delete ptr| if ptr's
+        class is non-final, has virtual methods, but no virtual destructor.
+        This warning finds real bugs, so we want to keep it enabled. However,
+        it also warns about DataTransferItem[s]. Since these are subclassed,
+        they can't be made final, so make their destructors virtual. (Maybe
+        clang's warning even points out an actual bug here.)
+
+        * dom/DataTransferItem.h:
+        (WebCore::DataTransferItem::~DataTransferItem):
+        * dom/DataTransferItems.h:
+        (WebCore::DataTransferItems::~DataTransferItems):
+
 2011-06-04  Nico Weber  <thakis@chromium.org>
 

trunk/Source/WebCore/dom/DataTransferItem.h

@@ -47 +47 @@
 class DataTransferItem : public RefCounted<DataTransferItem> {
 public:
-    ~DataTransferItem() {}
+    virtual ~DataTransferItem() { }
 
     static PassRefPtr<DataTransferItem> create(PassRefPtr<Clipboard> owner, ScriptExecutionContext*, const String& data, const String& type);

trunk/Source/WebCore/dom/DataTransferItems.h

@@ -46 +46 @@
 class DataTransferItems : public RefCounted<DataTransferItems> {
 public:
-    ~DataTransferItems() {}
+    virtual ~DataTransferItems() { }
 
     virtual size_t length() const;