Changeset 88100 in webkit


Ignore:
Timestamp:
Jun 4, 2011 2:22:28 AM (13 years ago)
Author:
abarth@webkit.org
Message:

2011-06-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

V8Proxy::disconnectFrame doesn't do anything
​https://bugs.webkit.org/show_bug.cgi?id=62051

Dead code should die.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::~ScriptController):
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:
Location:
trunk/Source/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r88099 r88100  
     12011-06-04  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        V8Proxy::disconnectFrame doesn't do anything
     6        https://bugs.webkit.org/show_bug.cgi?id=62051
     7
     8        Dead code should die.
     9
     10        * bindings/v8/ScriptController.cpp:
     11        (WebCore::ScriptController::~ScriptController):
     12        * bindings/v8/V8Proxy.cpp:
     13        * bindings/v8/V8Proxy.h:
     14
    1152011-06-04  Nico Weber  <thakis@chromium.org>
    216

  • trunk/Source/WebCore/bindings/v8/ScriptController.cpp

    r87423 r88100  
    122122ScriptController::~ScriptController()
    123123{
    124     m_proxy->disconnectFrame();
    125124}
    126125

  • trunk/Source/WebCore/bindings/v8/V8Proxy.cpp

    r87961 r88100  
    607607}
    608608
    609 void V8Proxy::disconnectFrame()
    610 {
    611 }
    612 
    613609void V8Proxy::didLeaveScriptContext()
    614610{

  • trunk/Source/WebCore/bindings/v8/V8Proxy.h

    r87469 r88100  
    150150        void setTimerCallback(bool value) { m_timerCallback = value; }
    151151
    152         // Disconnects the proxy from its owner frame,
    153         // and clears all timeouts on the DOM window.
    154         void disconnectFrame();
    155 
    156152        void finishedWithEvent(Event*) { }
    157153
Note: See TracChangeset for help on using the changeset viewer.