Changeset 88108 in webkit

Timestamp:

Jun 4, 2011 4:06:49 AM (13 years ago)

Author:

thakis@chromium.org

Message:

2011-06-04 Nico Weber <​thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make WebTextCheckingCompletionImpl's destructor virtual
​https://bugs.webkit.org/show_bug.cgi?id=62074

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
​http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

• src/WebTextCheckingCompletionImpl.h: (WebKit::WebTextCheckingCompletionImpl::~WebTextCheckingCompletionImpl):

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/WebTextCheckingCompletionImpl.h (modified) (1 diff)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2011-06-04  Nico Weber  <thakis@chromium.org>
+
+        Reviewed by James Robinson.
+
+        [chromium] Make WebTextCheckingCompletionImpl's destructor virtual
+        https://bugs.webkit.org/show_bug.cgi?id=62074
+
+        This is _not_ to fix a real bug, just to make clang's
+        -Wdelete-non-virtual-dtor happy. As discussed at
+        http://codereview.chromium.org/7094005/, we prefer making leaf class
+        destructors virtual over making the leaf classes final.
+
+        * src/WebTextCheckingCompletionImpl.h:
+        (WebKit::WebTextCheckingCompletionImpl::~WebTextCheckingCompletionImpl):
+
 2011-06-04  Nico Weber  <thakis@chromium.org>
 

trunk/Source/WebKit/chromium/src/WebTextCheckingCompletionImpl.h

@@ -47 +47 @@
     }
 
+    virtual ~WebTextCheckingCompletionImpl() { }
+
     virtual void didFinishCheckingText(const WebVector<WebTextCheckingResult>&);