Changeset 88134 in webkit


Ignore:
Timestamp:
Jun 5, 2011 11:34:07 AM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-06-05 Igor Oliveira <​igor.oliveira@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

fast/viewport/viewport-45.html fails in GTK+/Qt
​https://bugs.webkit.org/show_bug.cgi?id=47481

Rebaseline tests.

  • fast/viewport/viewport-45-expected.txt:
  • fast/viewport/viewport-86-expected.txt:
  • platform/qt/Skipped:

2011-06-05 Igor Oliveira <​igor.oliveira@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

fast/viewport/viewport-45.html fails in GTK+/Qt
​https://bugs.webkit.org/show_bug.cgi?id=47481

computeViewportAttributes does many math operations with float point arithmetic
and in some cases there is loss of precision making tests have incorrect values.

  • dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes):
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r88128 r88134  
     12011-06-05  Igor Oliveira  <igor.oliveira@openbossa.org>
     2
     3        Reviewed by Kenneth Rohde Christiansen.
     4
     5        fast/viewport/viewport-45.html fails in GTK+/Qt
     6        https://bugs.webkit.org/show_bug.cgi?id=47481
     7
     8        Rebaseline tests.
     9
     10        * fast/viewport/viewport-45-expected.txt:
     11        * fast/viewport/viewport-86-expected.txt:
     12        * platform/qt/Skipped:
     13
    114== Rolled over to ChangeLog-2011-06-04 ==

  • trunk/LayoutTests/fast/viewport/viewport-45-expected.txt

    r67376 r88134  
    1 viewport size 3200x3520 scale 0.100000 with limits [0.100000, 0.100000]
     1viewport size 3200x3520 scale 0.100000 with limits [0.100000, 0.100000] and userScalable -1.000000
    22

  • trunk/LayoutTests/fast/viewport/viewport-86-expected.txt

    r81312 r88134  
    1 viewport size 457x502 scale 0.700000 with limits [0.700000, 5.000000] and userScalable -1.000000
     1viewport size 457x503 scale 0.700000 with limits [0.700000, 5.000000] and userScalable -1.000000
    22

  • trunk/LayoutTests/platform/qt/Skipped

    r88111 r88134  
    20672067# viewport meta tag tests that fail on the bot for yet unknown reasons
    20682068fast/viewport/viewport-6.html
    2069 fast/viewport/viewport-45.html
    20702069fast/viewport/viewport-58.html
    20712070

  • trunk/Source/WebCore/ChangeLog

    r88128 r88134  
     12011-06-05  Igor Oliveira  <igor.oliveira@openbossa.org>
     2
     3        Reviewed by Kenneth Rohde Christiansen.
     4
     5        fast/viewport/viewport-45.html fails in GTK+/Qt
     6        https://bugs.webkit.org/show_bug.cgi?id=47481
     7
     8        computeViewportAttributes does many math operations with float point arithmetic
     9        and in some cases there is loss of precision making tests have incorrect values.
     10
     11        * dom/ViewportArguments.cpp:
     12        (WebCore::computeViewportAttributes):
     13
    114== Rolled over to ChangeLog-2011-06-04 ==

  • trunk/Source/WebCore/dom/ViewportArguments.cpp

    r81309 r88134  
    165165    width = max(width, availableWidth / result.initialScale);
    166166    height = max(height, availableHeight / result.initialScale);
    167     result.layoutSize.setWidth(width);
    168     result.layoutSize.setHeight(height);
     167    result.layoutSize.setWidth(static_cast<int>(roundf(width)));
     168    result.layoutSize.setHeight(static_cast<int>(roundf(height)));
    169169
    170170    // Update minimum scale factor, to never allow zooming out more than viewport
Note: See TracChangeset for help on using the changeset viewer.