Changeset 88315 in webkit


Ignore:
Timestamp:
Jun 7, 2011 7:09:12 PM (13 years ago)
Author:
barraclough@apple.com
Message:

​https://bugs.webkit.org/show_bug.cgi?id=55537
Functions claim to have 'callee' which they actually don't (and shouldn't)

Source/JavaScriptCore:

Reviewed by Sam Weinig

(JSC::JSFunction::getOwnPropertyNames):

LayoutTests:

Reviewed by Sam Weinig.

  • fast/js/Object-getOwnPropertyNames-expected.txt:
  • fast/js/script-tests/Object-getOwnPropertyNames.js:
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r88309 r88315  
     12011-06-07  Gavin Barraclough  <barraclough@apple.com>
     2
     3        Reviewed by Sam Weinig.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=55537
     6        Functions claim to have 'callee' which they actually don't (and shouldn't)
     7
     8        * fast/js/Object-getOwnPropertyNames-expected.txt:
     9        * fast/js/script-tests/Object-getOwnPropertyNames.js:
     10
    1112011-06-07  James Kozianski  <koz@chromium.org>
    212

  • trunk/LayoutTests/fast/js/Object-getOwnPropertyNames-expected.txt

    r80378 r88315  
    1212PASS getSortedOwnPropertyNames(Object.create({}, { 'a': { 'value': 1, 'enumerable': false } })) is ['a']
    1313PASS getSortedOwnPropertyNames(Object.create([1,2,3], { 'a': { 'value': 1, 'enumerable': false } })) is ['a']
    14 PASS getSortedOwnPropertyNames(new Function()) is ['arguments', 'callee', 'caller', 'length', 'name', 'prototype']
    15 PASS getSortedOwnPropertyNames((function(){var x=new Function();x.__proto__=[1,2,3];return x;})()) is ['arguments', 'callee', 'caller', 'length', 'name', 'prototype']
     14PASS getSortedOwnPropertyNames(new Function()) is ['arguments', 'caller', 'length', 'name', 'prototype']
     15PASS getSortedOwnPropertyNames((function(){var x=new Function();x.__proto__=[1,2,3];return x;})()) is ['arguments', 'caller', 'length', 'name', 'prototype']
    1616PASS getSortedOwnPropertyNames(new String('')) is ['length']
    1717PASS getSortedOwnPropertyNames(new String('a')) is ['0', 'length']

  • trunk/LayoutTests/fast/js/script-tests/Object-getOwnPropertyNames.js

    r80378 r88315  
    1313    "Object.create([1,2,3], { 'a': { 'value': 1, 'enumerable': false } })": "['a']",
    1414// Function objects
    15     "new Function()": "['arguments', 'callee', 'caller', 'length', 'name', 'prototype']",
    16     "(function(){var x=new Function();x.__proto__=[1,2,3];return x;})()": "['arguments', 'callee', 'caller', 'length', 'name', 'prototype']",
     15    "new Function()": "['arguments', 'caller', 'length', 'name', 'prototype']",
     16    "(function(){var x=new Function();x.__proto__=[1,2,3];return x;})()": "['arguments', 'caller', 'length', 'name', 'prototype']",
    1717// String objects
    1818    "new String('')": "['length']",

  • trunk/Source/JavaScriptCore/ChangeLog

    r88313 r88315  
     12011-06-07  Gavin Barraclough  <barraclough@apple.com>
     2
     3        Reviewed by Sam Weinig
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=55537
     6        Functions claim to have 'callee' which they actually don't (and shouldn't)
     7
     8        * JavaScriptCore.xcodeproj/project.pbxproj:
     9        * runtime/JSFunction.cpp:
     10        (JSC::JSFunction::getOwnPropertyNames):
     11
    1122011-06-07  Juan C. Montemayor  <jmont@apple.com>
    213

  • trunk/Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

    r88076 r88315  
    787787                1482B7E10A43076000517CFC /* JSObjectRef.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSObjectRef.h; sourceTree = "<group>"; };
    788788                1482B7E20A43076000517CFC /* JSObjectRef.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSObjectRef.cpp; sourceTree = "<group>"; };
    789                 1483B589099BC1950016E4F0 /* JSImmediate.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = JSImmediate.h; sourceTree = "<group>"; };
    790789                148A1626095D16BB00666D0D /* ListRefPtr.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = ListRefPtr.h; sourceTree = "<group>"; };
    791790                148A1ECD0D10C23B0069A47C /* RefPtrHashMap.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RefPtrHashMap.h; sourceTree = "<group>"; };
    … …  
    18911890                                BC756FC60E2031B200DE7D12 /* JSGlobalObjectFunctions.cpp */,
    18921891                                BC756FC70E2031B200DE7D12 /* JSGlobalObjectFunctions.h */,
    1893                                 1483B589099BC1950016E4F0 /* JSImmediate.h */,
    18941892                                65EA4C99092AF9E20093D800 /* JSLock.cpp */,
    18951893                                65EA4C9A092AF9E20093D800 /* JSLock.h */,

  • trunk/Source/JavaScriptCore/runtime/JSFunction.cpp

    r87826 r88315  
    281281
    282282        propertyNames.add(exec->propertyNames().arguments);
    283         propertyNames.add(exec->propertyNames().callee);
    284283        propertyNames.add(exec->propertyNames().caller);
    285284        propertyNames.add(exec->propertyNames().length);
Note: See TracChangeset for help on using the changeset viewer.