Changeset 88355 in webkit

Timestamp:

Jun 8, 2011 10:14:30 AM (13 years ago)

Author:

Ademar Reis

Message:

2011-06-08 Ademar de Souza Reis Jr. <Ademar Reis>

Reviewed by Andreas Kling.

Webkit on SPARC Solaris has wrong endian
​https://bugs.webkit.org/show_bug.cgi?id=29407

Bug 57256 fixed one crash on misaligned reads on sparc/solaris, but
there are more ocurrences of the same code pattern in webkit.

This patch includes the check on these other parts of the code.

This is a speculative fix, I don't have a sparc machine to test and
don't know which kind of test would trigger a crash (but it's quite
obvious that it's the same code duplicated in different files).

• runtime/UString.h: (JSC::UStringHash::equal):
• wtf/text/StringHash.h: (WTF::StringHash::equal):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/UString.h (modified) (1 diff)
• wtf/text/StringHash.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-06-08  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
+
+        Reviewed by Andreas Kling.
+
+        Webkit on SPARC Solaris has wrong endian
+        https://bugs.webkit.org/show_bug.cgi?id=29407
+
+        Bug 57256 fixed one crash on misaligned reads on sparc/solaris, but
+        there are more ocurrences of the same code pattern in webkit.
+
+        This patch includes the check on these other parts of the code.
+
+        This is a speculative fix, I don't have a sparc machine to test and
+        don't know which kind of test would trigger a crash (but it's quite
+        obvious that it's the same code duplicated in different files).
+
+        * runtime/UString.h:
+        (JSC::UStringHash::equal):
+        * wtf/text/StringHash.h:
+        (WTF::StringHash::equal):
+
 2011-06-08  Yael Aharon  <yael.aharon@nokia.com>
 

trunk/Source/JavaScriptCore/runtime/UString.h

@@ -203 +203 @@
         // FIXME: perhaps we should have a more abstract macro that indicates when
         // going 4 bytes at a time is unsafe
-#if CPU(ARM) || CPU(SH4) || CPU(MIPS)
+#if CPU(ARM) || CPU(SH4) || CPU(MIPS) || CPU(SPARC)
         const UChar* aChars = a->characters();
         const UChar* bChars = b->characters();

trunk/Source/JavaScriptCore/wtf/text/StringHash.h

@@ -56 +56 @@
             // FIXME: perhaps we should have a more abstract macro that indicates when
             // going 4 bytes at a time is unsafe
-#if CPU(ARM) || CPU(SH4) || CPU(MIPS)
+#if CPU(ARM) || CPU(SH4) || CPU(MIPS) || CPU(SPARC)
             const UChar* aChars = a->characters();
             const UChar* bChars = b->characters();