Changeset 88428 in webkit

Timestamp:

Jun 8, 2011 11:38:08 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-06-08 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Fisher.

REGRESSION(88260): 10-50% performance regression across many page cyclers
​https://bugs.webkit.org/show_bug.cgi?id=62349

r88260 fixed a font cache resource leak and lowered the inactive font cache threshold. The latter caused a
significant performance regression across many chromium page cyclers, for example
​http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/moz/report.html?history=50&rev=88279.

This restores the previous inactive font size thresholds to their previous values, but retains the font cleanup
logic.

• platform/graphics/FontCache.cpp:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/FontCache.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-08  James Robinson  <jamesr@chromium.org>
+
+        Reviewed by Darin Fisher.
+
+        REGRESSION(88260): 10-50% performance regression across many page cyclers
+        https://bugs.webkit.org/show_bug.cgi?id=62349
+
+        r88260 fixed a font cache resource leak and lowered the inactive font cache threshold.  The latter caused a
+        significant performance regression across many chromium page cyclers, for example
+        http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/moz/report.html?history=50&rev=88279.
+
+        This restores the previous inactive font size thresholds to their previous values, but retains the font cleanup
+        logic.
+
+        * platform/graphics/FontCache.cpp:
+
 2011-06-08  Hayato Ito  <hayato@chromium.org>
 

trunk/Source/WebCore/platform/graphics/FontCache.cpp

@@ -252 +252 @@
 static FontDataCache* gFontDataCache = 0;
 
-const int cMaxInactiveFontData = 50; // Pretty Low Threshold
-const int cTargetInactiveFontData = 30;
+const int cMaxInactiveFontData = 120; // Pretty Low Threshold
+const int cTargetInactiveFontData = 100;
 static ListHashSet<const SimpleFontData*>* gInactiveFontData = 0;