Changeset 88474 in webkit

Timestamp:

Jun 9, 2011 12:52:27 PM (13 years ago)

Author:

jchaffraix@webkit.org

Message:

2011-06-09 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Darin Adler.

Test for WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
​https://bugs.webkit.org/show_bug.cgi?id=62384

• fast/css/webkit-keyframes-crash-expected.txt: Added.
• fast/css/webkit-keyframes-crash.html: Added.

2011-06-09 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Darin Adler.

WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
​https://bugs.webkit.org/show_bug.cgi?id=62384

Test: fast/css/webkit-keyframes-crash.html

• css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::setName): stylesheet() is never garanteed to return a non-null pointer. Thus null-check here like the rest of the code.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/webkit-keyframes-crash-expected.txt (added)
• LayoutTests/fast/css/webkit-keyframes-crash.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/WebKitCSSKeyframesRule.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-06-09  Julien Chaffraix  <jchaffraix@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        Test for WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
+        https://bugs.webkit.org/show_bug.cgi?id=62384
+
+        * fast/css/webkit-keyframes-crash-expected.txt: Added.
+        * fast/css/webkit-keyframes-crash.html: Added.
+
 2011-06-09  Julien Chaffraix  <jchaffraix@codeaurora.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-09  Julien Chaffraix  <jchaffraix@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
+        https://bugs.webkit.org/show_bug.cgi?id=62384
+
+        Test: fast/css/webkit-keyframes-crash.html
+
+        * css/WebKitCSSKeyframesRule.cpp:
+        (WebCore::WebKitCSSKeyframesRule::setName): stylesheet() is never garanteed
+        to return a non-null pointer. Thus null-check here like the rest of the code.
+
 2011-06-09  Julien Chaffraix  <jchaffraix@codeaurora.org>
 

trunk/Source/WebCore/css/WebKitCSSKeyframesRule.cpp

@@ -67 +67 @@
     // Since the name is used in the keyframe map list in CSSStyleSelector, we need
     // to recompute the style sheet to get the updated name.
-    stylesheet()->styleSheetChanged();
+    if (stylesheet())
+        stylesheet()->styleSheetChanged();
 }