Changeset 88581 in webkit

Timestamp:

Jun 10, 2011 5:38:26 PM (13 years ago)

Author:

abarth@webkit.org

Message:

2011-06-10 Adam Barth <​abarth@webkit.org>

Reviewed by James Robinson.

When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
​https://bugs.webkit.org/show_bug.cgi?id=62489

• Scripts/webkitpy/tool/bot/sheriff.py:
• Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/bot/sheriff.py (modified) (1 diff)
• Scripts/webkitpy/tool/commands/sheriffbot_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-06-10  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by James Robinson.
+
+        When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
+        https://bugs.webkit.org/show_bug.cgi?id=62489
+
+        * Scripts/webkitpy/tool/bot/sheriff.py:
+        * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
+
 2011-06-10  Tony Chang  <tony@chromium.org>
 

trunk/Tools/Scripts/webkitpy/tool/bot/sheriff.py

@@ -58 +58 @@
         test_list_limit = 5
         irc_message = "New failures: %s" % ", ".join(sorted(failing_tests)[:test_list_limit])
-        if len(failing_tests) > test_list_limit:
-            irc_message += " (and more...)"
+        failure_count = len(failing_tests)
+        if failure_count > test_list_limit:
+            irc_message += " (and %s more...)" % (failure_count - test_list_limit)
         self._tool.irc().post(irc_message)
 

trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot_unittest.py

@@ -59 +59 @@
             "next_work_item": "",
             "process_work_item": """MOCK: irc.post: abarth, darin, eseidel: http://trac.webkit.org/changeset/29837 might have broken Builder1
-MOCK: irc.post: New failures: test1, test2, test3, test4, test5 (and more...)
+MOCK: irc.post: New failures: test1, test2, test3, test4, test5 (and 2 more...)
 """,
             "handle_unexpected_error": "Mock error message\n",