Changeset 88611 in webkit

Timestamp:

Jun 11, 2011 11:01:25 PM (13 years ago)

Author:

msaboff@apple.com

Message:

2011-06-11 Michael Saboff <​msaboff@apple.com>

Reviewed by James Robinson.

REGRESSION(88260): 10-50% performance regression across many page cyclers
​https://bugs.webkit.org/show_bug.cgi?id=62349

Made CHROMIUM platform specific values for cMaxInactiveFontData and
cTargetInactiveFontData to mitigate the current performance issue on Chromium
page cycler tests. Made the chromium value for cMaxInactiveFontData 250 based
on recommendation from James Robinson. Changed cTargetInactiveFontData to 200
so that 50 inactive fonts will be cleaned up at a time.

Change made to address existing Chromium performance test regression.

• platform/graphics/FontCache.cpp:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/FontCache.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-11  Michael Saboff  <msaboff@apple.com>
+
+        Reviewed by James Robinson.
+
+        REGRESSION(88260): 10-50% performance regression across many page cyclers
+        https://bugs.webkit.org/show_bug.cgi?id=62349
+
+        Made CHROMIUM platform specific values for cMaxInactiveFontData and
+        cTargetInactiveFontData to mitigate the current performance issue on Chromium
+        page cycler tests.  Made the chromium value for cMaxInactiveFontData 250 based
+        on recommendation from James Robinson.  Changed cTargetInactiveFontData to 200
+        so that 50 inactive fonts will be cleaned up at a time.
+
+        Change made to address existing Chromium performance test regression.
+
+        * platform/graphics/FontCache.cpp:
+
 2011-06-11  Adam Barth  <abarth@webkit.org>
 

trunk/Source/WebCore/platform/graphics/FontCache.cpp

@@ -252 +252 @@
 static FontDataCache* gFontDataCache = 0;
 
-const int cMaxInactiveFontData = 120; // Pretty Low Threshold
-const int cTargetInactiveFontData = 100;
+#if PLATFORM(CHROMIUM)
+const int cMaxInactiveFontData = 250;
+const int cTargetInactiveFontData = 200;
+#else
+const int cMaxInactiveFontData = 50; // Pretty Low Threshold
+const int cTargetInactiveFontData = 30;
+#endif
 static ListHashSet<const SimpleFontData*>* gInactiveFontData = 0;