Changeset 88629 in webkit

Timestamp:

Jun 12, 2011 11:20:45 PM (13 years ago)

Author:

jer.noble@apple.com

Message:

2011-06-12 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

REGRESSION (full screen video): Watch Again button is obscured after full screen playback ends at Apple trailers page
​https://bugs.webkit.org/show_bug.cgi?id=62507

No new tests; DRT would have to be modified to delay between receiving exitFullScreenForElement() and calling
webkitWillExitFullScreenForElement() to be able to test this.

If the full-screen element is removed, and webkitWillExitFullScreenForElement() is not called before
fullScreenElementRemoved() returns, then ancestors of the full-screen element will not have their
containsFullScreenElement property removed. To protect against this, reset the property by calling
setContainsFullScreenElementRecursively() from within fullScreenElementRemoved().

• dom/Document.cpp: (WebCore::Document::fullScreenElementRemoved): Added call to setContainsFullScreenElementRecursively.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Document.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-12  Jer Noble  <jer.noble@apple.com>
+
+        Reviewed by Darin Adler.
+
+        REGRESSION (full screen video): Watch Again button is obscured after full screen playback ends at Apple trailers page
+        https://bugs.webkit.org/show_bug.cgi?id=62507
+
+        No new tests; DRT would have to be modified to delay between receiving exitFullScreenForElement() and calling 
+        webkitWillExitFullScreenForElement() to be able to test this.
+
+        If the full-screen element is removed, and webkitWillExitFullScreenForElement() is not called before
+        fullScreenElementRemoved() returns, then ancestors of the full-screen element will not have their
+        containsFullScreenElement property removed.  To protect against this, reset the property by calling 
+        setContainsFullScreenElementRecursively() from within fullScreenElementRemoved().
+
+        * dom/Document.cpp:
+        (WebCore::Document::fullScreenElementRemoved): Added call to setContainsFullScreenElementRecursively.
+
 2011-06-12  Adam Barth  <abarth@webkit.org>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -4917 +4917 @@
 void Document::fullScreenElementRemoved()
 {
+    setContainsFullScreenElementRecursively(m_fullScreenElement->parentElement() ? m_fullScreenElement->parentElement() : ownerElement(), false);
     webkitCancelFullScreen();
 }