Changeset 88640 in webkit

Timestamp:

Jun 13, 2011 8:28:56 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-06-13 Eunmi Lee <​eunmi15.lee@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL][WK2] Minor fix: fix coding style and remove unnecessary codes for WebKit2 efl port's PageClientImpl
​https://bugs.webkit.org/show_bug.cgi?id=62429

• UIProcess/API/efl/PageClientImpl.cpp: (WebKit::PageClientImpl::scrollView): (WebKit::PageClientImpl::setCursor): (WebKit::PageClientImpl::windowToScreen): (WebKit::PageClientImpl::doneWithKeyEvent): (WebKit::PageClientImpl::setFindIndicator): (WebKit::PageClientImpl::didCommitLoadForMainFrame): (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation): (WebKit::PageClientImpl::findStringInCustomRepresentation): (WebKit::PageClientImpl::countStringMatchesInCustomRepresentation):
• UIProcess/API/efl/PageClientImpl.h:

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/efl/PageClientImpl.cpp (modified) (7 diffs)
• UIProcess/API/efl/PageClientImpl.h (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-06-13  Eunmi Lee  <eunmi15.lee@samsung.com>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        [EFL][WK2] Minor fix: fix coding style and remove unnecessary codes for WebKit2 efl port's PageClientImpl
+        https://bugs.webkit.org/show_bug.cgi?id=62429
+
+        * UIProcess/API/efl/PageClientImpl.cpp:
+        (WebKit::PageClientImpl::scrollView):
+        (WebKit::PageClientImpl::setCursor):
+        (WebKit::PageClientImpl::windowToScreen):
+        (WebKit::PageClientImpl::doneWithKeyEvent):
+        (WebKit::PageClientImpl::setFindIndicator):
+        (WebKit::PageClientImpl::didCommitLoadForMainFrame):
+        (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
+        (WebKit::PageClientImpl::findStringInCustomRepresentation):
+        (WebKit::PageClientImpl::countStringMatchesInCustomRepresentation):
+        * UIProcess/API/efl/PageClientImpl.h:
+
 2011-06-13  Eunmi Lee  <eunmi15.lee@samsung.com>
 

trunk/Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp

@@ -65 +65 @@
 }
 
-void PageClientImpl::scrollView(const WebCore::IntRect& scrollRect, const WebCore::IntSize& scrollOffset)
+void PageClientImpl::scrollView(const WebCore::IntRect& scrollRect, const WebCore::IntSize&)
 {
     setViewNeedsDisplay(scrollRect);
-#define USE_EWK_TOUCH 1
-#if USE_EWK_TOUCH
-    evas_object_move(m_viewObject, 0, 0);
-#endif
 }
 
@@ -125 +121 @@
 }
 
-void PageClientImpl::setCursor(const Cursor& cursor)
+void PageClientImpl::setCursor(const Cursor&)
 {
     notImplemented();
@@ -168 +164 @@
 }
 
-IntRect PageClientImpl::windowToScreen(const IntRect& rect)
+IntRect PageClientImpl::windowToScreen(const IntRect&)
 {
     notImplemented();
@@ -174 +170 @@
 }
 
-void PageClientImpl::doneWithKeyEvent(const NativeWebKeyboardEvent&, bool wasEventHandled)
+void PageClientImpl::doneWithKeyEvent(const NativeWebKeyboardEvent&, bool)
 {
     notImplemented();
@@ -191 +187 @@
 }
 
-void PageClientImpl::setFindIndicator(PassRefPtr<FindIndicator>, bool fadeOut)
+void PageClientImpl::setFindIndicator(PassRefPtr<FindIndicator>, bool)
 {
     notImplemented();
@@ -201 +197 @@
 }
 
-void PageClientImpl::didCommitLoadForMainFrame(bool useCustomRepresentation)
-{
-    notImplemented();
-}
-
-void PageClientImpl::didFinishLoadingDataForCustomRepresentation(const String& suggestedFilename, const CoreIPC::DataReference&)
+void PageClientImpl::didCommitLoadForMainFrame(bool)
+{
+    notImplemented();
+}
+
+void PageClientImpl::didFinishLoadingDataForCustomRepresentation(const String&, const CoreIPC::DataReference&)
 {
     notImplemented();
@@ -227 +223 @@
 }
 
-void PageClientImpl::findStringInCustomRepresentation(const String&, FindOptions, unsigned maxMatchCount)
-{
-    notImplemented();
-}
-
-void PageClientImpl::countStringMatchesInCustomRepresentation(const String&, FindOptions, unsigned maxMatchCount)
+void PageClientImpl::findStringInCustomRepresentation(const String&, FindOptions, unsigned)
+{
+    notImplemented();
+}
+
+void PageClientImpl::countStringMatchesInCustomRepresentation(const String&, FindOptions, unsigned)
 {
     notImplemented();

trunk/Source/WebKit2/UIProcess/API/efl/PageClientImpl.h

@@ -51 +51 @@
     virtual void setViewNeedsDisplay(const WebCore::IntRect&);
     virtual void displayView();
-    virtual void scrollView(const WebCore::IntRect& scrollRect, const WebCore::IntSize& scrollOffset);
+    virtual void scrollView(const WebCore::IntRect&, const WebCore::IntSize&);
     virtual WebCore::IntSize viewSize();
     virtual bool isViewWindowActive();
@@ -75 +75 @@
     virtual WebCore::IntRect windowToScreen(const WebCore::IntRect&);
 
-    virtual void doneWithKeyEvent(const NativeWebKeyboardEvent&, bool wasEventHandled);
+    virtual void doneWithKeyEvent(const NativeWebKeyboardEvent&, bool);
 
     virtual PassRefPtr<WebPopupMenuProxy> createPopupMenuProxy(WebPageProxy*);
     virtual PassRefPtr<WebContextMenuProxy> createContextMenuProxy(WebPageProxy*);
 
-    virtual void setFindIndicator(PassRefPtr<FindIndicator>, bool fadeOut);
+    virtual void setFindIndicator(PassRefPtr<FindIndicator>, bool);
 
     virtual void didChangeScrollbarsForMainFrame() const;
 
-    virtual void didCommitLoadForMainFrame(bool useCustomRepresentation);
-    virtual void didFinishLoadingDataForCustomRepresentation(const String& suggestedFilename, const CoreIPC::DataReference&);
+    virtual void didCommitLoadForMainFrame(bool);
+    virtual void didFinishLoadingDataForCustomRepresentation(const String&, const CoreIPC::DataReference&);
     virtual double customRepresentationZoomFactor();
     virtual void setCustomRepresentationZoomFactor(double);
 
-    virtual void flashBackingStoreUpdates(const Vector<WebCore::IntRect>& updateRects);
-    virtual void findStringInCustomRepresentation(const String&, FindOptions, unsigned maxMatchCount);
-    virtual void countStringMatchesInCustomRepresentation(const String&, FindOptions, unsigned maxMatchCount);
+    virtual void flashBackingStoreUpdates(const Vector<WebCore::IntRect>&);
+    virtual void findStringInCustomRepresentation(const String&, FindOptions, unsigned);
+    virtual void countStringMatchesInCustomRepresentation(const String&, FindOptions, unsigned);
 
     virtual float userSpaceScaleFactor() const;