Changeset 88641 in webkit

Timestamp:

Jun 13, 2011 8:36:13 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-06-13 Young Han Lee <​joybro@company100.net>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Accelerated animation is repeating as if its direction property is always 'alternate'.
​https://bugs.webkit.org/show_bug.cgi?id=62281

syncAnimations() has miscalculated a normalized progress value as if the animation always has alternate direction property.

• animations/animation-direction-normal-expected.png: Added.
• animations/animation-direction-normal-expected.txt: Added.
• animations/animation-direction-normal.html: Added.

2011-06-13 Young Han Lee <​joybro@company100.net>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Accelerated animation is repeating as if its direction property is always 'alternate'.
​https://bugs.webkit.org/show_bug.cgi?id=62281

syncAnimations() has miscalculated a normalized progress value as if the animation always has alternate direction property.

Test: animations/animation-direction-normal.html

• platform/graphics/texmap/TextureMapperNode.cpp: (WebCore::TextureMapperNode::syncAnimations):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/animations/animation-direction-normal-expected.png (added)
• LayoutTests/animations/animation-direction-normal-expected.txt (added)
• LayoutTests/animations/animation-direction-normal.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-06-13  Young Han Lee  <joybro@company100.net>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        [Texmap][Qt] Accelerated animation is repeating as if its direction property is always 'alternate'.
+        https://bugs.webkit.org/show_bug.cgi?id=62281
+
+        syncAnimations() has miscalculated a normalized progress value as if the animation always has alternate direction property.
+
+        * animations/animation-direction-normal-expected.png: Added.
+        * animations/animation-direction-normal-expected.txt: Added.
+        * animations/animation-direction-normal.html: Added.
+
 2011-06-13  Dirk Schulze  <krit@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-13  Young Han Lee  <joybro@company100.net>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        [Texmap][Qt] Accelerated animation is repeating as if its direction property is always 'alternate'.
+        https://bugs.webkit.org/show_bug.cgi?id=62281
+
+        syncAnimations() has miscalculated a normalized progress value as if the animation always has alternate direction property.
+
+        Test: animations/animation-direction-normal.html
+
+        * platform/graphics/texmap/TextureMapperNode.cpp:
+        (WebCore::TextureMapperNode::syncAnimations):
+
 2011-06-13  Dirk Schulze  <krit@webkit.org>
 

trunk/Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp

@@ -843 +843 @@
         double totalRunningTime = WTF::currentTime() - animation->startTime;
         RefPtr<Animation> anim = animation->animation;
-        double normalizedValue = normalizedAnimationValue(totalRunningTime, anim->duration(), true);
+        double normalizedValue = normalizedAnimationValue(totalRunningTime, anim->duration(), anim->direction());
 
         if (anim->iterationCount() != Animation::IterationCountInfinite && totalRunningTime >= anim->duration() * anim->iterationCount()) {