Changeset 88660 in webkit


Ignore:
Timestamp:
Jun 13, 2011 11:29:05 AM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-06-13 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: setVersion() version argument is required
​https://bugs.webkit.org/show_bug.cgi?id=62401

  • storage/indexeddb/setVersion-undefined-expected.txt: Added.
  • storage/indexeddb/setVersion-undefined.html: Added.

2011-06-13 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: setVersion() version argument is required
​https://bugs.webkit.org/show_bug.cgi?id=62401

Test: storage/indexeddb/setVersion-undefined.html

  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setVersion): check for null version
  • storage/IDBDatabase.idl: add IDL magic to force undefined to null so we can handle both missing and null arguments
Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r88658 r88660  
     12011-06-13  Mark Pilgrim  <pilgrim@chromium.org>
     2
     3        Reviewed by Tony Chang.
     4
     5        IndexedDB: setVersion() version argument is required
     6        https://bugs.webkit.org/show_bug.cgi?id=62401
     7
     8        * storage/indexeddb/setVersion-undefined-expected.txt: Added.
     9        * storage/indexeddb/setVersion-undefined.html: Added.
     10
    1112011-06-13  Dimitri Glazkov  <dglazkov@chromium.org>
    212

  • trunk/Source/WebCore/ChangeLog

    r88657 r88660  
     12011-06-13  Mark Pilgrim  <pilgrim@chromium.org>
     2
     3        Reviewed by Tony Chang.
     4
     5        IndexedDB: setVersion() version argument is required
     6        https://bugs.webkit.org/show_bug.cgi?id=62401
     7
     8        Test: storage/indexeddb/setVersion-undefined.html
     9
     10        * storage/IDBDatabase.cpp:
     11        (WebCore::IDBDatabase::setVersion): check for null version
     12        * storage/IDBDatabase.idl: add IDL magic to force undefined to null so we can handle both missing and null arguments
     13
    1142011-06-13  Simon Fraser  <simon.fraser@apple.com>
    215

  • trunk/Source/WebCore/storage/IDBDatabase.cpp

    r88602 r88660  
    106106PassRefPtr<IDBVersionChangeRequest> IDBDatabase::setVersion(ScriptExecutionContext* context, const String& version, ExceptionCode& ec)
    107107{
     108    if (version.isNull()) {
     109        ec = IDBDatabaseException::NON_TRANSIENT_ERR;
     110        return 0;
     111    }
     112
    108113    RefPtr<IDBVersionChangeRequest> request = IDBVersionChangeRequest::create(context, IDBAny::create(this), version);
    109114    m_backend->setVersion(version, request, m_databaseCallbacks, ec);

  • trunk/Source/WebCore/storage/IDBDatabase.idl

    r88602 r88660  
    4444        void deleteObjectStore(in DOMString name)
    4545            raises (IDBDatabaseException);
    46         [CallWith=ScriptExecutionContext] IDBVersionChangeRequest setVersion(in DOMString version)
     46        [CallWith=ScriptExecutionContext] IDBVersionChangeRequest setVersion(in [ConvertUndefinedOrNullToNullString] DOMString version)
    4747            raises (IDBDatabaseException);
    4848        [CallWith=ScriptExecutionContext] IDBTransaction transaction(in [Optional] DOMStringList storeNames, in [Optional] unsigned short mode)
Note: See TracChangeset for help on using the changeset viewer.