Changeset 88800 in webkit


Ignore:
Timestamp:
Jun 14, 2011 7:36:50 AM (13 years ago)
Author:
Carlos Garcia Campos
Message:

2011-06-14 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Support authentication dialogs in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=62366

Add a new class to show an authentication dialog that is used by
both WebKit1 and WebKit2.

  • GNUmakefile.list.am: Add new files to compilation.
  • platform/gtk/GtkAuthenticationDialog.cpp: Added. (WebCore::addEntryToTable): (WebCore::sessionCanSavePasswords): (WebCore::GtkAuthenticationDialog::~GtkAuthenticationDialog): (WebCore::GtkAuthenticationDialog::GtkAuthenticationDialog): (WebCore::getSavedLogin): (WebCore::GtkAuthenticationDialog::show): (WebCore::GtkAuthenticationDialog::destroy): (WebCore::GtkAuthenticationDialog::savePasswordCallback): (WebCore::GtkAuthenticationDialog::savePassword): (WebCore::GtkAuthenticationDialog::authenticate): (WebCore::GtkAuthenticationDialog::authenticationDialogResponseCallback):
  • platform/gtk/GtkAuthenticationDialog.h: Added.

2011-06-14 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Support authentication dialogs in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=62366

Move the common code of webkitsoupauthdialog to a common C++ class
in WebCore so that it can be used by WebKit2 too. The file has
been converted into a C++ file.

  • GNUmakefile.am: Rename webkitsoupauthdialog.c to webkitsoupauthdialog.cpp.
  • webkit/webkitsoupauthdialog.c: Removed.
  • webkit/webkitsoupauthdialog.cpp: Added. (webkit_soup_auth_dialog_class_init): (webkit_soup_auth_dialog_init): (webkit_soup_auth_dialog_session_feature_init): (sessionAuthenticate): Use GtkAuthenticationDialog object from WebCore. (attach): (detach):
  • webkit/webkitsoupauthdialog.h:

2011-06-14 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Support authentication dialogs in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=62366

Add a new soup feature to show an authentication dialog when it
gets a 401 HTTP response.

  • GNUmakefile.am: Add new files to compilation.
  • WebProcess/gtk/WebAuthDialog.cpp: Added. (web_auth_dialog_class_init): (web_auth_dialog_init): (sessionAuthenticate): (attach): (detach): (webAuthDialogSessionFeatureInit):
  • WebProcess/gtk/WebAuthDialog.h: Added.
  • WebProcess/gtk/WebProcessMainGtk.cpp: (WebKit::WebProcessMainGtk):
Location:
trunk/Source
Files:
5 added
1 deleted
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r88798 r88800  
     12011-06-14  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        Reviewed by Martin Robinson.
     4
     5        [GTK] Support authentication dialogs in WebKit2
     6        https://bugs.webkit.org/show_bug.cgi?id=62366
     7
     8        Add a new class to show an authentication dialog that is used by
     9        both WebKit1 and WebKit2.
     10
     11        * GNUmakefile.list.am: Add new files to compilation.
     12        * platform/gtk/GtkAuthenticationDialog.cpp: Added.
     13        (WebCore::addEntryToTable):
     14        (WebCore::sessionCanSavePasswords):
     15        (WebCore::GtkAuthenticationDialog::~GtkAuthenticationDialog):
     16        (WebCore::GtkAuthenticationDialog::GtkAuthenticationDialog):
     17        (WebCore::getSavedLogin):
     18        (WebCore::GtkAuthenticationDialog::show):
     19        (WebCore::GtkAuthenticationDialog::destroy):
     20        (WebCore::GtkAuthenticationDialog::savePasswordCallback):
     21        (WebCore::GtkAuthenticationDialog::savePassword):
     22        (WebCore::GtkAuthenticationDialog::authenticate):
     23        (WebCore::GtkAuthenticationDialog::authenticationDialogResponseCallback):
     24        * platform/gtk/GtkAuthenticationDialog.h: Added.
     25
    1262011-06-14  Tommy Widenflycht  <tommyw@google.com>
    227

  • trunk/Source/WebCore/GNUmakefile.list.am

    r88798 r88800  
    38183818        Source/WebCore/platform/gtk/GRefPtrGtk.cpp \
    38193819        Source/WebCore/platform/gtk/GRefPtrGtk.h \
     3820        Source/WebCore/platform/gtk/GtkAuthenticationDialog.cpp \
     3821        Source/WebCore/platform/gtk/GtkAuthenticationDialog.h \
    38203822        Source/WebCore/platform/gtk/GtkPluginWidget.cpp \
    38213823        Source/WebCore/platform/gtk/GtkPluginWidget.h \

  • trunk/Source/WebKit/gtk/ChangeLog

    r88754 r88800  
     12011-06-14  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        Reviewed by Martin Robinson.
     4
     5        [GTK] Support authentication dialogs in WebKit2
     6        https://bugs.webkit.org/show_bug.cgi?id=62366
     7
     8        Move the common code of webkitsoupauthdialog to a common C++ class
     9        in WebCore so that it can be used by WebKit2 too. The file has
     10        been converted into a C++ file.
     11
     12        * GNUmakefile.am: Rename webkitsoupauthdialog.c to
     13        webkitsoupauthdialog.cpp.
     14        * webkit/webkitsoupauthdialog.c: Removed.
     15        * webkit/webkitsoupauthdialog.cpp: Added.
     16        (webkit_soup_auth_dialog_class_init):
     17        (webkit_soup_auth_dialog_init):
     18        (webkit_soup_auth_dialog_session_feature_init):
     19        (sessionAuthenticate): Use GtkAuthenticationDialog object from
     20        WebCore.
     21        (attach):
     22        (detach):
     23        * webkit/webkitsoupauthdialog.h:
     24
    1252011-06-13  Joone Hur  <joone.hur@collabora.co.uk>
    226

  • trunk/Source/WebKit/gtk/GNUmakefile.am

    r88674 r88800  
    218218        Source/WebKit/gtk/webkit/webkitsecurityorigin.cpp \
    219219        Source/WebKit/gtk/webkit/webkitsecurityoriginprivate.h \
    220         Source/WebKit/gtk/webkit/webkitsoupauthdialog.c \
     220        Source/WebKit/gtk/webkit/webkitsoupauthdialog.cpp \
    221221        Source/WebKit/gtk/webkit/webkitspellchecker.cpp \
    222222        Source/WebKit/gtk/webkit/webkitspellcheckerenchant.cpp \

  • trunk/Source/WebKit/gtk/webkit/webkitsoupauthdialog.h

    r74691 r88800  
    2222
    2323#include <gtk/gtk.h>
     24#include <libsoup/soup.h>
    2425#include <webkit/webkitdefines.h>
    2526

  • trunk/Source/WebKit2/ChangeLog

    r88799 r88800  
     12011-06-14  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        Reviewed by Martin Robinson.
     4
     5        [GTK] Support authentication dialogs in WebKit2
     6        https://bugs.webkit.org/show_bug.cgi?id=62366
     7
     8        Add a new soup feature to show an authentication dialog when it
     9        gets a 401 HTTP response.
     10
     11        * GNUmakefile.am: Add new files to compilation.
     12        * WebProcess/gtk/WebAuthDialog.cpp: Added.
     13        (web_auth_dialog_class_init):
     14        (web_auth_dialog_init):
     15        (sessionAuthenticate):
     16        (attach):
     17        (detach):
     18        (webAuthDialogSessionFeatureInit):
     19        * WebProcess/gtk/WebAuthDialog.h: Added.
     20        * WebProcess/gtk/WebProcessMainGtk.cpp:
     21        (WebKit::WebProcessMainGtk):
     22
    1232011-06-14  No'am Rosenthal  <noam.rosenthal@nokia.com> and Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
    224

  • trunk/Source/WebKit2/GNUmakefile.am

    r88634 r88800  
    527527        Source/WebKit2/WebProcess/Geolocation/WebGeolocationManager.cpp \
    528528        Source/WebKit2/WebProcess/Geolocation/WebGeolocationManager.h \
     529        Source/WebKit2/WebProcess/gtk/WebAuthDialog.cpp \
     530        Source/WebKit2/WebProcess/gtk/WebAuthDialog.h \
    529531        Source/WebKit2/WebProcess/gtk/WebProcessGtk.cpp \
    530532        Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp \

  • trunk/Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp

    r78028 r88800  
    2828#include "WebProcessMainGtk.h"
    2929
     30#include "WebAuthDialog.h"
    3031#include "WKBase.h"
     32#include <WebCore/GtkAuthenticationDialog.h>
    3133#include <WebCore/ResourceHandle.h>
    3234#include <WebKit2/RunLoop.h>
    … …  
    5759    SoupSession* session = WebCore::ResourceHandle::defaultSession();
    5860
    59     SoupSessionFeature* sniffer = static_cast<SoupSessionFeature*>(g_object_new(SOUP_TYPE_CONTENT_SNIFFER, NULL));
    60     soup_session_add_feature(session, sniffer);
    61     g_object_unref(sniffer);
     61    GRefPtr<SoupSessionFeature> sniffer = adoptGRef(static_cast<SoupSessionFeature*>(g_object_new(SOUP_TYPE_CONTENT_SNIFFER, NULL)));
     62    soup_session_add_feature(session, sniffer.get());
    6263
    6364    soup_session_add_feature_by_type(session, SOUP_TYPE_CONTENT_DECODER);
     65
     66    GRefPtr<SoupSessionFeature> authDialog = adoptGRef(static_cast<SoupSessionFeature*>(g_object_new(WEB_TYPE_AUTH_DIALOG, NULL)));
     67    soup_session_add_feature(session, authDialog.get());
    6468
    6569    int socket = atoi(argv[1]);
Note: See TracChangeset for help on using the changeset viewer.