Changeset 88805 in webkit


Ignore:
Timestamp:
Jun 14, 2011 8:48:47 AM (13 years ago)
Author:
pfeldman@chromium.org
Message:

2011-06-14 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Implement CSS border radius properies in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=62265

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp: Implement new class to culculate border radius, initialize for appropriate properties. (WebCore::ApplyPropertyBorderRadius::ApplyPropertyBorderRadius): (WebCore::ApplyPropertyBorderRadius::applyValue): (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
  • css/CSSStyleSelector.cpp: Remove old implementations. (WebCore::CSSStyleSelector::applyProperty):
  • page/animation/AnimationBase.cpp: Pass LengthSize by value. (WebCore::AnimationBase::ensurePropertyMap):
  • rendering/style/RenderStyle.h: Pass LengthSize by value consistently.
Location:
trunk/Source/WebCore
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r88804 r88805  
    155155        (WebCore::HTMLProgressElement::didElementStateChange):
    156156        * html/HTMLProgressElement.h:
     157
     1582011-06-14  Pavel Feldman  <pfeldman@google.com>
     159
     160        Reviewed by Yury Semikhatsky.
     161
     162        Web Inspector: use ew-resize instead of col-resize for non-columns.
     163        https://bugs.webkit.org/show_bug.cgi?id=62640
     164
     165        * inspector/front-end/ElementsPanel.js:
     166        (WebInspector.ElementsPanel.prototype.rightSidebarResizerDragStart):
     167        * inspector/front-end/Panel.js:
     168        (WebInspector.Panel.prototype._startSidebarDragging):
     169        * inspector/front-end/ScriptsPanel.js:
     170        (WebInspector.ScriptsPanel.prototype._startSidebarResizeDrag):
     171        * inspector/front-end/TimelineOverviewPane.js:
     172        (WebInspector.TimelineOverviewPane.prototype._resizeWindow):
     173        (WebInspector.TimelineOverviewPane.prototype._dragWindow):
     174        * inspector/front-end/inspector.css:
     175        (body.attached #toolbar):
     176        (body.drawer-visible #main-status-bar):
     177        (#scripts-sidebar-resizer-widget):
     178        (.sidebar-resizer-vertical):
     179        (.timeline-window-resizer):
    157180
    1581812011-06-14  Pavel Feldman  <pfeldman@google.com>
  • trunk/Source/WebCore/inspector/front-end/ElementsPanel.js

    r88331 r88805  
    10991099    rightSidebarResizerDragStart: function(event)
    11001100    {
    1101         WebInspector.elementDragStart(this.sidebarElement, this.rightSidebarResizerDrag.bind(this), this.rightSidebarResizerDragEnd.bind(this), event, "col-resize");
     1101        WebInspector.elementDragStart(this.sidebarElement, this.rightSidebarResizerDrag.bind(this), this.rightSidebarResizerDragEnd.bind(this), event, "ew-resize");
    11021102    },
    11031103
  • trunk/Source/WebCore/inspector/front-end/Panel.js

    r87166 r88805  
    317317    _startSidebarDragging: function(event)
    318318    {
    319         WebInspector.elementDragStart(this.sidebarResizeElement, this._sidebarDragging.bind(this), this._endSidebarDragging.bind(this), event, "col-resize");
     319        WebInspector.elementDragStart(this.sidebarResizeElement, this._sidebarDragging.bind(this), this._endSidebarDragging.bind(this), event, "ew-resize");
    320320    },
    321321
  • trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js

    r88344 r88805  
    666666    _startSidebarResizeDrag: function(event)
    667667    {
    668         WebInspector.elementDragStart(this.sidebarElement, this._sidebarResizeDrag.bind(this), this._endSidebarResizeDrag.bind(this), event, "col-resize");
     668        WebInspector.elementDragStart(this.sidebarElement, this._sidebarResizeDrag.bind(this), this._endSidebarResizeDrag.bind(this), event, "ew-resize");
    669669
    670670        if (event.target === this.sidebarResizeWidgetElement)
  • trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js

    r87776 r88805  
    222222    _resizeWindow: function(resizeElement, event)
    223223    {
    224         WebInspector.elementDragStart(resizeElement, this._windowResizeDragging.bind(this, resizeElement), this._endWindowDragging.bind(this), event, "col-resize");
     224        WebInspector.elementDragStart(resizeElement, this._windowResizeDragging.bind(this, resizeElement), this._endWindowDragging.bind(this), event, "ew-resize");
    225225    },
    226226
     
    245245                var position = event.pageX - this._overviewGrid.element.offsetLeft;
    246246                this._overviewWindowSelector = new WebInspector.TimelinePanel.WindowSelector(this._overviewGrid.element, position, event);
    247                 WebInspector.elementDragStart(null, this._windowSelectorDragging.bind(this), this._endWindowSelectorDragging.bind(this), event, "col-resize");
     247                WebInspector.elementDragStart(null, this._windowSelectorDragging.bind(this), this._endWindowSelectorDragging.bind(this), event, "ew-resize");
    248248                break;
    249249            } else if (node === this._leftResizeElement || node === this._rightResizeElement) {
  • trunk/Source/WebCore/inspector/front-end/inspector.css

    r88348 r88805  
    9898    height: 34px;
    9999    border-top: 1px solid rgb(100, 100, 100);
    100     cursor: row-resize;
     100    cursor: ns-resize;
    101101    padding-left: 0;
    102102}
     
    446446    background-repeat: no-repeat, repeat-x;
    447447    background-position: right center, center;
    448     cursor: row-resize;
     448    cursor: ns-resize;
    449449}
    450450
     
    26882688    right: 225px;
    26892689    width: 16px;
    2690     cursor: col-resize;
     2690    cursor: ew-resize;
    26912691    background-image: url(Images/statusbarResizerHorizontal.png);
    26922692    background-repeat: no-repeat;
     
    32213221    width: 5px;
    32223222    z-index: 500;
    3223     cursor: col-resize;
     3223    cursor: ew-resize;
    32243224}
    32253225
     
    37293729    background-color: rgb(153, 153, 153);
    37303730    z-index: 500;
    3731     cursor: col-resize;
     3731    cursor: ew-resize;
    37323732    -webkit-border-radius: 2px;
    37333733    -webkit-box-shadow: white 1px 0 0, white -1px 0 0, white 0 1px 0, white 0 -1px 0;
Note: See TracChangeset for help on using the changeset viewer.