Changeset 88901 in webkit

Timestamp:

Jun 14, 2011 8:41:24 PM (13 years ago)

Author:

tkent@chromium.org

Message:

2011-06-14 Kent Tamura <​tkent@chromium.org>

Reviewed by Hajime Morita.

REGRESSION(r88757): [Chromium] Vertical position of media slider thumb is wrong.
​https://bugs.webkit.org/show_bug.cgi?id=62685

No new tests. Covered by existing tests.

• rendering/RenderSlider.cpp: (WebCore::RenderSlider::layout): Center the thumb position.
• rendering/RenderSlider.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderSlider.cpp (modified) (1 diff)
• rendering/RenderSlider.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-14  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Hajime Morita.
+
+        REGRESSION(r88757): [Chromium] Vertical position of media slider thumb is wrong.
+        https://bugs.webkit.org/show_bug.cgi?id=62685
+
+        No new tests. Covered by existing tests.
+
+        * rendering/RenderSlider.cpp:
+        (WebCore::RenderSlider::layout): Center the thumb position.
+        * rendering/RenderSlider.h:
+
 2011-06-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 

trunk/Source/WebCore/rendering/RenderSlider.cpp

@@ -96 +96 @@
 }
 
+void RenderSlider::layout()
+{
+    RenderBlock::layout();
+    RenderBox* thumbBox = sliderThumbElementOf(node())->renderBox();
+    if (!thumbBox)
+        return;
+    int heightDiff = thumbBox->height() - contentHeight();
+    if (heightDiff > 0)
+        thumbBox->setY(thumbBox->y() - (heightDiff / 2));
+}
+
 bool RenderSlider::inDragMode() const
 {

trunk/Source/WebCore/rendering/RenderSlider.h

@@ -44 +44 @@
         virtual void computePreferredLogicalWidths();
         virtual bool requiresForcedStyleRecalcPropagation() const { return true; }
+        virtual void layout();
     };