Changeset 88925 in webkit

Timestamp:

Jun 15, 2011 6:57:09 AM (13 years ago)

Author:

hans@chromium.org

Message:

2011-06-14 Hans Wennborg <​hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Use fileExists() first when checking if SQLite db exists
​https://bugs.webkit.org/show_bug.cgi?id=62638

In IDBSQLiteBackingStore::backingStoreExists(), which is used to check
if a SQLite database exists and should be considered for migration,
check if the file exists first.

Trying to open a SQLite database for a non-existing file prints a
noisy error message in debug builds.

No new functionality, no new tests.

• storage/IDBSQLiteBackingStore.cpp: (WebCore::IDBSQLiteBackingStore::backingStoreExists):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• storage/IDBSQLiteBackingStore.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-14  Hans Wennborg  <hans@chromium.org>
+
+        Reviewed by Tony Gentilcore.
+
+        IndexedDB: Use fileExists() first when checking if SQLite db exists
+        https://bugs.webkit.org/show_bug.cgi?id=62638
+
+        In IDBSQLiteBackingStore::backingStoreExists(), which is used to check
+        if a SQLite database exists and should be considered for migration,
+        check if the file exists first.
+
+        Trying to open a SQLite database for a non-existing file prints a
+        noisy error message in debug builds.
+
+        No new functionality, no new tests.
+
+        * storage/IDBSQLiteBackingStore.cpp:
+        (WebCore::IDBSQLiteBackingStore::backingStoreExists):
+
 2011-06-14  Alexander Pavlov  <apavlov@chromium.org>
 

trunk/Source/WebCore/storage/IDBSQLiteBackingStore.cpp

@@ -995 +995 @@
 {
     String path = pathByAppendingComponent(pathBase, securityOrigin->databaseIdentifier() + ".indexeddb");
+    if (!fileExists(path))
+        return false;
 
     SQLiteDatabase db;