Changeset 88933 in webkit

Timestamp:

Jun 15, 2011 8:08:23 AM (13 years ago)

Author:

diegohcg@webkit.org

Message:

2011-06-15 Diego Gonzalez <​diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Inconsistent behavior on a form submit request...
​https://bugs.webkit.org/show_bug.cgi?id=45523

The inconsistency occurs when a form submission requests a new window.
Two windows are opened (instead of only one) and the first window is opened
as a blank page.

By default each page is put into their own unique page group, which affects popup windows
and visited links. Page groups (per process only) is a feature making it possible to use
separate settings for each group, so that for instance an integrated browser/email reader
can use different settings for displaying HTML pages and HTML email. To make QtWebKit work
as expected out of the box, we use a default group similar to what other ports are doing.

• Api/qwebpage.cpp:

Location:

trunk/Source/WebKit/qt

Files:

• Api/qwebpage.cpp (modified) (1 diff)
• ChangeLog (modified) (1 diff)
• tests/qwebpage/tst_qwebpage.cpp (modified) (2 diffs)

trunk/Source/WebKit/qt/Api/qwebpage.cpp

@@ -346 +346 @@
     page = new Page(pageClients);
 
+    // By default each page is put into their own unique page group, which affects popup windows
+    // and visited links. Page groups (per process only) is a feature making it possible to use
+    // separate settings for each group, so that for instance an integrated browser/email reader
+    // can use different settings for displaying HTML pages and HTML email. To make QtWebKit work
+    // as expected out of the box, we use a default group similar to what other ports are doing.
+    page->setGroupName("Default Group");
+
 #if ENABLE(CLIENT_BASED_GEOLOCATION)
     // In case running in DumpRenderTree mode set the controller to mock provider.

trunk/Source/WebKit/qt/ChangeLog

@@ +1 @@
+2011-06-15  Diego Gonzalez  <diegohcg@webkit.org>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        [Qt] Inconsistent behavior on a form submit request...
+        https://bugs.webkit.org/show_bug.cgi?id=45523
+
+        The inconsistency occurs when a form submission requests a new window.
+        Two windows are opened (instead of only one) and the first window is opened
+        as a blank page.
+
+        By default each page is put into their own unique page group, which affects popup windows
+        and visited links. Page groups (per process only) is a feature making it possible to use
+        separate settings for each group, so that for instance an integrated browser/email reader
+        can use different settings for displaying HTML pages and HTML email. To make QtWebKit work
+        as expected out of the box, we use a default group similar to what other ports are doing.
+
+        * Api/qwebpage.cpp:
+
 2011-06-14  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
 

trunk/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp

@@ -90 +90 @@
     void initTestCase();
     void cleanupTestCase();
-
     void contextMenuCopy();
     void acceptNavigationRequest();
     void geolocationRequestJS();
     void loadFinished();
+    void popupFormSubmission();
     void acceptNavigationRequestWithNewWindow();
     void userStyleSheet();
@@ -391 +391 @@
 };
 
+void tst_QWebPage::popupFormSubmission()
+{
+    TestPage page;
+    page.settings()->setAttribute(QWebSettings::JavascriptCanOpenWindows, true);
+    page.mainFrame()->setHtml("<form name=form1 method=get action='' target=myNewWin>"\
+                                "<input type=hidden name=foo value='bar'>"\
+                                "</form>");
+    page.mainFrame()->evaluateJavaScript("window.open('', 'myNewWin', 'width=500,height=300,toolbar=0')");
+    page.mainFrame()->evaluateJavaScript("document.form1.submit();");
+
+    QTest::qWait(500);
+    // The number of popup created should be one.
+    QVERIFY(page.createdWindows.size() == 1);
+
+    QString url = page.createdWindows.takeFirst()->mainFrame()->url().toString();
+    // Check if the form submission was OK.
+    QVERIFY(url.contains("?foo=bar"));
+}
+
 void tst_QWebPage::acceptNavigationRequestWithNewWindow()
 {