Changeset 88953 in webkit

Timestamp:

Jun 15, 2011 10:12:59 AM (13 years ago)

Author:

andersca@apple.com

Message:

2011-06-15 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Ignore responsiveness timer callbacks on closed pages
​https://bugs.webkit.org/show_bug.cgi?id=62735
<rdar://problem/9511295>

• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): Use nullptr instead of clear.

(WebKit::WebPageProxy::processDidBecomeUnresponsive):
Return early if the page isn't valid.

(WebKit::WebPageProxy::processDidBecomeResponsive):
Ditto.

(WebKit::WebPageProxy::updateBackingStoreDiscardableState):
Assert that the page is valid.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (4 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-06-15  Anders Carlsson  <andersca@apple.com>
+
+        Reviewed by Dan Bernstein.
+
+        Ignore responsiveness timer callbacks on closed pages
+        https://bugs.webkit.org/show_bug.cgi?id=62735
+        <rdar://problem/9511295>
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::close):
+        Use nullptr instead of clear.
+
+        (WebKit::WebPageProxy::processDidBecomeUnresponsive):
+        Return early if the page isn't valid.
+
+        (WebKit::WebPageProxy::processDidBecomeResponsive):
+        Ditto.
+
+        (WebKit::WebPageProxy::updateBackingStoreDiscardableState):
+        Assert that the page is valid.
+
 2011-06-15  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

@@ -379 +379 @@
     m_uiClient.initialize(0);
 
-    m_drawingArea.clear();
+    m_drawingArea = nullptr;
 
     process()->send(Messages::WebPage::Close(), m_pageID);
@@ -2866 +2866 @@
 void WebPageProxy::processDidBecomeUnresponsive()
 {
+    if (!isValid())
+        return;
+
     updateBackingStoreDiscardableState();
 
@@ -2873 +2876 @@
 void WebPageProxy::processDidBecomeResponsive()
 {
+    if (!isValid())
+        return;
+    
     updateBackingStoreDiscardableState();
 
@@ -3192 +3198 @@
 void WebPageProxy::updateBackingStoreDiscardableState()
 {
+    ASSERT(isValid());
+
     bool isDiscardable;