Changeset 88954 in webkit

Timestamp:

Jun 15, 2011 10:24:31 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-06-15 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: indexedDB.open() name argument is required
​https://bugs.webkit.org/show_bug.cgi?id=62398

• storage/indexeddb/database-name-undefined-expected.txt: Added.
• storage/indexeddb/database-name-undefined.html: Added.

2011-06-15 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: indexedDB.open() name argument is required
​https://bugs.webkit.org/show_bug.cgi?id=62398

Test: storage/indexeddb/database-name-undefined.html

• storage/IDBFactory.idl: use appropriate IDL magic to force undefined values to null, so we handle missing arguments as well as null arguments

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/storage/indexeddb/database-name-undefined-expected.txt (added)
• LayoutTests/storage/indexeddb/database-name-undefined.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/storage/IDBFactory.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-06-15  Mark Pilgrim  <pilgrim@chromium.org>
+
+        Reviewed by Tony Chang.
+
+        IndexedDB: indexedDB.open() name argument is required
+        https://bugs.webkit.org/show_bug.cgi?id=62398
+
+        * storage/indexeddb/database-name-undefined-expected.txt: Added.
+        * storage/indexeddb/database-name-undefined.html: Added.
+
 2011-06-15  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-15  Mark Pilgrim  <pilgrim@chromium.org>
+
+        Reviewed by Tony Chang.
+
+        IndexedDB: indexedDB.open() name argument is required
+        https://bugs.webkit.org/show_bug.cgi?id=62398
+
+        Test: storage/indexeddb/database-name-undefined.html
+
+        * storage/IDBFactory.idl: use appropriate IDL magic to force undefined values to null, so we handle missing arguments as well as null arguments
+
 2011-06-15  Tony Chang  <tony@chromium.org>
 

trunk/Source/WebCore/storage/IDBFactory.idl

@@ -29 +29 @@
         Conditional=INDEXED_DATABASE
     ] IDBFactory {
-        [CallWith=ScriptExecutionContext] IDBRequest open(in [ConvertNullToNullString] DOMString name)
+        [CallWith=ScriptExecutionContext] IDBRequest open(in [ConvertUndefinedOrNullToNullString] DOMString name)
             raises (IDBDatabaseException);
     };