Changeset 88974 in webkit

Timestamp:

Jun 15, 2011 2:46:13 PM (13 years ago)

Author:

oliver@apple.com

Message:

2011-06-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Darin Adler.

REGRESSION (r88719): 5by5.tv schedule is not visible
​https://bugs.webkit.org/show_bug.cgi?id=62720

Add test for the "interesting" ascii characters that may occur in an identifier

• fast/js/parser-syntax-check-expected.txt:
• fast/js/script-tests/parser-syntax-check.js:

2011-06-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Darin Adler.

REGRESSION (r88719): 5by5.tv schedule is not visible
​https://bugs.webkit.org/show_bug.cgi?id=62720

Problem here is that the lexer wasn't considering '$' to be
a valid character in an identifier.

• parser/Lexer.h: (JSC::Lexer::lexExpectIdentifier):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/js/parser-syntax-check-expected.txt (modified) (1 diff)
• LayoutTests/fast/js/script-tests/parser-syntax-check.js (modified) (1 diff)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/parser/Lexer.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-06-15  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by Darin Adler.
+
+        REGRESSION (r88719): 5by5.tv schedule is not visible
+        https://bugs.webkit.org/show_bug.cgi?id=62720
+
+        Add test for the "interesting" ascii characters that may occur in an identifier
+
+        * fast/js/parser-syntax-check-expected.txt:
+        * fast/js/script-tests/parser-syntax-check.js:
+
 2011-06-15  Stephen White  <senorblanco@chromium.org>
 

trunk/LayoutTests/fast/js/parser-syntax-check-expected.txt

@@ -550 +550 @@
 PASS Invalid: "'use strict'; (function __proto__(){})"
 PASS Invalid: "function f() { 'use strict'; (function __proto__(){}) }"
+PASS Valid:   "if (0) $foo; "
+PASS Valid:   "function f() { if (0) $foo;  }"
+PASS Valid:   "if (0) _foo; "
+PASS Valid:   "function f() { if (0) _foo;  }"
+PASS Valid:   "if (0) foo$; "
+PASS Valid:   "function f() { if (0) foo$;  }"
+PASS Valid:   "if (0) foo_; "
+PASS Valid:   "function f() { if (0) foo_;  }"
+PASS Valid:   "if (0) obj.$foo; "
+PASS Valid:   "function f() { if (0) obj.$foo;  }"
+PASS Valid:   "if (0) obj._foo; "
+PASS Valid:   "function f() { if (0) obj._foo;  }"
+PASS Valid:   "if (0) obj.foo$; "
+PASS Valid:   "function f() { if (0) obj.foo$;  }"
+PASS Valid:   "if (0) obj.foo_; "
+PASS Valid:   "function f() { if (0) obj.foo_;  }"
+PASS Valid:   "if (0) obj.foo\u03bb; "
+PASS Valid:   "function f() { if (0) obj.foo\u03bb;  }"
 PASS successfullyParsed is true
 

trunk/LayoutTests/fast/js/script-tests/parser-syntax-check.js

@@ -352 +352 @@
 invalid("'use strict'; (function __proto__(){})")
 
+valid("if (0) $foo; ")
+valid("if (0) _foo; ")
+valid("if (0) foo$; ")
+valid("if (0) foo_; ")
+valid("if (0) obj.$foo; ")
+valid("if (0) obj._foo; ")
+valid("if (0) obj.foo$; ")
+valid("if (0) obj.foo_; ")
+valid("if (0) obj.foo\\u03bb; ")
+
 var successfullyParsed = true;

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-06-15  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by Darin Adler.
+
+        REGRESSION (r88719): 5by5.tv schedule is not visible
+        https://bugs.webkit.org/show_bug.cgi?id=62720
+
+        Problem here is that the lexer wasn't considering '$' to be
+        a valid character in an identifier.
+
+        * parser/Lexer.h:
+        (JSC::Lexer::lexExpectIdentifier):
+
 2011-06-15  Oliver Hunt  <oliver@apple.com>
 

trunk/Source/JavaScriptCore/parser/Lexer.h

@@ -203 +203 @@
         // Here's the shift
         if (ptr < end) {
-            if (!WTF::isASCII(*ptr) || (*ptr == '\\') || (*ptr == '_'))
+            if ((!WTF::isASCII(*ptr)) || (*ptr == '\\') || (*ptr == '_') || (*ptr == '$'))
                 goto slowCase;
             m_current = *ptr;