Changeset 89005 in webkit


Ignore:
Timestamp:
Jun 15, 2011 9:40:01 PM (13 years ago)
Author:
abarth@webkit.org
Message:

2011-06-15 Adam Barth <abarth@webkit.org>

Unreviewed. (Technically I should get this reviewed, but I
accidentally committed part of this patch in my previous commit,
causing a build break.)

Remove ScriptController::m_processingTimerCallback
https://bugs.webkit.org/show_bug.cgi?id=62776

This variable is unused. (It used to be used in a user gesture detection hack.)

  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController):
  • bindings/js/ScriptController.h:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController):
  • bindings/v8/ScriptController.h:
Location:
trunk/Source/WebCore
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r89004 r89005  
     12011-06-15  Adam Barth  <abarth@webkit.org>
     2
     3        Unreviewed.  (Technically I should get this reviewed, but I
     4        accidentally committed part of this patch in my previous commit,
     5        causing a build break.)
     6
     7        Remove ScriptController::m_processingTimerCallback
     8        https://bugs.webkit.org/show_bug.cgi?id=62776
     9
     10        This variable is unused.  (It used to be used in a user gesture detection hack.)
     11
     12        * bindings/js/ScheduledAction.cpp:
     13        (WebCore::ScheduledAction::execute):
     14        * bindings/js/ScriptController.cpp:
     15        (WebCore::ScriptController::ScriptController):
     16        * bindings/js/ScriptController.h:
     17        * bindings/v8/ScriptController.cpp:
     18        (WebCore::ScriptController::ScriptController):
     19        * bindings/v8/ScriptController.h:
     20
    1212011-06-15  Kent Tamura  <tkent@chromium.org>
    222
  • trunk/Source/WebCore/bindings/js/ScheduledAction.cpp

    r85603 r89005  
    127127        return;
    128128
    129     frame->script()->setProcessingTimerCallback(true);
    130 
    131129    if (m_function) {
    132130        executeFunctionInContext(window, window->shell(), document);
     
    134132    } else
    135133        frame->script()->executeScriptInWorld(m_isolatedWorld.get(), m_code);
    136 
    137     frame->script()->setProcessingTimerCallback(false);
    138134}
    139135
  • trunk/Source/WebCore/bindings/js/ScriptController.cpp

    r89002 r89005  
    6464    , m_sourceURL(0)
    6565    , m_inExecuteScript(false)
    66     , m_processingTimerCallback(false)
    6766    , m_paused(false)
    6867#if ENABLE(NETSCAPE_PLUGIN_API)
  • trunk/Source/WebCore/bindings/js/ScriptController.h

    r89002 r89005  
    109109    void disableEval();
    110110
    111     void setProcessingTimerCallback(bool b) { m_processingTimerCallback = b; }
    112111    static bool processingUserGesture();
    113112
  • trunk/Source/WebCore/bindings/v8/ScriptController.cpp

    r89002 r89005  
    110110    , m_sourceURL(0)
    111111    , m_inExecuteScript(false)
    112     , m_processingTimerCallback(false)
    113112    , m_paused(false)
    114113    , m_proxy(adoptPtr(new V8Proxy(frame)))
  • trunk/Source/WebCore/bindings/v8/ScriptController.h

    r89001 r89005  
    158158    TextPosition0 eventHandlerPosition() const;
    159159
    160     void setProcessingTimerCallback(bool processingTimerCallback) { m_processingTimerCallback = processingTimerCallback; }
    161160    static bool processingUserGesture();
    162161
     
    196195    bool m_inExecuteScript;
    197196
    198     bool m_processingTimerCallback;
    199197    bool m_paused;
    200198
Note: See TracChangeset for help on using the changeset viewer.