Changeset 89006 in webkit

Timestamp:

Jun 15, 2011 10:12:24 PM (13 years ago)

Author:

keishi@webkit.org

Message:

2011-06-08 Keishi Hattori <​keishi@webkit.org>

Reviewed by Kent Tamura.

Fix range element not updating when value attribute is set with JS
​https://bugs.webkit.org/show_bug.cgi?id=61857

Test: fast/forms/range-set-attribute.html

• html/RangeInputType.cpp: (WebCore::RangeInputType::minOrMaxAttributeChanged): Changed to only sanitize the value when the dirty value flag is true.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/range-set-attribute-expected.txt (added)
• LayoutTests/fast/forms/range-set-attribute.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/RangeInputType.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-06-08  Keishi Hattori  <keishi@webkit.org>
+
+        Reviewed by Kent Tamura.
+
+        Fix range element not updating when value attribute is set with JS
+        https://bugs.webkit.org/show_bug.cgi?id=61857
+
+        * fast/forms/range-set-attribute-expected.txt: Added.
+        * fast/forms/range-set-attribute.html: Added. Test to see if setting the value attribute of a 
+        range input element updates the value.
+
 2011-06-15  Kent Tamura  <tkent@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-08  Keishi Hattori  <keishi@webkit.org>
+
+        Reviewed by Kent Tamura.
+
+        Fix range element not updating when value attribute is set with JS
+        https://bugs.webkit.org/show_bug.cgi?id=61857
+
+        Test: fast/forms/range-set-attribute.html
+
+        * html/RangeInputType.cpp:
+        (WebCore::RangeInputType::minOrMaxAttributeChanged): Changed to only sanitize the value when the dirty value flag is true.
+
 2011-06-15  Adam Barth  <abarth@webkit.org>
 

trunk/Source/WebCore/html/RangeInputType.cpp

@@ -252 +252 @@
 
     // Sanitize the value.
-    element()->setValue(element()->value());
+    if (element()->hasDirtyValue())
+        element()->setValue(element()->value());
     element()->setNeedsStyleRecalc();
 }