Changeset 89138 in webkit

Timestamp:

Jun 17, 2011 8:31:24 AM (13 years ago)

Author:

dbates@webkit.org

Message:

2011-06-17 Daniel Bates <​dbates@rim.com>

Rubber-stamped by Eric Seidel.

Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
​https://bugs.webkit.org/show_bug.cgi?id=62767

Part 2 of 3

Update the BuildBot master.cfg to use the new --no-build run-javascriptcore-tests
command line option instead of --skip-build.

We'll remove --skip-build from run-javascriptcore-test in a follow up patch once the
master buildbot picks up the change.

• BuildSlaveSupport/build.webkit.org-config/master.cfg:

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/master.cfg (modified) (4 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg

@@ -149 +149 @@
     logfiles = {'actual.html (source)': 'Source/JavaScriptCore/tests/mozilla/actual.html'}
 
-    def __init__(self, skipBuild=False, *args, **kwargs):
-        self.skipBuild = skipBuild
+    def __init__(self, buildJSCTool=True, *args, **kwargs):
+        self.buildJSCTool = buildJSCTool
         shell.Test.__init__(self, *args, **kwargs)
-        self.addFactoryArguments(skipBuild=skipBuild)
+        self.addFactoryArguments(buildJSCTool=buildJSCTool)
 
     def start(self):
         appendCustomBuildFlags(self, self.getProperty('platform'))
-        if self.skipBuild:
-            self.setCommand(self.command + ['--skip-build'])
+        if not self.buildJSCTool:
+            self.setCommand(self.command + ['--no-build'])
         return shell.Test.start(self)
 
@@ -200 +200 @@
                WithProperties("--%(configuration)s"), "--exit-after-n-crashes-or-timeouts", "20",  "--exit-after-n-failures", "500"]
 
-    def __init__(self, skipBuild=False, *args, **kwargs):
-        self.skipBuild = skipBuild
+    def __init__(self, buildJSCTool=True, *args, **kwargs):
+        self.buildJSCTool = buildJSCTool
         shell.Test.__init__(self, *args, **kwargs)
-        self.addFactoryArguments(skipBuild=skipBuild)
+        self.addFactoryArguments(buildJSCTool=buildJSCTool)
 
     def start(self):
@@ -212 +212 @@
         else:
             rootArgument = ['--root=WebKitBuild/bin']
-        if self.skipBuild:
+        if not self.buildJSCTool:
             self.setCommand(self.command + rootArgument)
         return shell.Test.start(self)
@@ -526 +526 @@
         self.addStep(DownloadBuiltProduct)
         self.addStep(ExtractBuiltProduct)
-        self.addStep(RunJavaScriptCoreTests, skipBuild=True)
-        self.addStep(self.TestClass, skipBuild=(platform == 'win'))
+        self.addStep(RunJavaScriptCoreTests, buildJSCTool=False)
+        self.addStep(self.TestClass, buildJSCTool=(platform != 'win'))
 
         # FIXME: Only running in debug mode due to https://bugs.webkit.org/show_bug.cgi?id=61812

trunk/Tools/ChangeLog

@@ +1 @@
+2011-06-17  Daniel Bates  <dbates@rim.com>
+
+        Rubber-stamped by Eric Seidel.
+
+        Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
+        https://bugs.webkit.org/show_bug.cgi?id=62767
+
+        Part 2 of 3
+
+        Update the BuildBot master.cfg to use the new --no-build run-javascriptcore-tests
+        command line option instead of --skip-build.
+
+        We'll remove --skip-build from run-javascriptcore-test in a follow up patch once the
+        master buildbot picks up the change.
+
+        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
+
 2011-06-17  Daniel Bates  <dbates@rim.com>