Changeset 89194 in webkit

Timestamp:

Jun 18, 2011 11:50:53 AM (13 years ago)

Author:

weinig@apple.com

Message:

REGRESSION (r63854-63958): placeholder not shown for number inputs
​https://bugs.webkit.org/show_bug.cgi?id=61095

Reviewed by Darin Adler.

Refactor HTMLInputElement supportsPlaceholder support to delegate to the
InputType. Make BaseTextInputType and NumberInputType return true, matching
the current HTML5 spec.

• html/BaseTextInputType.cpp:

(WebCore::BaseTextInputType::supportsPlaceholder):

• html/BaseTextInputType.h:

Add override implementation of supportsPlaceholder that returns true.

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::supportsPlaceholder):
Delegate to the InputType.

• html/InputType.cpp:

(WebCore::InputType::supportsPlaceholder):

• html/InputType.h:

Add base implementation of supportsPlaceholder that returns false.

• html/NumberInputType.cpp:

(WebCore::NumberInputType::supportsPlaceholder):

• html/NumberInputType.h:

Add override implementation of supportsPlaceholder that returns true.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/BaseTextInputType.cpp (modified) (1 diff)
• html/BaseTextInputType.h (modified) (1 diff)
• html/HTMLInputElement.cpp (modified) (1 diff)
• html/InputType.cpp (modified) (1 diff)
• html/InputType.h (modified) (1 diff)
• html/NumberInputType.cpp (modified) (1 diff)
• html/NumberInputType.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-18  Sam Weinig  <sam@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        REGRESSION (r63854-63958): placeholder not shown for number inputs
+        https://bugs.webkit.org/show_bug.cgi?id=61095
+
+        Refactor HTMLInputElement supportsPlaceholder support to delegate to the
+        InputType. Make BaseTextInputType and NumberInputType return true, matching
+        the current HTML5 spec.
+
+        * html/BaseTextInputType.cpp:
+        (WebCore::BaseTextInputType::supportsPlaceholder):
+        * html/BaseTextInputType.h:
+        Add override implementation of supportsPlaceholder that returns true.
+
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::supportsPlaceholder):
+        Delegate to the InputType.
+
+        * html/InputType.cpp:
+        (WebCore::InputType::supportsPlaceholder):
+        * html/InputType.h:
+        Add base implementation of supportsPlaceholder that returns false.
+
+        * html/NumberInputType.cpp:
+        (WebCore::NumberInputType::supportsPlaceholder):
+        * html/NumberInputType.h:
+        Add override implementation of supportsPlaceholder that returns true.
+
 2011-06-18  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebCore/html/BaseTextInputType.cpp

@@ -51 +51 @@
 }
 
+bool BaseTextInputType::supportsPlaceholder() const
+{
+    return true;
+}
+
 } // namespace WebCore

trunk/Source/WebCore/html/BaseTextInputType.h

@@ -45 +45 @@
     virtual bool isTextType() const;
     virtual bool patternMismatch(const String&) const;
+    virtual bool supportsPlaceholder() const;
 };
 

trunk/Source/WebCore/html/HTMLInputElement.cpp

@@ -1804 +1804 @@
 bool HTMLInputElement::supportsPlaceholder() const
 {
-    return isTextType();
+    return m_inputType->supportsPlaceholder();
 }
 

trunk/Source/WebCore/html/InputType.cpp

@@ -650 +650 @@
 }
 
+bool InputType::supportsPlaceholder() const
+{
+    return false;
+}
+
 namespace InputTypeNames {
 

trunk/Source/WebCore/html/InputType.h

@@ -223 +223 @@
     virtual bool isSteppable() const;
     virtual bool shouldRespectHeightAndWidthAttributes();
+    virtual bool supportsPlaceholder() const;
 
     // Parses the specified string for the type, and return

trunk/Source/WebCore/html/NumberInputType.cpp

@@ -265 +265 @@
 }
 
+bool NumberInputType::supportsPlaceholder() const
+{
+    return true;
+}
+
 bool NumberInputType::isNumberField() const
 {

trunk/Source/WebCore/html/NumberInputType.h

@@ -71 +71 @@
     virtual bool hasUnacceptableValue();
     virtual bool shouldRespectSpeechAttribute();
+    virtual bool supportsPlaceholder() const;
     virtual bool isNumberField() const;
 };