Changeset 89197 in webkit


Ignore:
Timestamp:
Jun 18, 2011 12:43:47 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-06-18 Holger Hans Peter Freyther <​holger@moiji-mobile.com>

Reviewed by Brent Fulgham.

[misc] JSC/wtf/text/*.h should not be included via #include ""
​https://bugs.webkit.org/show_bug.cgi?id=60836

Adam Barth pointed out that one should not include files from
JavaScriptCore/wtf/text using #include "File.h". This change
is addressing it.

  • CMakeListsEfl.txt: Remove JavaScriptCore/wtf/text.
  • CMakeListsWinCE.txt: Remove JavaScriptCore/wtf/text.
  • platform/graphics/freetype/FontCacheFreeType.cpp: Change CString.h include.
  • platform/graphics/pango/FontCachePango.cpp: Change CString.h include.
  • platform/graphics/wx/FontPlatformData.h: Change StringImpl.h include.
  • platform/network/soup/ResourceHandleSoup.cpp: Change CString.h include.
  • platform/network/soup/SocketStreamHandleSoup.cpp: Change CString.h include.

2011-06-18 Holger Hans Peter Freyther <​holger@moiji-mobile.com>

Reviewed by Brent Fulgham.

[misc] JSC/wtf/text/*.h should not be included via #include ""
​https://bugs.webkit.org/show_bug.cgi?id=60836

Adam Barth pointed out that one should not include files from
JavaScriptCore/wtf/text using #include "File.h". This change
is addressing it.

  • WebEdit.cpp: Include file via <wtf/text/File.h>.
Location:
trunk/Source
Files:
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/CMakeListsEfl.txt

    r89039 r89197  
    66LIST(APPEND WebCore_INCLUDE_DIRECTORIES
    77  "${JAVASCRIPTCORE_DIR}/wtf/gobject"
    8   "${JAVASCRIPTCORE_DIR}/wtf/text"
    98  "${WEBCORE_DIR}/platform/efl"
    109  "${WEBCORE_DIR}/platform/text/efl"

  • trunk/Source/WebCore/CMakeListsWinCE.txt

    r89039 r89197  
    11LIST(APPEND WebCore_INCLUDE_DIRECTORIES
    2     "${JAVASCRIPTCORE_DIR}/wtf/text"
    32    "${WEBCORE_DIR}/platform/wince"
    43    "${WEBCORE_DIR}/platform/win"

  • trunk/Source/WebCore/ChangeLog

    r89194 r89197  
     12011-06-18  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
     2
     3        Reviewed by Brent Fulgham.
     4
     5        [misc] JSC/wtf/text/*.h should not be included via #include ""
     6        https://bugs.webkit.org/show_bug.cgi?id=60836
     7
     8        Adam Barth pointed out that one should not include files from
     9        JavaScriptCore/wtf/text using #include "File.h". This change
     10        is addressing it.
     11
     12        * CMakeListsEfl.txt: Remove JavaScriptCore/wtf/text.
     13        * CMakeListsWinCE.txt: Remove JavaScriptCore/wtf/text.
     14        * platform/graphics/freetype/FontCacheFreeType.cpp: Change CString.h include.
     15        * platform/graphics/pango/FontCachePango.cpp: Change CString.h include.
     16        * platform/graphics/wx/FontPlatformData.h: Change StringImpl.h include.
     17        * platform/network/soup/ResourceHandleSoup.cpp: Change CString.h include.
     18        * platform/network/soup/SocketStreamHandleSoup.cpp: Change CString.h include.
     19
    1202011-06-18  Sam Weinig  <sam@webkit.org>
    221

  • trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp

    r88260 r89197  
    2323#include "FontCache.h"
    2424
    25 #include "CString.h"
    2625#include "Font.h"
    2726#include "OwnPtrCairo.h"
    … …  
    3231#include <fontconfig/fcfreetype.h>
    3332#include <wtf/Assertions.h>
     33#include <wtf/text/CString.h>
    3434
    3535namespace WebCore {

  • trunk/Source/WebCore/platform/graphics/pango/FontCachePango.cpp

    r71816 r89197  
    2222#include "FontCache.h"
    2323
    24 #include "CString.h"
    2524#include "Font.h"
    2625#include "OwnPtrCairo.h"
    2726#include "SimpleFontData.h"
    2827#include <wtf/Assertions.h>
     28#include <wtf/text/CString.h>
    2929
    3030namespace WebCore {

  • trunk/Source/WebCore/platform/graphics/wx/FontPlatformData.h

    r85036 r89197  
    3333#include "FontWidthVariant.h"
    3434#include "FontOrientation.h"
    35 #include "StringImpl.h"
    3635#include <wtf/Forward.h>
    3736#include <wtf/RefPtr.h>
    3837#include <wtf/text/AtomicString.h>
    3938#include <wtf/text/CString.h>
     39#include <wtf/text/StringImpl.h>
    4040
    4141#include <wx/defs.h>

  • trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp

    r89094 r89197  
    2929
    3030#include "Base64.h"
    31 #include "CString.h"
    3231#include "ChromeClient.h"
    3332#include "CookieJarSoup.h"
    … …  
    5857#include <sys/types.h>
    5958#include <unistd.h>
     59#include <wtf/text/CString.h>
    6060
    6161namespace WebCore {

  • trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp

    r77148 r89197  
    3232#include "SocketStreamHandle.h"
    3333
    34 #include "CString.h"
    3534#include "GOwnPtr.h"
    3635#include "KURL.h"
    … …  
    4342#include <gio/gio.h>
    4443#include <glib.h>
     44#include <wtf/text/CString.h>
    4545
    4646#define READ_BUFFER_SIZE 1024

  • trunk/Source/WebKit/wx/ChangeLog

    r88628 r89197  
     12011-06-18  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
     2
     3        Reviewed by Brent Fulgham.
     4
     5        [misc] JSC/wtf/text/*.h should not be included via #include ""
     6        https://bugs.webkit.org/show_bug.cgi?id=60836
     7
     8        Adam Barth pointed out that one should not include files from
     9        JavaScriptCore/wtf/text using #include "File.h". This change
     10        is addressing it.
     11
     12        * WebEdit.cpp: Include file via <wtf/text/File.h>.
     13
    1142011-06-12  Adam Barth  <abarth@webkit.org>
    215

  • trunk/Source/WebKit/wx/WebEdit.cpp

    r66107 r89197  
    99#include "HTMLNames.h"
    1010#include "QualifiedName.h"
    11 #include "StringImpl.h"
    1211
    1312#include "WebFrame.h"
    1413#include "WebDOMElement.h"
    1514#include <wtf/text/AtomicString.h>
     15#include <wtf/text/StringImpl.h>
    1616
    1717namespace WebCore {
Note: See TracChangeset for help on using the changeset viewer.