Changeset 89204 in webkit
- Timestamp:
- Jun 18, 2011 1:27:31 PM (13 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 8 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r89203 r89204 1 2011-06-18 Alice Boxhall <aboxhall@chromium.org> 2 3 Reviewed by Chris Fleizach. 4 5 Accessibility description for an element should make use of aria-labelledby. 6 https://bugs.webkit.org/show_bug.cgi?id=61995 7 8 * accessibility/aria-labelledby-on-input.html: 9 * accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added. 10 * accessibility/aria-labelledby-overrides-aria-label.html: Added. 11 * accessibility/aria-labelledby-overrides-label-expected.txt: 12 * accessibility/aria-labelledby-overrides-label.html: 13 * accessibility/aria-labelledby-stay-within.html: 14 * platform/mac/accessibility/aria-labelledby-on-input-expected.txt: 15 1 16 2011-06-18 Adam Bergkvist <adam.bergkvist@ericsson.com> 2 17 -
trunk/LayoutTests/accessibility/aria-labelledby-on-input.html
r35193 r89204 15 15 labeledItem.focus(); 16 16 var result = document.getElementById("result"); 17 result.innerText = "\nThe accessibility title is \"" + accessibilityController.focusedElement.title+ "\"";17 result.innerText = "\nThe accessibility description is \"" + accessibilityController.focusedElement.description + "\""; 18 18 } 19 19 </script> -
trunk/LayoutTests/accessibility/aria-labelledby-overrides-label-expected.txt
r51055 r89204 5 5 6 6 7 PASS text. title is 'AXTitle: Shut down computer after 10 minutes'7 PASS text.description is 'AXDescription: Shut down computer after 10 minutes' 8 8 PASS text.titleUIElement().isValid is false 9 9 PASS labelElement.role is 'AXRole: AXStaticText' -
trunk/LayoutTests/accessibility/aria-labelledby-overrides-label.html
r51055 r89204 27 27 text = accessibilityController.focusedElement; 28 28 29 shouldBe("text. title", "'AXTitle: Shut down computer after 10 minutes'");29 shouldBe("text.description", "'AXDescription: Shut down computer after 10 minutes'"); 30 30 31 31 // There should be no title UI element. -
trunk/LayoutTests/accessibility/aria-labelledby-stay-within.html
r46770 r89204 33 33 labeledItem.focus(); 34 34 var result = document.getElementById("result"); 35 if ( accessibilityController.focusedElement. title == "AXTitle: Reply Item Five" ) {35 if ( accessibilityController.focusedElement.description == "AXDescription: Reply Item Five" ) { 36 36 result.innerText = "Passed"; 37 37 } 38 38 else { 39 result.innerText = "Failed. Result ==" + accessibilityController.focusedElement. title+ "==";39 result.innerText = "Failed. Result ==" + accessibilityController.focusedElement.description + "=="; 40 40 } 41 41 } -
trunk/LayoutTests/platform/mac/accessibility/aria-labelledby-on-input-expected.txt
r46770 r89204 1 1 This computer will self-destruct in minutes. 2 2 3 The accessibility title is "AXTitle: This computer will self-destruct in 10 minutes."3 The accessibility description is "AXDescription: This computer will self-destruct in 10 minutes." -
trunk/Source/WebCore/ChangeLog
r89200 r89204 1 2011-06-18 Alice Boxhall <aboxhall@chromium.org> 2 3 Reviewed by Chris Fleizach. 4 5 Accessibility description for an element should make use of aria-labelledby. 6 https://bugs.webkit.org/show_bug.cgi?id=61995 7 8 Tests: accessibility/aria-labelledby-overrides-aria-label.html 9 10 * accessibility/AccessibilityRenderObject.cpp: 11 (WebCore::AccessibilityRenderObject::title): Don't return value from aria-labelledby. 12 (WebCore::AccessibilityRenderObject::ariaAccessibilityDescription): Return value from aria-labelledby in preference to value from aria-label. 13 1 14 2011-06-18 Christoph Mende <mende.christoph@gmail.com> 2 15 -
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
r88456 r89204 1306 1306 return String(); 1307 1307 1308 String ariaLabel = ariaLabeledByAttribute();1309 if (!ariaLabel.isEmpty())1310 return ariaLabel;1311 1312 1308 const AtomicString& title = getAttribute(titleAttr); 1313 1309 if (!title.isEmpty()) … … 1352 1348 String AccessibilityRenderObject::ariaAccessibilityDescription() const 1353 1349 { 1350 const AtomicString& ariaLabeledBy = ariaLabeledByAttribute(); 1351 if (!ariaLabeledBy.isEmpty()) 1352 return ariaLabeledBy; 1353 1354 1354 const AtomicString& ariaLabel = getAttribute(aria_labelAttr); 1355 1355 if (!ariaLabel.isEmpty())
Note: See TracChangeset
for help on using the changeset viewer.