Changeset 89229 in webkit


Ignore:
Timestamp:
Jun 19, 2011 9:47:20 PM (13 years ago)
Author:
keishi@webkit.org
Message:

2011-06-19 Keishi Hattori <​keishi@webkit.org>

Reviewed by Kent Tamura.

Clicking indeterminate checkbox should flip checkedness state
​https://bugs.webkit.org/show_bug.cgi?id=62262

  • fast/forms/checkbox-click-indeterminate-expected.txt: Added.
  • fast/forms/checkbox-click-indeterminate.html: Added. Tests behavior when clicking indeterminate checkbox.

2011-06-19 Keishi Hattori <​keishi@webkit.org>

Reviewed by Kent Tamura.

Clicking indeterminate checkbox should flip checkedness state
​https://bugs.webkit.org/show_bug.cgi?id=62262

Test: fast/forms/checkbox-click-indeterminate.html

  • html/CheckboxInputType.cpp: (WebCore::CheckboxInputType::willDispatchClick): Changed to flip checked flag when indeterminate.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r89228 r89229  
     12011-06-19  Keishi Hattori  <keishi@webkit.org>
     2
     3        Reviewed by Kent Tamura.
     4
     5        Clicking indeterminate checkbox should flip checkedness state
     6        https://bugs.webkit.org/show_bug.cgi?id=62262
     7
     8        * fast/forms/checkbox-click-indeterminate-expected.txt: Added.
     9        * fast/forms/checkbox-click-indeterminate.html: Added. Tests behavior when clicking indeterminate checkbox.
     10
    1112011-06-19  Oliver Hunt  <oliver@apple.com>
    212

  • trunk/Source/WebCore/ChangeLog

    r89227 r89229  
     12011-06-19  Keishi Hattori  <keishi@webkit.org>
     2
     3        Reviewed by Kent Tamura.
     4
     5        Clicking indeterminate checkbox should flip checkedness state
     6        https://bugs.webkit.org/show_bug.cgi?id=62262
     7
     8        Test: fast/forms/checkbox-click-indeterminate.html
     9
     10        * html/CheckboxInputType.cpp:
     11        (WebCore::CheckboxInputType::willDispatchClick): Changed to flip checked flag when indeterminate.
     12
    1132011-06-19  Adam Bergkvist  <adam.bergkvist@ericsson.com>
    214

  • trunk/Source/WebCore/html/CheckboxInputType.cpp

    r74895 r89229  
    8080    if (state->indeterminate)
    8181        element()->setIndeterminate(false);
    82     else
    83         element()->setChecked(!state->checked, true);
     82
     83    element()->setChecked(!state->checked, true);
    8484
    8585    return state.release();
Note: See TracChangeset for help on using the changeset viewer.