Changeset 89236 in webkit

Timestamp:

Jun 20, 2011 2:36:13 AM (13 years ago)

Author:

ager@chromium.org

Message:

2011-06-19 Mads Ager <​ager@chromium.org>

Reviewed by Adam Barth.

[V8] Fix WebGL bindings for subarrays
​https://bugs.webkit.org/show_bug.cgi?id=62864

Mark WebGL subarrays as independent of other DOM objects in the
V8 bindings. This allows us to clean them up independently which
greatly improves performance.

• bindings/v8/V8Proxy.h: (WebCore::toV8Independent):
• bindings/v8/custom/V8ArrayBufferViewCustom.h: (WebCore::constructWebGLArrayWithArrayBufferArgument): (WebCore::constructWebGLArray):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/V8Proxy.h (modified) (1 diff)
• bindings/v8/custom/V8ArrayBufferViewCustom.h (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-19  Mads Ager  <ager@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        [V8] Fix WebGL bindings for subarrays
+        https://bugs.webkit.org/show_bug.cgi?id=62864
+
+        Mark WebGL subarrays as independent of other DOM objects in the
+        V8 bindings. This allows us to clean them up independently which
+        greatly improves performance.
+
+        * bindings/v8/V8Proxy.h:
+        (WebCore::toV8Independent):
+        * bindings/v8/custom/V8ArrayBufferViewCustom.h:
+        (WebCore::constructWebGLArrayWithArrayBufferArgument):
+        (WebCore::constructWebGLArray):
+
 2011-06-20  Yuta Kitamura  <yutak@chromium.org>
 

trunk/Source/WebCore/bindings/v8/V8Proxy.h

@@ -413 +413 @@
     }
 
-    template <class T> inline v8::Handle<v8::Object> toV8(PassRefPtr<T> object, v8::Local<v8::Object> holder)
+    enum IndependentMode {
+        MarkIndependent,
+        DoNotMarkIndependent
+    };
+
+    template <class T> inline v8::Handle<v8::Object> toV8(PassRefPtr<T> object, v8::Local<v8::Object> holder, IndependentMode independent = DoNotMarkIndependent)
     {
         object->ref();
-        V8DOMWrapper::setJSWrapperForDOMObject(object.get(), v8::Persistent<v8::Object>::New(holder));
+        v8::Persistent<v8::Object> handle = v8::Persistent<v8::Object>::New(holder);
+        if (independent == MarkIndependent)
+            handle.MarkIndependent();
+        V8DOMWrapper::setJSWrapperForDOMObject(object.get(), handle);
         return holder;
     }

trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h

@@ -73 +73 @@
     if (hasIndexer)
         args.Holder()->SetIndexedPropertiesToExternalArrayData(array.get()->baseAddress(), arrayType, array.get()->length());
-    return toV8(array.release(), args.Holder());
+    return toV8(array.release(), args.Holder(), MarkIndependent);
 }
 
@@ -99 +99 @@
         // object. Not only is there no point from a performance
         // perspective, but doing so causes errors in the subset() case.
-        return toV8(array.release(), args.Holder());
+        return toV8(array.release(), args.Holder(), MarkIndependent);
     }
 
@@ -158 +158 @@
     V8DOMWrapper::setDOMWrapper(args.Holder(), type, array.get());
     args.Holder()->SetIndexedPropertiesToExternalArrayData(array.get()->baseAddress(), arrayType, array.get()->length());
-    return toV8(array.release(), args.Holder());
+    return toV8(array.release(), args.Holder(), MarkIndependent);
 }