Changeset 89258 in webkit

Timestamp:

Jun 20, 2011 10:51:40 AM (13 years ago)

Author:

abarth@webkit.org

Message:

2011-06-20 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

ASSERT in WebCore::HTMLToken::appendToAttributeName when visiting www.nba.com
​https://bugs.webkit.org/show_bug.cgi?id=61774

• fast/parser/attributes-on-close-script-expected.txt: Added.
• fast/parser/attributes-on-close-script.html: Added.

2011-06-20 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

ASSERT in WebCore::HTMLToken::appendToAttributeName when visiting www.nba.com
​https://bugs.webkit.org/show_bug.cgi?id=61774

This ASSERT triggers for the same underlying issue that causes
Bug 62971: When we tokenize a </script> tag, we don't realize that
we've already consumed the "</script>" from the input stream when we
extracted the previous token. That causes the source tracker to be
out-of-sync, triggering the incorrect view-source highlighting and this
ASSERT.

For now, let's just silence the assert while we work on Bug 62971.

Test: fast/parser/attributes-on-close-script.html

• html/parser/HTMLToken.h: (WebCore::HTMLToken::appendToAttributeName): (WebCore::AtomicHTMLToken::initializeAttributes):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/parser/attributes-on-close-script-expected.txt (added)
• LayoutTests/fast/parser/attributes-on-close-script.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/parser/HTMLToken.h (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-06-20  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Alexey Proskuryakov.
+
+        ASSERT in WebCore::HTMLToken::appendToAttributeName when visiting www.nba.com
+        https://bugs.webkit.org/show_bug.cgi?id=61774
+
+        * fast/parser/attributes-on-close-script-expected.txt: Added.
+        * fast/parser/attributes-on-close-script.html: Added.
+
 2011-06-20  Juan C. Montemayor  <jmont@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-20  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Alexey Proskuryakov.
+
+        ASSERT in WebCore::HTMLToken::appendToAttributeName when visiting www.nba.com
+        https://bugs.webkit.org/show_bug.cgi?id=61774
+
+        This ASSERT triggers for the same underlying issue that causes
+        Bug 62971: When we tokenize a </script> tag, we don't realize that
+        we've already consumed the "</script>" from the input stream when we
+        extracted the previous token.  That causes the source tracker to be
+        out-of-sync, triggering the incorrect view-source highlighting and this
+        ASSERT.
+
+        For now, let's just silence the assert while we work on Bug 62971.
+
+        Test: fast/parser/attributes-on-close-script.html
+
+        * html/parser/HTMLToken.h:
+        (WebCore::HTMLToken::appendToAttributeName):
+        (WebCore::AtomicHTMLToken::initializeAttributes):
+
 2011-06-20  Andras Becsi  <abecsi@webkit.org>
 

trunk/Source/WebCore/html/parser/HTMLToken.h

@@ -211 +211 @@
         ASSERT(character);
         ASSERT(m_type == StartTag || m_type == EndTag);
-        ASSERT(m_currentAttribute->m_nameRange.m_start);
+        // FIXME: We should be able to add the following ASSERT once we fix
+        // https://bugs.webkit.org/show_bug.cgi?id=62971
+        //   ASSERT(m_currentAttribute->m_nameRange.m_start);
         m_currentAttribute->m_name.append(character);
     }
@@ -546 +548 @@
             continue;
 
-        ASSERT(attribute.m_nameRange.m_start);
+        // FIXME: We should be able to add the following ASSERT once we fix
+        // https://bugs.webkit.org/show_bug.cgi?id=62971
+        //   ASSERT(attribute.m_nameRange.m_start);
         ASSERT(attribute.m_nameRange.m_end);
         ASSERT(attribute.m_valueRange.m_start);