Changeset 89281 in webkit


Ignore:
Timestamp:
Jun 20, 2011 12:46:23 PM (13 years ago)
Author:
oliver@apple.com
Message:

2011-06-20 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

REGRESSION (r79060): Searching for a flight at united.com fails
https://bugs.webkit.org/show_bug.cgi?id=63003

Roll out tests that were added by the patch we're rolling out, and add
a test for the united.com Date.

  • fast/js/date-parse-test-expected.txt:
  • fast/js/script-tests/date-parse-test.js:

2011-06-20 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

REGRESSION (r79060): Searching for a flight at united.com fails
https://bugs.webkit.org/show_bug.cgi?id=63003

This original change also broke Twitter, and we attempted to refine the fix to
address that problem (http://trac.webkit.org/changeset/80542), but since it still breaks United,
we need to revert the change until we understand the problem better.

  • wtf/DateMath.cpp: (WTF::parseDateFromNullTerminatedCharacters):
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r89273 r89281  
     12011-06-20  Oliver Hunt  <oliver@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        REGRESSION (r79060): Searching for a flight at united.com fails
     6        https://bugs.webkit.org/show_bug.cgi?id=63003
     7
     8        Roll out tests that were added by the patch we're rolling out, and add
     9        a test for the united.com Date.
     10
     11        * fast/js/date-parse-test-expected.txt:
     12        * fast/js/script-tests/date-parse-test.js:
     13
    1142011-06-20  Alex Milowski  <alex@milowski.com>
    215
  • trunk/LayoutTests/fast/js/date-parse-test-expected.txt

    r80542 r89281  
    162162PASS Date.parse("WED DEC 25 1995 1:30 GMT") == 819855000000 is true
    163163PASS Date.parse("wed dec 25 1995 1:30 gmt") == 819855000000 is true
    164 PASS Date.parse("Wed Dec 25 1:30 1995 GMT") == 819855000000 is true
    165 PASS Date.parse("WED DEC 25 1:30 1995 GMT") == 819855000000 is true
    166 PASS Date.parse("wed dec 25 1:30 1995 gmt") == 819855000000 is true
    167 PASS Date.parse("Wed Dec 25 1:30 1995GMT") == 819855000000 is true
    168 PASS Date.parse("Wed Dec 25 1:30 1995 2010 GMT") is NaN
    169 PASS Date.parse("Wed Dec 25 1:30 1995r GMT") is NaN
    170 PASS Date.parse("Wed 1:30 Dec 25 GMT") is NaN
    171164PASS Date.parse("Wed Dec 25 1995 01:30 +0000") == 819855000000 is true
    172165PASS Date.parse("WED DEC 25 1995 01:30 +0000") == 819855000000 is true
     
    210203PASS Date.parse("DEC 25,1995,13:30") == 819898200000 + timeZoneOffset is true
    211204PASS Date.parse("dec 25,1995,13:30") == 819898200000 + timeZoneOffset is true
     205PASS Date.parse("Mon Jun 20 11:00:00 CDT 2011") == 1308585600000 is true
     206PASS Date.parse("MON JUN 20 11:00:00 CDT 2011") == 1308585600000 is true
     207PASS Date.parse("mon jun 20 11:00:00 cdt 2011") == 1308585600000 is true
    212208PASS successfullyParsed is true
    213209
  • trunk/LayoutTests/fast/js/script-tests/date-parse-test.js

    r80542 r89281  
    128128
    129129testDateParse("Wed Dec 25 1995 1:30 GMT", "819855000000");
    130 testDateParse("Wed Dec 25 1:30 1995 GMT", "819855000000");
    131 testDateParseExact("Wed Dec 25 1:30 1995GMT", "819855000000");
    132 testDateParseExact("Wed Dec 25 1:30 1995 2010 GMT", "NaN");
    133 testDateParseExact("Wed Dec 25 1:30 1995r GMT", "NaN");
    134 testDateParseExact("Wed 1:30 Dec 25 GMT", "NaN");
    135130
    136131// RFC 2822
     
    157152testDateParse("Dec 25,1995,13:30", "819898200000 + timeZoneOffset");
    158153
    159 
     154testDateParse("Mon Jun 20 11:00:00 CDT 2011", "1308585600000");
    160155
    161156var successfullyParsed = true;
  • trunk/Source/JavaScriptCore/ChangeLog

    r89257 r89281  
     12011-06-20  Oliver Hunt  <oliver@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        REGRESSION (r79060): Searching for a flight at united.com fails
     6        https://bugs.webkit.org/show_bug.cgi?id=63003
     7
     8        This original change also broke Twitter, and we attempted to refine the fix to
     9        address that problem (http://trac.webkit.org/changeset/80542), but since it still breaks United,
     10        we need to revert the change until we understand the problem better.
     11
     12        * wtf/DateMath.cpp:
     13        (WTF::parseDateFromNullTerminatedCharacters):
     14
    1152011-06-20  Juan C. Montemayor  <jmont@apple.com>
    216
  • trunk/Source/JavaScriptCore/wtf/DateMath.cpp

    r88605 r89281  
    933933        }
    934934    }
    935    
    936     // The year may be after the time but before the time zone, but don't
    937     // confuse a time zone specificed as an offset from UTC (e.g. +0100) with a
    938     // four-digit year.
    939     if (year <= 0 && *dateString != '+' && *dateString != '-') {
    940        if (!parseLong(dateString, &newPosStr, 10, &year))
    941           year = 0;
    942        dateString = newPosStr;
    943        skipSpacesAndComments(dateString);
    944     }
    945935
    946936    // Don't fail if the time zone is missing.
Note: See TracChangeset for help on using the changeset viewer.