Changeset 89289 in webkit


Ignore:
Timestamp:
Jun 20, 2011 2:23:25 PM (13 years ago)
Author:
eric@webkit.org
Message:

2011-06-20 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue/ews-bots should run run-bindings-tests for every patch
https://bugs.webkit.org/show_bug.cgi?id=63010

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
  • Scripts/webkitpy/tool/steps/runtests_unittest.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
Location:
trunk/Tools
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r89270 r89289  
     12011-06-20  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        commit-queue/ews-bots should run run-bindings-tests for every patch
     6        https://bugs.webkit.org/show_bug.cgi?id=63010
     7
     8        * Scripts/webkitpy/common/config/ports.py:
     9        * Scripts/webkitpy/tool/commands/download_unittest.py:
     10        * Scripts/webkitpy/tool/steps/runtests.py:
     11        * Scripts/webkitpy/tool/steps/runtests_unittest.py:
     12        * Scripts/webkitpy/tool/steps/steps_unittest.py:
     13
    1142011-06-20  Chang Shu  <cshu@webkit.org>
    215
  • trunk/Tools/Scripts/webkitpy/common/config/ports.py

    r87075 r89289  
    119119
    120120    @classmethod
     121    def run_bindings_tests_command(cls):
     122        return cls.script_shell_command("run-bindings-tests")
     123
     124    @classmethod
    121125    def layout_tests_results_path(cls):
    122126        return "/tmp/layout-test-results/results.html"
  • trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py

    r84549 r89289  
    9090
    9191    def test_build_and_test(self):
    92         expected_stderr = "Updating working directory\nBuilding WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning JavaScriptCore tests\nRunning run-webkit-tests\n"
     92        expected_stderr = "Updating working directory\nBuilding WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning Bindings tests\nRunning JavaScriptCore tests\nRunning run-webkit-tests\n"
    9393        self.assert_execute_outputs(BuildAndTest(), [], options=self._default_options(), expected_stderr=expected_stderr)
    9494
     
    108108
    109109    def test_land_diff(self):
    110         expected_stderr = "Building WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning JavaScriptCore tests\nRunning run-webkit-tests\nCommitted r49824: <http://trac.webkit.org/changeset/49824>\nUpdating bug 42\n"
     110        expected_stderr = "Building WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning Bindings tests\nRunning JavaScriptCore tests\nRunning run-webkit-tests\nCommitted r49824: <http://trac.webkit.org/changeset/49824>\nUpdating bug 42\n"
    111111        mock_tool = MockTool()
    112112        mock_tool.scm().create_patch = Mock(return_value="Patch1\nMockPatch\n")
     
    118118
    119119    def test_land_red_builders(self):
    120         expected_stderr = '\nWARNING: Builders ["Builder2"] are red, please watch your commit carefully.\nSee http://dummy_buildbot_host/console?category=core\n\nBuilding WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning JavaScriptCore tests\nRunning run-webkit-tests\nCommitted r49824: <http://trac.webkit.org/changeset/49824>\nUpdating bug 42\n'
     120        expected_stderr = '\nWARNING: Builders ["Builder2"] are red, please watch your commit carefully.\nSee http://dummy_buildbot_host/console?category=core\n\nBuilding WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning Bindings tests\nRunning JavaScriptCore tests\nRunning run-webkit-tests\nCommitted r49824: <http://trac.webkit.org/changeset/49824>\nUpdating bug 42\n'
    121121        mock_tool = MockTool()
    122122        mock_tool.buildbot.light_tree_on_fire()
     
    144144Running Python unit tests
    145145Running Perl unit tests
     146Running Bindings tests
    146147Running JavaScriptCore tests
    147148Running run-webkit-tests
     
    160161Running Python unit tests
    161162Running Perl unit tests
     163Running Bindings tests
    162164Running JavaScriptCore tests
    163165Running run-webkit-tests
     
    169171Running Python unit tests
    170172Running Perl unit tests
     173Running Bindings tests
    171174Running JavaScriptCore tests
    172175Running run-webkit-tests
  • trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py

    r85524 r89289  
    5757            self._tool.executive.run_and_throw_if_fail(perl_unittests_command)
    5858
     59        bindings_tests_command = self._tool.port().run_bindings_tests_command()
     60        if bindings_tests_command:
     61            log("Running Bindings tests")
     62            self._tool.executive.run_and_throw_if_fail(bindings_tests_command)
     63
    5964        javascriptcore_tests_command = self._tool.port().run_javascriptcore_tests_command()
    6065        if javascriptcore_tests_command:
  • trunk/Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py

    r85548 r89289  
    3939        tool._port.run_perl_unittests_command = lambda: None
    4040        step = RunTests(tool, MockOptions(test=True, non_interactive=True, quiet=False))
    41         expected_stderr = """Running JavaScriptCore tests
     41        expected_stderr = """Running Bindings tests
     42Running JavaScriptCore tests
    4243Running run-webkit-tests
    4344"""
  • trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py

    r85524 r89289  
    8080Running Perl unit tests
    8181MOCK run_and_throw_if_fail: ['Tools/Scripts/test-webkitperl']
     82Running Bindings tests
     83MOCK run_and_throw_if_fail: ['Tools/Scripts/run-bindings-tests']
    8284Running JavaScriptCore tests
    8385MOCK run_and_throw_if_fail: ['Tools/Scripts/run-javascriptcore-tests']
Note: See TracChangeset for help on using the changeset viewer.