Changeset 89332 in webkit


Ignore:
Timestamp:
Jun 20, 2011 8:00:16 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-06-20 Dai Mikurube <dmikurube@chromium.org>

Reviewed by Kent Tamura.

Webkit allows disabled option as value of "required" select
https://bugs.webkit.org/show_bug.cgi?id=62668

  • fast/forms/ValidityState-valueMissing-001-expected.txt:
  • fast/forms/ValidityState-valueMissing-001.html: Changed to generate form validation error for disabled placeholder label option.

2011-06-20 Dai Mikurube <dmikurube@chromium.org>

Reviewed by Kent Tamura.

Webkit allows disabled option as value of "required" select
https://bugs.webkit.org/show_bug.cgi?id=62668

  • html/HTMLSelectElement.cpp: Removed "disabled" checking due to spec change. (WebCore::HTMLSelectElement::hasPlaceholderLabelOption):
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r89331 r89332  
     12011-06-20  Dai Mikurube  <dmikurube@chromium.org>
     2
     3        Reviewed by Kent Tamura.
     4
     5        Webkit allows disabled option as value of "required" select
     6        https://bugs.webkit.org/show_bug.cgi?id=62668
     7
     8        * fast/forms/ValidityState-valueMissing-001-expected.txt:
     9        * fast/forms/ValidityState-valueMissing-001.html: Changed to generate form validation error for disabled placeholder label option.
     10
    1112011-06-20  Kent Tamura  <tkent@chromium.org>
    212
  • trunk/LayoutTests/fast/forms/ValidityState-valueMissing-001-expected.txt

    r73606 r89332  
    1818PASS valueMissingFor("select-without-fake-placeholder-size2-multiple") is false
    1919PASS valueMissingFor("select-optgroup") is false
    20 PASS valueMissingFor("select-disabled-option") is false
     20PASS valueMissingFor("select-disabled-option") is true
    2121PASS successfullyParsed is true
    2222
  • trunk/LayoutTests/fast/forms/ValidityState-valueMissing-001.html

    r73606 r89332  
    8686    shouldBeFalse('valueMissingFor("select-without-fake-placeholder-size2-multiple")');
    8787    shouldBeFalse('valueMissingFor("select-optgroup")');
    88     shouldBeFalse('valueMissingFor("select-disabled-option")');
     88    shouldBeTrue('valueMissingFor("select-disabled-option")');
    8989
    9090    var successfullyParsed = true;
  • trunk/Source/WebCore/ChangeLog

    r89330 r89332  
     12011-06-20  Dai Mikurube  <dmikurube@chromium.org>
     2
     3        Reviewed by Kent Tamura.
     4
     5        Webkit allows disabled option as value of "required" select
     6        https://bugs.webkit.org/show_bug.cgi?id=62668
     7
     8        * html/HTMLSelectElement.cpp: Removed "disabled" checking due to spec change.
     9        (WebCore::HTMLSelectElement::hasPlaceholderLabelOption):
     10
    1112011-06-20  Zhenyao Mo  <zmo@google.com>
    212
  • trunk/Source/WebCore/html/HTMLSelectElement.cpp

    r87123 r89332  
    130130        return false;
    131131    HTMLOptionElement* option = static_cast<HTMLOptionElement*>(listItems()[listIndex]);
    132     return !option->disabled() && !listIndex && option->value().isEmpty();
     132    return !listIndex && option->value().isEmpty();
    133133}
    134134
Note: See TracChangeset for help on using the changeset viewer.