Changeset 89371 in webkit


Ignore:
Timestamp:
Jun 21, 2011 12:30:31 PM (13 years ago)
Author:
oliver@apple.com
Message:

2011-06-21 Oliver Hunt <​oliver@apple.com>

Reviewed by Alexey Proskuryakov.

REGRESSION(r89257): It broke 2 jscore tests (Requested by Ossy_away on #webkit).
​https://bugs.webkit.org/show_bug.cgi?id=63052

Release mode only failure, the stack overflow guards were getting there error
handling inlined, so that they were essentially causing their own demise.

  • parser/JSParser.cpp: (JSC::JSParser::updateErrorMessage): (JSC::JSParser::updateErrorWithNameAndMessage):
Location:
trunk/Source/JavaScriptCore
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r89311 r89371  
     12011-06-21  Oliver Hunt  <oliver@apple.com>
     2
     3        Reviewed by Alexey Proskuryakov.
     4
     5        REGRESSION(r89257): It broke 2 jscore tests (Requested by Ossy_away on #webkit).
     6        https://bugs.webkit.org/show_bug.cgi?id=63052
     7
     8        Release mode only failure, the stack overflow guards were getting there error
     9        handling inlined, so that they were essentially causing their own demise.
     10
     11        * parser/JSParser.cpp:
     12        (JSC::JSParser::updateErrorMessage):
     13        (JSC::JSParser::updateErrorWithNameAndMessage):
     14
    1152011-06-20  Kenneth Russell  <kbr@google.com>
    216

  • trunk/Source/JavaScriptCore/parser/JSParser.cpp

    r89257 r89371  
    392392    }
    393393       
    394     ALWAYS_INLINE void updateErrorMessage()
     394    NEVER_INLINE void updateErrorMessage()
    395395    {
    396396        m_error = true;
    … …  
    402402    }
    403403   
    404     ALWAYS_INLINE void updateErrorMessage(JSTokenType expectedToken)
     404    NEVER_INLINE void updateErrorMessage(JSTokenType expectedToken)
    405405    {
    406406        m_error = true;
    … …  
    412412    }
    413413   
    414     ALWAYS_INLINE void updateErrorWithNameAndMessage(const char* beforeMsg, UString name, const char* afterMsg)
     414    NEVER_INLINE void updateErrorWithNameAndMessage(const char* beforeMsg, UString name, const char* afterMsg)
    415415    {
    416416        m_error = true;
    … …  
    424424    }
    425425   
    426     ALWAYS_INLINE void updateErrorMessage(const char* msg)
     426    NEVER_INLINE void updateErrorMessage(const char* msg)
    427427    {   
    428428        m_error = true;
Note: See TracChangeset for help on using the changeset viewer.