Changeset 89760 in webkit

Timestamp:

Jun 25, 2011 9:04:07 PM (13 years ago)

Author:

Joseph Pecoraro

Message:

2011-06-25 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Fix some minor style issues
​https://bugs.webkit.org/show_bug.cgi?id=63391

• inspector/DOMNodeHighlighter.cpp: (WebCore::DOMNodeHighlighter::DrawNodeHighlight): The explicit WebCore namespace usage can be dropped.

• rendering/RenderView.cpp: (WebCore::RenderView::mapLocalToContainer): Use ASSERT_UNUSED for a parameter that we want to ASSERT on for a debug build, but is UNUSED in a release build.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/DOMNodeHighlighter.cpp (modified) (2 diffs)
• rendering/RenderView.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-25  Joseph Pecoraro  <joepeck@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        Fix some minor style issues
+        https://bugs.webkit.org/show_bug.cgi?id=63391
+
+        * inspector/DOMNodeHighlighter.cpp:
+        (WebCore::DOMNodeHighlighter::DrawNodeHighlight):
+        The explicit WebCore namespace usage can be dropped.
+
+        * rendering/RenderView.cpp:
+        (WebCore::RenderView::mapLocalToContainer):
+        Use ASSERT_UNUSED for a parameter that we want to ASSERT
+        on for a debug build, but is UNUSED in a release build.
+
 2011-06-25  Joseph Pecoraro  <joepeck@webkit.org>
 

trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp

@@ -133 +133 @@
 }
 
-void drawElementTitle(GraphicsContext& context, Node* node, const IntRect& boundingBox, const IntRect& anchorBox, const FloatRect& overlayRect, WebCore::Settings* settings)
+void drawElementTitle(GraphicsContext& context, Node* node, const IntRect& boundingBox, const IntRect& anchorBox, const FloatRect& overlayRect, Settings* settings)
 {
     static const int rectInflatePx = 4;
@@ -298 +298 @@
         return;
 
-    WebCore::Settings* settings = containingFrame->settings();
+    Settings* settings = containingFrame->settings();
     if (mode == DOMNodeHighlighter::HighlightAll)
         drawElementTitle(context, node, boundingBox, titleAnchorBox, overlayRect, settings);

trunk/Source/WebCore/rendering/RenderView.cpp

@@ -142 +142 @@
     // then we should have found it by now.
     ASSERT_ARG(repaintContainer, !repaintContainer || repaintContainer == this);
-    ASSERT(!wasFixed || *wasFixed == fixed);
-    UNUSED_PARAM(wasFixed);
+    ASSERT_UNUSED(wasFixed, !wasFixed || *wasFixed == fixed);
 
     if (!repaintContainer && useTransforms && shouldUseTransformFromContainer(0)) {