Changeset 89774 in webkit

Timestamp:

Jun 26, 2011 2:26:29 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-06-26 Young Han Lee <​joybro@company100.net>

Reviewed by Dirk Schulze.

SVGAnimation - keyTime value 1 never get animated
​https://bugs.webkit.org/show_bug.cgi?id=63230

According to the SMIL 3.0 specification, the index of the keyTimes should be
determined under the end-point-exclusive rule (e.g. Given keyTimes(0;0.5;1)
and t=0.5, the current index of the keyTimes have to be 1 not 0).
​http://www.w3.org/TR/SMIL3/smil-animation.html#animationNS-InterpolationExamplesAdvanced

• svg/animations/animate-number-calcMode-discrete-keyTimes-expected.txt: Added.
• svg/animations/animate-number-calcMode-discrete-keyTimes.html: Added.
• svg/animations/script-tests/animate-number-calcMode-discrete-keyTimes.js: Added. (sample1): (sample2): (sample3): (executeTest):

2011-06-26 Young Han Lee <​joybro@company100.net>

Reviewed by Dirk Schulze.

SVGAnimation - keyTime value 1 never get animated
​https://bugs.webkit.org/show_bug.cgi?id=63230

According to the SMIL 3.0 specification, the index of the keyTimes should be
determined under the end-point-exclusive rule (e.g. Given keyTimes(0;0.5;1)
and t=0.5, the current index of the keyTimes have to be 1 not 0).
​http://www.w3.org/TR/SMIL3/smil-animation.html#animationNS-InterpolationExamplesAdvanced

Test: svg/animations/animate-number-calcMode-discrete-keyTimes.html

• svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::calculateKeyTimesIndex):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/animations/animate-number-calcMode-discrete-keyTimes-expected.txt (added)
• LayoutTests/svg/animations/animate-number-calcMode-discrete-keyTimes.html (added)
• LayoutTests/svg/animations/script-tests/animate-number-calcMode-discrete-keyTimes.js (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/svg/SVGAnimationElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-06-26  Young Han Lee  <joybro@company100.net>
+
+        Reviewed by Dirk Schulze.
+
+        SVGAnimation - keyTime value 1 never get animated
+        https://bugs.webkit.org/show_bug.cgi?id=63230
+
+        According to the SMIL 3.0 specification, the index of the keyTimes should be 
+        determined under the end-point-exclusive rule (e.g. Given keyTimes(0;0.5;1) 
+        and t=0.5, the current index of the keyTimes have to be 1 not 0).
+        http://www.w3.org/TR/SMIL3/smil-animation.html#animationNS-InterpolationExamplesAdvanced
+
+        * svg/animations/animate-number-calcMode-discrete-keyTimes-expected.txt: Added.
+        * svg/animations/animate-number-calcMode-discrete-keyTimes.html: Added.
+        * svg/animations/script-tests/animate-number-calcMode-discrete-keyTimes.js: Added.
+        (sample1):
+        (sample2):
+        (sample3):
+        (executeTest):
+
 2011-06-26  Adam Barth  <abarth@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-26  Young Han Lee  <joybro@company100.net>
+
+        Reviewed by Dirk Schulze.
+
+        SVGAnimation - keyTime value 1 never get animated
+        https://bugs.webkit.org/show_bug.cgi?id=63230
+
+        According to the SMIL 3.0 specification, the index of the keyTimes should be 
+        determined under the end-point-exclusive rule (e.g. Given keyTimes(0;0.5;1) 
+        and t=0.5, the current index of the keyTimes have to be 1 not 0).
+        http://www.w3.org/TR/SMIL3/smil-animation.html#animationNS-InterpolationExamplesAdvanced
+
+        Test: svg/animations/animate-number-calcMode-discrete-keyTimes.html
+
+        * svg/SVGAnimationElement.cpp:
+        (WebCore::SVGAnimationElement::calculateKeyTimesIndex):
+
 2011-06-26  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/WebCore/svg/SVGAnimationElement.cpp

@@ -423 +423 @@
     unsigned keyTimesCount = m_keyTimes.size();
     for (index = 1; index < keyTimesCount; ++index) {
-        if (m_keyTimes[index] >= percent)
+        if (m_keyTimes[index] > percent)
             break;
     }