Context Navigation

Changeset 89843 in webkit

Timestamp:

Jun 27, 2011 11:47:44 AM (13 years ago)

Author:

abarth@webkit.org

Message:

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkitpy should understand crash logs
https://bugs.webkit.org/show_bug.cgi?id=63468

We're planning to use this functionality to upload crash logs along
with test results for new-run-webkit-tests.

Location:

trunk/Tools

Files:

-                      r89841
+                      r89843
+-06-27  Adam Barth  <abarth@webkit.org>
+        Reviewed by Eric Seidel.
+        webkitpy should understand crash logs
+        https://bugs.webkit.org/show_bug.cgi?id=63468
+        We're planning to use this functionality to upload crash logs along
+        with test results for new-run-webkit-tests.
+        * Scripts/webkitpy/common/system/crashlog.py: Added.
+        * Scripts/webkitpy/common/system/crashlog_unittest.py: Added.
+        * Scripts/webkitpy/common/system/executive.py:
+        * Scripts/webkitpy/common/system/executive_unittest.py:
+        * Scripts/webkitpy/common/system/filesystem.py:
+        * Scripts/webkitpy/common/system/filesystem_mock.py:
+        * Scripts/webkitpy/tool/commands/queries.py:
 -06-27  Adam Roben  <aroben@apple.com>

-                      r89412
+                      r89843
         assert(False)
+    def running_pids(self, process_name_filter=None):
+        if not process_name_filter:
+            process_name_filter = lambda process_name: True
+        running_pids = []
+        if sys.platform in ("win32", "cygwin"):
+            raise NotImplemented()
+        ps_process = self.popen(['ps', '-eo', 'pid,comm'], stdout=self.PIPE, stderr=self.PIPE)
+        stdout, _ = ps_process.communicate()
+        for line in stdout.splitlines():
+            try:
+                pid, process_name = line.split(' ', 1)
+                if process_name_filter(process_name):
+                    running_pids.append(int(pid))
+            except ValueError, e:
+                pass
+        return sorted(running_pids)
+    def wait_newest(self, process_name_filter=None):
+        if not process_name_filter:
+            process_name_filter = lambda process_name: True
+        running_pids = self.running_pids(process_name_filter)
+        if not running_pids:
+            return
+        pid = running_pids[-1]
+        while self.check_running_pid(pid):
+            time.sleep(0.25)
     def _windows_image_name(self, process_name):
         name, extension = os.path.splitext(process_name)

-                      r83015
+                      r89843
         # Maximum pid number on Linux is 32768 by default
         self.assertFalse(executive.check_running_pid(100000))
+    def test_running_pids(self):
+        if sys.platform in ("win32", "cygwin"):
+            return  # This function isn't implemented on Windows yet.
+        executive = Executive()
+        pids = executive.running_pids()
+        self.assertTrue(os.getpid() in pids)

-                      r89206
+                      r89843
         return os.path.abspath(path)
+    def expanduser(self, path):
+        return os.path.expanduser(path)
     def basename(self, path):
-        """Wraps os.path.basename()."""
         return os.path.basename(path)
     def chdir(self, path):
-        """Wraps os.chdir()."""
         return os.chdir(path)

-                      r89206
+                      r89843
         return self._split(path)[1]
+    def expanduser(self, path):
+        if path[0] != "~":
+            return path
+        parts = path.split(self.sep, 1)
+        home_directory = self.sep + "Users" + self.sep + "mock"
+        if len(parts) == 1:
+            return home_directory
+        return home_directory + self.sep + parts[1]
     def chdir(self, path):
         path = self.normpath(path)

-                      r77913
+                      r89843
 from webkitpy.common.net.buildbot import BuildBot
 from webkitpy.common.net.regressionwindow import RegressionWindow
+from webkitpy.common.system.crashlogs import CrashLogs
 from webkitpy.common.system.user import User
 from webkitpy.tool.grammar import pluralize
 …
 from webkitpy.common.system.deprecated_logging import log
 from webkitpy.layout_tests import port
 class SuggestReviewers(AbstractDeclarativeCommand):
 …
+class CrashLog(AbstractDeclarativeCommand):
+    name = "crash-log"
+    argument_names = "PROCESS_NAME"
+    def execute(self, options, args, tool):
+        crash_logs = CrashLogs(tool.executive, tool.filesystem)
+        print crash_logs.find_newest_log(args[0])
 class SkippedPorts(AbstractDeclarativeCommand):
     name = "skipped-ports"

Note: See TracChangeset for help on using the changeset viewer.