Changeset 89906 in webkit

Timestamp:

Jun 28, 2011 1:53:59 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-06-28 Shinya Kawanaka <​shinyak@google.com>

Reviewed by Kent Tamura.

Add const to show() method in WTFString and AtomicString.
​https://bugs.webkit.org/show_bug.cgi?id=63515

The lack of const in show() method is painful when
doing something like printf-debug.

• wtf/text/AtomicString.cpp: (WTF::AtomicString::show):
• wtf/text/AtomicString.h:
• wtf/text/WTFString.cpp: (String::show):
• wtf/text/WTFString.h:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• wtf/text/AtomicString.cpp (modified) (1 diff)
• wtf/text/AtomicString.h (modified) (1 diff)
• wtf/text/WTFString.cpp (modified) (1 diff)
• wtf/text/WTFString.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-06-28  Shinya Kawanaka  <shinyak@google.com>
+
+        Reviewed by Kent Tamura.
+
+        Add const to show() method in WTFString and AtomicString.
+        https://bugs.webkit.org/show_bug.cgi?id=63515
+
+        The lack of const in show() method is painful when
+        doing something like printf-debug.
+
+        * wtf/text/AtomicString.cpp:
+        (WTF::AtomicString::show):
+        * wtf/text/AtomicString.h:
+        * wtf/text/WTFString.cpp:
+        (String::show):
+        * wtf/text/WTFString.h:
+
 2011-06-27  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/JavaScriptCore/wtf/text/AtomicString.cpp

@@ -367 +367 @@
 
 #ifndef NDEBUG
-void AtomicString::show()
+void AtomicString::show() const
 {
     m_string.show();

trunk/Source/JavaScriptCore/wtf/text/AtomicString.h

@@ -115 +115 @@
 
 #ifndef NDEBUG
-    void show();
+    void show() const;
 #endif
 private:

trunk/Source/JavaScriptCore/wtf/text/WTFString.cpp

@@ -965 +965 @@
 Vector<char> asciiDebug(String& string);
 
-void String::show()
+void String::show() const
 {
     fprintf(stderr, "%s\n", asciiDebug(impl()).data());

trunk/Source/JavaScriptCore/wtf/text/WTFString.h

@@ -349 +349 @@
 
 #ifndef NDEBUG
-    void show();
+    void show() const;
 #endif