Changeset 89920 in webkit

Timestamp:

Jun 28, 2011 4:38:05 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-06-28 Michal Pakula vel Rutka <Michał Pakuła vel Rutka>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Implement EditorClientEfl::respondToChangedSelection
​https://bugs.webkit.org/show_bug.cgi?id=63525

This patch:

• implements EditorClientEfl::respondToChangedSelection,
• adds ewk_frame_editor_client_selection_changed and
• ewk_view_editor_client_selection_changed

• WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::respondToChangedSelection):
• ewk/ewk_frame.cpp: (ewk_frame_editor_client_selection_changed):
• ewk/ewk_private.h:
• ewk/ewk_view.cpp: (ewk_view_editor_client_selection_changed):

Location:

trunk/Source/WebKit/efl

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/EditorClientEfl.cpp (modified) (1 diff)
• ewk/ewk_frame.cpp (modified) (1 diff)
• ewk/ewk_private.h (modified) (2 diffs)
• ewk/ewk_view.cpp (modified) (1 diff)

trunk/Source/WebKit/efl/ChangeLog

@@ +1 @@
+2011-06-28  Michal Pakula vel Rutka  <m.pakula@samsung.com>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        [EFL] Implement EditorClientEfl::respondToChangedSelection
+        https://bugs.webkit.org/show_bug.cgi?id=63525
+
+        This patch:
+        - implements EditorClientEfl::respondToChangedSelection,
+        - adds ewk_frame_editor_client_selection_changed and
+        - ewk_view_editor_client_selection_changed
+
+        * WebCoreSupport/EditorClientEfl.cpp:
+        (WebCore::EditorClientEfl::respondToChangedSelection):
+        * ewk/ewk_frame.cpp:
+        (ewk_frame_editor_client_selection_changed):
+        * ewk/ewk_private.h:
+        * ewk/ewk_view.cpp:
+        (ewk_view_editor_client_selection_changed):
+
 2011-06-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 

trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp

@@ -128 +128 @@
 void EditorClientEfl::respondToChangedSelection()
 {
-    notImplemented();
+    Evas_Object* frame = ewk_view_frame_focused_get(m_view);
+
+    if (!frame)
+        frame = ewk_view_frame_main_get(m_view);
+
+    if (!frame)
+        return;
+
+    WebCore::Frame* coreFrame = ewk_frame_core_get(frame);
+
+    if (!coreFrame)
+        return;
+
+    if (coreFrame->editor() && coreFrame->editor()->ignoreCompositionSelectionChange())
+        return;
+
+    ewk_frame_editor_client_selection_changed(frame);
 }
 

trunk/Source/WebKit/efl/ewk/ewk_frame.cpp

@@ -1976 +1976 @@
     return 0;
 }
+
+/**
+ * @internal
+ * Reports that editor client selection was changed.
+ *
+ * @param o Frame
+ *
+ * Emits signal: "editorclientselection,changed" with no parameters.
+ */
+void ewk_frame_editor_client_selection_changed(Evas_Object* o)
+{
+    evas_object_smart_callback_call(o, "editorclient,selection,changed", 0);
+    EWK_FRAME_SD_GET_OR_RETURN(o, sd);
+    ewk_view_editor_client_selection_changed(sd->view);
+}

trunk/Source/WebKit/efl/ewk/ewk_private.h

@@ -112 +112 @@
 void ewk_view_download_request(Evas_Object *o, Ewk_Download *download);
 
+void ewk_view_editor_client_selection_changed(Evas_Object* o);
+
 int ewk_util_dpi_get(void);
 
@@ -178 +180 @@
 const char* ewk_settings_default_user_agent_get(void);
 
+void ewk_frame_editor_client_selection_changed(Evas_Object* o);
+
 #ifdef __cplusplus
 

trunk/Source/WebKit/efl/ewk/ewk_view.cpp

@@ -4499 +4499 @@
 }
 #endif
+
+/**
+ * @internal
+ * Reports the view that editor client selection has changed.
+ *
+ * @param o View.
+ *
+ * Emits signal: "editorclientselection,changed" with no parameters.
+ */
+void ewk_view_editor_client_selection_changed(Evas_Object* o)
+{
+    evas_object_smart_callback_call(o, "editorclient,selection,changed", 0);
+}