Changeset 89932 in webkit

Timestamp:

Jun 28, 2011 8:42:04 AM (13 years ago)

Author:

bfulgham@webkit.org

Message:

2011-06-27 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Adam Roben.

Avoid attempt to create a zero-size DIB.
​https://bugs.webkit.org/show_bug.cgi?id=63484.

• WebNodeHighlight.cpp: (WebNodeHighlight::update): Check for zero-height (or zero-width) region for DIB, and exit early if attempting to create a zero-size DIB/BITMAP.

Location:

trunk/Source/WebKit/win

Files:

• ChangeLog (modified) (1 diff)
• WebNodeHighlight.cpp (modified) (1 diff)

trunk/Source/WebKit/win/ChangeLog

@@ +1 @@
+2011-06-27  Brent Fulgham  <bfulgham@webkit.org>
+
+        Reviewed by Adam Roben.
+
+        Avoid attempt to create a zero-size DIB.
+        https://bugs.webkit.org/show_bug.cgi?id=63484.
+
+        * WebNodeHighlight.cpp:
+        (WebNodeHighlight::update): Check for zero-height (or zero-width)
+        region for DIB, and exit early if attempting to create a zero-size
+        DIB/BITMAP.
+
 2011-06-24  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/WebKit/win/WebNodeHighlight.cpp

@@ -146 +146 @@
     size.cy = webViewRect.bottom - webViewRect.top;
 
+    if (!size.cx || !size.cy)
+        return;
+
     BitmapInfo bitmapInfo = BitmapInfo::createBottomUp(IntSize(size));
 
     void* pixels = 0;
     OwnPtr<HBITMAP> hbmp = adoptPtr(::CreateDIBSection(hdc, &bitmapInfo, DIB_RGB_COLORS, &pixels, 0, 0));
+    ASSERT_WITH_MESSAGE(hbmp, "::CreateDIBSection failed with error %lu", ::GetLastError());
 
     ::SelectObject(hdc, hbmp.get());