Changeset 89933 in webkit

Timestamp:

Jun 28, 2011 8:56:42 AM (13 years ago)

Author:

mitz@apple.com

Message:

REGRESSION (r89733): fast/text/zero-font-size.html is failing on Leopard
​https://bugs.webkit.org/show_bug.cgi?id=63512

Reviewed by Darin Adler.

• platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformWidthForGlyph): Initialize the advance local variable, because
on Leopard wkGetGlyphTransformedAdvances can return successfully yet not update the variable when
the font size is 0. Presumably, r89733 exposed this by changing the values put on the stack just
before this function is called.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/mac/SimpleFontDataMac.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-28  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Darin Adler.
+
+        REGRESSION (r89733): fast/text/zero-font-size.html is failing on Leopard
+        https://bugs.webkit.org/show_bug.cgi?id=63512
+
+        * platform/graphics/mac/SimpleFontDataMac.mm:
+        (WebCore::SimpleFontData::platformWidthForGlyph): Initialize the advance local variable, because
+        on Leopard wkGetGlyphTransformedAdvances can return successfully yet not update the variable when
+        the font size is 0. Presumably, r89733 exposed this by changing the values put on the stack just
+        before this function is called.
+
 2011-06-27  Alexander Pavlov  <apavlov@chromium.org>
 

trunk/Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm

@@ -400 +400 @@
 float SimpleFontData::platformWidthForGlyph(Glyph glyph) const
 {
-    CGSize advance;
+    CGSize advance = CGSizeZero;
     if (platformData().orientation() == Horizontal || m_isBrokenIdeographFallback) {
         NSFont* font = platformData().font();