Changeset 89962 in webkit

Timestamp:

Jun 28, 2011 2:44:17 PM (13 years ago)

Author:

eric@webkit.org

Message:

2011-06-28 Eric Seidel <​eric@webkit.org>

Reviewed by Tony Chang.

new-run-webkit-tests needs a --webkit-test-runner option
​https://bugs.webkit.org/show_bug.cgi?id=63439

This was accidentally fixed in bug 63501 as well.
The root problem here was that the webkit unit tests were not using
enough mocks. I've fixed them here to use more mocks
which should unbreak windows.

• Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/webkit_unittest.py (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-06-28  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Tony Chang.
+
+        new-run-webkit-tests needs a --webkit-test-runner option
+        https://bugs.webkit.org/show_bug.cgi?id=63439
+
+        This was accidentally fixed in bug 63501 as well.
+        The root problem here was that the webkit unit tests were not using
+        enough mocks.  I've fixed them here to use more mocks
+        which should unbreak windows.
+
+        * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
+
 2011-06-28  Eric Seidel  <eric@webkit.org>
 

trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py

@@ -34 +34 @@
 from webkitpy.layout_tests.port import port_testcase
 
-from webkitpy.tool.mocktool import MockExecutive
-from webkitpy.tool.mocktool import MockOptions
+from webkitpy.tool.mocktool import MockExecutive, MockOptions, MockUser
 
 
@@ -41 +40 @@
     def __init__(self, symbol_list=None, feature_list=None,
                  expectations_file=None, skips_file=None,
-                 executive=None, **kwargs):
+                 executive=None, filesystem=None, user=None,
+                 **kwargs):
         self.symbol_list = symbol_list
         self.feature_list = feature_list
@@ -47 +47 @@
         self.skips_file = skips_file
         executive = executive or MockExecutive(should_log=False)
-        WebKitPort.__init__(self, executive=executive, **kwargs)
+        filesystem = filesystem or filesystem_mock.MockFileSystem()
+        user = user or MockUser()
+        WebKitPort.__init__(self, executive=executive, filesystem=filesystem, user=MockUser(), **kwargs)
 
     def _runtime_feature_list(self):