Changeset 89965 in webkit


Ignore:
Timestamp:
Jun 28, 2011 3:06:09 PM (13 years ago)
Author:
eric@webkit.org
Message:

2011-06-28 Eric Seidel <​eric@webkit.org>

Reviewed by Dirk Pranke.

Remove webkitpy's tiger support now that WebKit no longer supports tiger
​https://bugs.webkit.org/show_bug.cgi?id=63568

I don't think our support actually fully worked anyway. Regardless
tiger is dead now (thankfully)!

I also unwrapped some short lines and added a couple FIXMEs while
touring the code.

No new tests, only removing old ones which tested our Tiger support.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
  • Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
Location:
trunk/Tools
Files:
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r89963 r89965  
     12011-06-28  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Dirk Pranke.
     4
     5        Remove webkitpy's tiger support now that WebKit no longer supports tiger
     6        https://bugs.webkit.org/show_bug.cgi?id=63568
     7
     8        I don't think our support actually fully worked anyway.  Regardless
     9        tiger is dead now (thankfully)!
     10
     11        I also unwrapped some short lines and added a couple FIXMEs while
     12        touring the code.
     13
     14        No new tests, only removing old ones which tested our Tiger support.
     15
     16        * Scripts/webkitpy/layout_tests/port/base.py:
     17        * Scripts/webkitpy/layout_tests/port/builders.py:
     18        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
     19        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
     20        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
     21        * Scripts/webkitpy/layout_tests/port/mac.py:
     22        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
     23        * Scripts/webkitpy/tool/commands/rebaseline.py:
     24        * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
     25
    1262011-06-28  Eric Seidel  <eric@webkit.org>
    227

  • trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py

    r89899 r89965  
    563563
    564564    def graphics_type(self):
    565         """Returns whether the port uses accelerated graphics ('gpu') or not
    566         ('cpu')."""
     565        """Returns whether the port uses accelerated graphics ('gpu') or not ('cpu')."""
    567566        return self._graphics_type
    568567
    … …  
    903902
    904903    def _path_to_wdiff(self):
    905         """Returns the full path to the wdiff binary, or None if it is
    906         not available.
     904        """Returns the full path to the wdiff binary, or None if it is not available.
    907905
    908906        This is likely used only by wdiff_text()"""
    … …  
    912910        """Return the  full path to the top of the baseline tree for a
    913911        given platform."""
    914         return self._filesystem.join(self.layout_tests_dir(), 'platform',
    915                                      platform)
     912        return self._filesystem.join(self.layout_tests_dir(), 'platform', platform)
    916913
    917914

  • trunk/Tools/Scripts/webkitpy/layout_tests/port/builders.py

    r85797 r89965  
    6666    'gtk': 'GTK Linux 32-bit Debug',
    6767
    68     'mac-tiger': None,
    6968    'mac-leopard': 'Leopard Intel Debug (Tests)',
    7069    'mac-snowleopard': 'SnowLeopard Intel Release (Tests)',

  • trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py

    r89512 r89965  
    106106            _log.error('For complete Linux build requirements, please see:')
    107107            _log.error('')
    108             _log.error('    http://code.google.com/p/chromium/wiki/'
    109                        'LinuxBuildInstructions')
     108            _log.error('    http://code.google.com/p/chromium/wiki/LinuxBuildInstructions')
    110109        return result
    111110

  • trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py

    r89797 r89965  
    9090            _log.error('For complete Mac build requirements, please see:')
    9191            _log.error('')
    92             _log.error('    http://code.google.com/p/chromium/wiki/'
    93                        'MacBuildInstructions')
     92            _log.error('    http://code.google.com/p/chromium/wiki/MacBuildInstructions')
    9493
    9594        return result
    … …  
    123122        except OSError:
    124123            if logging:
    125                 _log.warning('wdiff not found. Install using MacPorts or some '
    126                              'other means')
     124                _log.warning('wdiff not found. Install using MacPorts or some other means')
    127125        return True
    128126
    129127    def _lighttpd_path(self, *comps):
    130         return self.path_from_chromium_base('third_party', 'lighttpd',
    131                                             'mac', *comps)
     128        return self.path_from_chromium_base('third_party', 'lighttpd', 'mac', *comps)
    132129
    133130    def _path_to_apache(self):
    … …  
    135132
    136133    def _path_to_apache_config_file(self):
    137         return self._filesystem.join(self.layout_tests_dir(), 'http', 'conf',
    138                                      'apache2-httpd.conf')
     134        return self._filesystem.join(self.layout_tests_dir(), 'http', 'conf', 'apache2-httpd.conf')
    139135
    140136    def _path_to_lighttpd(self):
    … …  
    148144
    149145    def _path_to_driver(self, configuration=None):
    150         # FIXME: make |configuration| happy with case-sensitive file
    151         # systems.
     146        # FIXME: make |configuration| happy with case-sensitive file systems.
    152147        if not configuration:
    153148            configuration = self.get_option('configuration')

  • trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py

    r88073 r89965  
    138138    class TestMacPort(chromium_mac.ChromiumMacPort):
    139139        def __init__(self, options):
     140            # FIXME: This should use MockExecutive and MockUser as well.
    140141            chromium_mac.ChromiumMacPort.__init__(self,
    141142                                                  options=options,
    … …  
    148149    class TestLinuxPort(chromium_linux.ChromiumLinuxPort):
    149150        def __init__(self, options):
     151            # FIXME: This should use MockExecutive and MockUser as well.
    150152            chromium_linux.ChromiumLinuxPort.__init__(self,
    151153                                                      options=options,
    … …  
    158160    class TestWinPort(chromium_win.ChromiumWinPort):
    159161        def __init__(self, options):
     162            # FIXME: This should use MockExecutive and MockUser as well.
    160163            chromium_win.ChromiumWinPort.__init__(self,
    161164                                                  options=options,

  • trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py

    r89899 r89965  
    4747    release_version = int(os_version_string.split('.')[1])
    4848    version_strings = {
    49         4: 'tiger',
    5049        5: 'leopard',
    5150        6: 'snowleopard',
    … …  
    6261    # FIXME: 'wk2' probably shouldn't be a version, it should probably be
    6362    # a modifier, like 'chromium-gpu' is to 'chromium'.
    64     SUPPORTED_VERSIONS = ('tiger', 'leopard', 'snowleopard', 'future', 'wk2')
     63    SUPPORTED_VERSIONS = ('leopard', 'snowleopard', 'future', 'wk2')
    6564
    6665    FALLBACK_PATHS = {
    67         'tiger': ['mac-tiger', 'mac-leopard', 'mac-snowleopard', 'mac'],
    6866        'leopard': ['mac-leopard', 'mac-snowleopard', 'mac'],
    6967        'snowleopard': ['mac-snowleopard', 'mac'],

  • trunk/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py

    r85896 r89965  
    9999        port = self.make_port()
    100100        if port:
    101             self.assertTrue(port.name() in ('mac-tiger', 'mac-leopard', 'mac-snowleopard', 'mac-future'))
    102 
    103         self.assert_name(None, '10.4.8', 'mac-tiger')
    104         self.assert_name('mac', '10.4.8', 'mac-tiger')
    105         self.assert_name('mac-tiger', '10.4.8', 'mac-tiger')
    106         self.assert_name('mac-tiger', '10.5.3', 'mac-tiger')
    107         self.assert_name('mac-tiger', '10.6.3', 'mac-tiger')
     101            self.assertTrue(port.name() in ('mac-leopard', 'mac-snowleopard', 'mac-future'))
    108102
    109103        self.assert_name(None, '10.5.3', 'mac-leopard')

  • trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py

    r74927 r89965  
    4747        r"SnowLeopard": "mac-snowleopard",
    4848        r"Leopard": "mac-leopard",
    49         r"Tiger": "mac-tiger",
    5049        r"Windows": "win",
    5150        r"GTK": "gtk",

  • trunk/Tools/Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py

    r73274 r89965  
    293293    class TestMacPort(WebKitPort):
    294294        def __init__(self):
     295            # FIXME: This should use MockExecutive and MockUser as well.
    295296            WebKitPort.__init__(self, filesystem=mock_filesystem)
    296297            self._name = 'mac'
Note: See TracChangeset for help on using the changeset viewer.