Changeset 90003 in webkit

Timestamp:

Jun 29, 2011 2:32:21 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-06-29 Ryan Sleevi <​rsleevi@chromium.org>

Reviewed by Dirk Schulze.

SVGRadialGradientElement::selfHasRelativeLengths() doesn't consider if cx() is relative
​https://bugs.webkit.org/show_bug.cgi?id=61600

Correct the logic for checking for relative lengths in a SVGRadialGradientElement to consider cx() in addition to cy()

No new tests, as there is no way to currently test this. With the bug present, a side-effect is causing the
expected/correct image to be rendered. This is because the cached SVG resource is getting invalided through a
different path, forcing a repaint. The repaint takes into consideration the proper dimensions, hiding the bug.

• svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::selfHasRelativeLengths):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• svg/SVGRadialGradientElement.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-29  Ryan Sleevi  <rsleevi@chromium.org>
+
+        Reviewed by Dirk Schulze.
+
+        SVGRadialGradientElement::selfHasRelativeLengths() doesn't consider if cx() is relative
+        https://bugs.webkit.org/show_bug.cgi?id=61600
+
+        Correct the logic for checking for relative lengths in a SVGRadialGradientElement to consider cx() in addition to cy()
+        
+        No new tests, as there is no way to currently test this. With the bug present, a side-effect is causing the
+        expected/correct image to be rendered. This is because the cached SVG resource is getting invalided through a
+        different path, forcing a repaint. The repaint takes into consideration the proper dimensions, hiding the bug.
+
+        * svg/SVGRadialGradientElement.cpp:
+        (WebCore::SVGRadialGradientElement::selfHasRelativeLengths):
+
 2011-06-28  Dirk Schulze  <krit@webkit.org>
 

trunk/Source/WebCore/svg/SVGRadialGradientElement.cpp

@@ -306 +306 @@
 bool SVGRadialGradientElement::selfHasRelativeLengths() const
 {
-    return cy().isRelative()
+    return cx().isRelative()
         || cy().isRelative()
         || r().isRelative()