Changeset 90016 in webkit


Ignore:
Timestamp:
Jun 29, 2011 7:18:40 AM (13 years ago)
Author:
Philippe Normand
Message:

Reviewed by Martin Robinson.

[webkitpy] Executive.running_pids() sometimes doesn't correctly process "ps" output
https://bugs.webkit.org/show_bug.cgi?id=63624

  • Scripts/webkitpy/common/system/executive.py: In some cases the ps output lines can contain one or more leading white-spaces, so strip it before splitting the pid and command name.
Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r90006 r90016  
     12011-06-29  Philippe Normand  <pnormand@igalia.com>
     2
     3        Reviewed by Martin Robinson.
     4
     5        [webkitpy] Executive.running_pids() sometimes doesn't correctly process "ps" output
     6        https://bugs.webkit.org/show_bug.cgi?id=63624
     7
     8        * Scripts/webkitpy/common/system/executive.py: In some cases the
     9        ps output lines can contain one or more leading white-spaces, so
     10        strip it before splitting the pid and command name.
     11
    1122011-06-29  Noel Gordon  <noel.gordon@gmail.com>
    213
  • trunk/Tools/Scripts/webkitpy/common/system/executive.py

    r89899 r90016  
    304304        for line in stdout.splitlines():
    305305            try:
    306                 pid, process_name = line.split(' ', 1)
     306                # In some cases the line can contain one or more
     307                # leading white-spaces, so strip it before split.
     308                pid, process_name = line.strip().split(' ', 1)
    307309                if process_name_filter(process_name):
    308310                    running_pids.append(int(pid))
Note: See TracChangeset for help on using the changeset viewer.